21
horus
2y

Returned from holiday. Got a Ticket that literally reads: "I commited some stuff to master. Some are quick and dirty fixes. Please Review."
I called him and was told he made some architectural changes without talking to anyone (again) and now the tests are broken and I shall repair them.

Dear colleague. ARE YOU FUCKING SERIOUS?!!!

Rage is beyond imaginable.

Comments
  • 11
    Revert the changes and mark the ticket as done
  • 5
    Maybe I should do exactly this.
  • 0
  • 3
    But srsly wouldn't he recommit his crap or whatever? This is not a solution...

    I guess I will just ignore all of this, branch from the last stable commit, implement the next relevant feature and wait until my boss returns next week. Also polishing my cv.
  • 3
    @horus it's possible to set up git so that you can only make changes to master branch through PRs
  • 1
    @electrineer I know. He insisted that commits on master should be possible "for minor, unrucial changes like updating the readme".
  • 1
    @horus If it's minor and non-crucial it won't be urgent and can just be included in whatever PR, right?
Add Comment