16

Junior Dev me: ok boss, coding is basically done, just need to do some more system testing.
Senior Dev: fantastic let me take a look.
(3 hours later)
Senior Dev: ok so I've made some small changes and pushed, could you pull my edits.
me: sure
(pulls changes)
(EVERYTHING Is changed)
(try to compile)
(doesn't compile)
Me: sorry, it doesn't seem to compile for me
Senior Dev: I never tried to actually build it, it's only a small change
me:

Comments
  • 6
    This literally happened to me all the time when I was a junior dev. Was one of the most frustrating things that ever happened to me.
  • 0
    it does seem to be a constant battle, though I'm not saying the quality of the code isn't greatly improved by their input, it would just be nice to know what's going on sometimes
  • 1
    I'm with you there bro. Not knowing what's going on and why they changed it was infuriating. It got to the point where we had weekly one on ones with the senior dev to talk about these sorts of things. It never improved, and I ended up leaving because of it.

    Been much happier since
  • 0
    Yeah I get that feeling sometimes, a lot of transitioning happening in all processes at my work atm, hoping things will begin settling soon
  • 5
    This is the reason we call it code review. They should review and suggest. Not actually add the code!

    Devs should only be coached and mentored through peer reviews. Being told why something is done a certain way encourages learning and strengthen the skills and abilities of the developer submitting the PR.
  • 1
    couldn't agree more, we've been trying to break the startup mentality as much as possible
  • 0
    The co developer LOVES to tell me a different way of doing things because that's the way SHE does it, forcing me to change my code so it matches her flow.....FMDL
Add Comment