7
manju
6y

I was reviewing a Pull Request recently and there was this line
`return josn(202, 'Record does not exists')`

I told the developer that, status code and description does not match.
He just did not want to accept that he was wrong and told me that, since this function is not exposed to public, it does not matter.

Whats wrong in accepting that you are wrong. We do make mistakes, consciously or unconsciously. Huur. I regretted reviewing his codes there after.

Comments
  • 0
    @Franboo Totally agree
  • 2
    I quit my last job because my boss was incapable of taking suggestions. Everything was a personal attack in his mind. Even suggesting the whole team wrote tests before merging or even just ran existing ones before merging caused a big arguement. The day I left the whole test server was failing to build, the pull requests set to merge were going to break the build as no CI step, and even if I got the tests running locally only 30/200 passed.

    Some people are pathetic and not worth your time.
  • 2
    PR denied.
    Fix the issues and resubmit.
  • 0
    @craig939393 Yes, I always wonder how to deal with such people :-(. If people are not willing to open up themselves, it only makes our life difficult at work. Every day morning we end up going to work with anxiety. Its going to kill us, so sometimes its better to leave the place for our own good. I feel you.
  • 0
    @Nato LOL, good one.
Add Comment