8

What's the point of opening a PR if you're just going to immediately merge it without even asking anyone to look at it? Just so you can say "Oh look I'm following process"? Well, you're not..

Comments
  • 1
    If you commit straight to master too often it might mess up parts of your CI pipeline... :)

    No but seriously, I work with guys who are pushing straight to master and I'd prefer if they would open a PR and self-merge. At least then I can have some sense of what work is related beyond the commit level, and I wouldn't have to rebase my own PRs multiple times a day to make sure the reviewer can merge without conflict.

    They are SUPPOSED to make a PR and have someone else review it but at this point I fear it's a lost cause. They think all this stuff is a waste of time. Automated testing, linting, CI, peer review, they just don't give a shit. And it shows. I really hate the projects that I work with them on now, and they were supposed to be the "fun" greenfield projects. :/
Add Comment