*Code review a PR*

“Remove extra new line here.”

  • 4
    I sometimes find myself doing that, but in the form of commits to my own projects
  • 3
    That is a legitimate comment, what is the problem with that?
  • 2
    @frozentruth Indeed. The comment is valid. New line here, space here, etc. What I hate is when I have to constantly repeat those comments in many subsequent PRs...
  • 2
    @frozentruth I’m not saying that it’s a problem. But most of the time when I have nothing to comment about the logic, I always comment on the styling.
  • 2
    @hndk use an extra-strict linter. Saves so much time and frustration
  • 1
    I am guilty of doing this.
Add Comment