9
Crazed
6y

Get assigned a PR review
Spend half an hour meticulously looking through it
Looks flawless, no errors, compiles, test cases passing, expected results
Approve request
Another developer immediately finds a flaw

Fuck. I think I am totally incapable of making myself look good.

Comments
  • 4
    You must see this from the right point of view: the other reviewer just made himself look overly pedantic ;-)
  • 1
    @fordtaunus haha maybe, but he *did* find something that was not working. Not so much something was broken, but more it was left out. My mistake was only reviewing what was changed, not what could be :x
  • 2
    Low-key that other developer is actually a tester called @Floydian :3
  • 2
    @Condor he's honestly just a ridiculously good developer, and the tech lead I work with is an order of magnitude better than both of us combined. It's humbling... Constantly lol
Add Comment