Ranter
Join devRant
Do all the things like
++ or -- rants, post your own rants, comment on others' rants and build your customized dev avatar
Sign Up
Pipeless API
From the creators of devRant, Pipeless lets you power real-time personalized recommendations and activity feeds using a simple API
Learn More
Comments
-
bertyboi1386yI haven't had the need to do it personally, but I don't hate seeing comments that an implementation is dirty.
Sometimes a fix needs to go out fast, and fixing it the proper way takes too long. Also not worth the time investment if you got future plans to rewrite or toss the current implementation.
EDIT: the first mentioned comment is tilting tho, haven't experienced it myself yet. -
waitwhat3306y@bertyboi in general I absolutely agree, but to emphasize my point, the original phrasing was "this implementation is fuKken dirtyyyyyy chicka pow powww" :(
-
bertyboi1386y@waitwhat ahh, that does make a difference. The ones I have seen have been like "This implementation is dirty because [explanation], but I do it because [explanation]"
-
Root797706yI've written things like:
until (line = get_next()).nil? do // oof. What a travesty.
It's a bad (good?) Habit from my years of C, but looks wrong and alien in Ruby. -
Voxera113886yA former colleague left code that would have been improved by a few such comments.
At least you would know he knew it was bad. But no, he kept doing the same stupid stuff for 5 years until my boss finally called him out and he quit.
Finding comments in legacy code like "too tired, fuck you" or "this implementation is dirtyyyyyy" makes me wanna punch a dev.
rant