Ranter
Join devRant
Do all the things like
++ or -- rants, post your own rants, comment on others' rants and build your customized dev avatar
Sign Up
Pipeless API
From the creators of devRant, Pipeless lets you power real-time personalized recommendations and activity feeds using a simple API
Learn More
Comments
-
How long did it take them to write that? Dear God.
And it doesn't sound like they wrote a new feature or a library. They had a unit test that was returning a wrong value. And to make that value correct, they added over 100,000 LINES?!?!
It sounds like they need more than one unit test for that. Because that is not one unit. That's is a whole bunch of units. Dear God. -
matste6425y128000 lines in 600 files = 200 lines of changes PER file. How big are these classes?
I smell some shitty code...
Related Rants
[ Coworker walks up to my desk at 4:15 PM ]
Coworker: "Hey man. We had to make a few changes to the codebase because one of our unit tests were failing. Can you take a look at a pull request for me?"
Me: "Yeah sure, how many files?"
C: "About 600"
Me: [ thinking it might just be a ton of libraries or gradle shit] "...ooookaayyyy... that's a lot but doable... how many lines?"
C: “128,000 lines"
Me: "Fuck you"
rant
pull requests
profanity
tdd
github