23

What really grinds my gears.
When a co-worker gives me feedback from a review of my code be like "you should use if..elseif..else instead of switch, because it performs much better.
in this case performing much better means it is only 25 pikosecond instead of 30 pikosecond in a function which is called apprx. 3 times a month in production *facepalm*

I'm always with "let's get maximum performance from our software", but c'mon... really?!???

Comments
  • 19
    switch(coworker) 😁
  • 11
    The guy is giving you general advice. But I agree that the difference is small enough to just be ignored. Switch case looks neater.
  • 3
    Your co-worker needs to understand that people have different ways of doing things, and they aren't wrong. Just different from how he/she would do it. When you understand that you become much more mature at reviewing code.
  • 0
    Nevertheless, his feedback had a positive effect.
    I finally decided to replace the whole mapping-structure by an injected configuration array. Because: PHP :P
Add Comment