Join devRant
Do all the things like
++ or -- rants, post your own rants, comment on others' rants and build your customized dev avatar
Sign Up
Pipeless API
From the creators of devRant, Pipeless lets you power real-time personalized recommendations and activity feeds using a simple API
Learn More
-
I believe it is a good thing to not shy away from criticism because of a big name.
If it wasn't unreasonably pendantic or just straight up unnecessary it's good to show that you aren't afraid to reason and would at least earn you my respect.
Sure a bit of teasing is going to happen, but at least everyone knows your name which may open doors for you.
And you tested the waters a bit if your lead dev would have been an ass about it I would have worried about this companies culture.
So all in all take the teases with humour and it might pay off to be the "lead developer" -
@vringar I agree, any good dev should welcome a review even from a junior dev. At worst you get to explain why their criticism is not valid. At best they actually save you from commiting something broken :)
And you might even learn something new. Being lead or veteran does not mean that you automatically stay up to date on all new developments.
Contributor badge 👍
When your GitHub repo gets a star
When your contribution table want to tell you something.
Yes it is fake 😃
Felt so awkward today. Bare in mind I am still a junior. I was on a pull request reviewing session on a repo I use. I was being super super pedantic with variable names, data types etc as the people who wrote it are brand new to the company. I then realise I had just reviewed the companies lead developers PR to a different repo. Every time someone comments on a PR on this repo all developers in the company get an email notification. I sat there litrually sweating, bright red with the words 'oh ****' on an infinite loop in my head, staring at the screen waiting to see what was to happen.
Thankfully he was ok with the comments. But now people keep calling me the lead developer (teasing) fml I hate anxiaty
undefined
small man fallen into big boys shoes
repo
pull requests