Bad dev habit: Approving junior devs PRs into master without really looking them over.

Who do that? This sounds like an intentional murder.

Better than not having peer review at all. Trainees' and juniors' code goes straight into production 😭

Approving *any* PRs without looking them over really. I'd say more PRs than not even for senior team members have at least one minor thing that needs clarifying or addressing.

@johnmelodyme murder is intentional by definition

@johnmelodyme if there are no conflicts and it passes the code quality check I just smash that merge button. Ain’t nobody got time to read every line especially when half of it is just their formatter changing indentation and quotes.

@electrineer some murder are accidental... For example my manager once gave us a long fart in meeting room, out of nowhere. Well I'm sure some of the fly just died.

@johnmelodyme it was just a normal kill, not a murder

@electrineer it was a murDa

So how do you review PRs off you have no idea what their feature or change is supposed to do? What is there to review?

@donuts

Step 1: Click the Pull requests tab
Step 2: Click on the pull-request
Step 3: Look for green check box for passing tests
Step 4: Look for green check box for no merge-conflicts
Step 5: Click merge pull-request
Step 6: Sip tea

@wackOverflow or Coffee

@wackOverflow that's what I do when I get asked and it feels like I'm doing nothing more than checking for summer issues... That a static analysis tool already does....

@donuts Pretty much. 99% of the time there is no issue, and if there is I just rollback changes to a prior release and have the old dad talk with the Juniors.

@wackOverflow or team doesn't have any olds ppl... I'm the youngest sr dev... And somehow the most technically experiences

@wackOverflow true except the 1% usually ends up with me cleaning up the mess...