Ranter
Join devRant
Do all the things like
++ or -- rants, post your own rants, comment on others' rants and build your customized dev avatar
Sign Up
Pipeless API
From the creators of devRant, Pipeless lets you power real-time personalized recommendations and activity feeds using a simple API
Learn More
Comments
-
sariel84474y@nitwhiz "We attempted to change all default values over to this other value using sed, but this one modal isn't changing and we don't know why."
-
hack64144y@petergriffin @nitwhiz Among all the good things I've done, this won't be a big problem I guess.
@sariel they can still change default modal properties and this still won't cause a bug. Because modal also accepts undefined size value. So size is optional prop. Anything other than 'small' and 'large' size acts like default size. I validated by checking components source code. So I'm not being an asshole by doing that :D -
sariel84474y@hack I think the joke is hilarious, but I wouldn't let it pass review.
it's not about changing what the default state is, it's about changing everything that is marked "default" to something else, like "large".
I try to keep my rants and jokes to comments or commits only (it really depends on how much cursing is in them).
my favorite:
#there once was a dev from nantucket
#he looked at this code and said fuckit
#so he committed his code, like one big fat chode
#and now you're reading his comments
Today a tester asked me to make a modal smaller. I read the code and saw modal size was explicitly set to "large". So I was about to set its size to default but I asked myself "what if I enter a random string there?" and I set it to "not-so-big". UI framework handled it well and actually set its size to default. I'm keeping the code that way for future laughters.
random