Join devRant
Do all the things like
++ or -- rants, post your own rants, comment on others' rants and build your customized dev avatar
Sign Up
Pipeless API
From the creators of devRant, Pipeless lets you power real-time personalized recommendations and activity feeds using a simple API
Learn More
-
you need to calm down a little bit true-dev. It's just work, there are more important things in life. Besides things like this happen all the time, It's why it's best to involve multiple people in a review, not just one. But that's not really your fault nor problem. That's for the company to figure out and implement.
Take it easy, you wont be able to build confidence in your skills if you keep worrying about what others might think. 1) It's better to put out decent code slow than shit code fast. 2) We all make mistakes, even our seniors make them all the time.
when it comes to this sort of professional space communication, I recommend not blaming anyone, but instead assume it was an accident. instead of saying "Dev A was checking it, it's his fault that he didn't see it" you could say something like "I didn't think of that and Dev A must've missed it in review, we will fix it asap". -
@Hazarth all of what <— said. Remember systems fail, not people. Things fall out of the process all the time and so do prod issues and reverts. Remember when all of Apple went down due to an incorrect dns entry from one guy? Shit happens and we fix it. Welcome to engineering, do your job to the best of your ability and trust in what you can do. Also, never start with how the problem happened vs how to get out of the problem. Some product manager somewhere will ask for a retrospective later, after it’s fixed and redeployed, and you should talk about where the process failed not any individual.
-
@Hazarth Yeah I didn't blame I guess in the mail, I just wrote " can you please share the reason why it was not identified in the review, we discussed and we were fine with it, also. I'll suggest to have these documented." , does it looks like blaming?
-
@atrabilious Yeah, I think I mailed very quickly :(
-
@Crost But I don't understand how I could have fixed it. Change was small and I saw every documentation related, nothing mentioned it.
-
@true-dev001 tests?
-
@Crost Real devs test in production and deploy on fridays.
-
@atrabilious That's what they did, I asked them to not deploy my changes to prod but they have other commits sitting on my commit which were important so even when I tried to stop them, they deployed. Even my manager was like, yeah let's go for it.
So there is this owner team who reviewed my code recently. I don't have much context about the their system and architecture. We try to build our changes with less context and rely in owner team's knowledge for any review gap.
The guy from the owner team missed something in my review and changes went to prod, review already took more that it was expected to take. He took 1 week for small change reviews. Now, not him but with someone else's advice they had to revert.
I wrote a mail shooting to manager, the guy who reverted and the guy who reviewed, asking the reviewer guy to explain why didn't he mentioned about any issues at the time of the review.
I have tried best from my side. But all this, god!!!
Why everything I do has some kind of weird issue. I feel so bad blaming the guy, I just think that, the way I used to feel anxious he must be feeling the same, but what can I do? I don't want to take the blame I don't even see if I can and I shouldn't be. If it was a major issue it should have been raised but he didn't. I feel so bad that I am almost crying, I am feeling that like always I am going to be judged by my team that work is slow and on top of that I can't do anything for the guy I blamed it on.
I don't know, is it my mistake? but I cannot think of anyway I would have known this.
rant