21
h3rp1d3v
231d

I should just quit. I am not paid enough to deal with this pissing contest.
Reviewer:
Need to add instructions (on readme) for installing pnmp, or if possible, have the top-level npm i install it (lol).
Also, it looks like we are no longer using lerna? If that's right, let's remove the dependency; its dependencies give some security audit messages at install.
Me:
it's good enough for now. Added a new ticket to resolve package manager confusions. (Migrate to pnpm workspaces)
Reviewer:
I will probably be responsible for automating deployment of this (I deployed the webapp on cloudflare pages and there is no work that needs to be done. "automating deployment" literally means replacing npm with pnpm). I disagree that it's good enough for now.

Imagine all readmes on github document how to install yarn/pnpm.

Lesson learned:
If you think an OOP static site developer can't handle modern JS framework, you are probably right.

Comments
  • 9
    Seems like hes a pretentious and ignorant dick who's trying to flex with his "higher standards" while taking the credit "for saving the world".

    Reminds me of a startup where I worked as android dev and we had a rockstar ex spotify ios consultant who took on the responsibility of fixing our android app's travis ci deployment script.

    Two fucking weeks I was asking him to do it because it was hindering my work until one day I snapped and fixed the script myself in just a few hours.

    Turns out its not rocket science and this guy just wanted to take credit for whatever he could so he could justify overcharging the shit out of this startup for doing bare minimum. His main job was basically mentoring another ios junior developer and making small fixes here and there.
  • 2
    Does the readme contain a link to any pnmp related site where you can find how to install it? If so, your reviewer is just being an ahole
Add Comment