Learn More
Resend Email
18
Grumpy
8y

Pet peeve of the week: code with "== true" at the end of boolean expressions.

if (coin.isSilver() == true) ...

which is just as sensible as

if ((coin.isSilver() == true) == true) ...

or

if (((coin.isSilver() == true) == true) == true) ...

undefined

redundance
Favorite
Ranter
Comments
  • 1
    8y
    Thoroughly agree
  • 1
    8y
    Interestingly, I DO prefer

    if(somevalue == false)

    before

    if(!somevalue)

    because it's clearer. Principle: "code is write once, read many times"
  • 2
    8y
    @pardeike it is pretty easy to miss that exclamation mark, but if you're in Node.js and you're checking for null, == false won't get the job done
  • 0
    8y
    True, my code was for a typed language, in this case swift
  • 0
    8y
    == true annoys me, == false I understand.
  • 0
    8y
    Well, some languages have truthy and falsey values, like PHP. If you want to check that the method responded with false and didn't respond with something falsey, then an === is sensible. But not seen a use case for ==.
devRant © 2021 Hexical Labs LLC
Privacy Policy  |  Terms of Service
Add Comment