So some other dev in team changed something, and it broke the tests that I wrote. Ideally the dev should be responsible for fixing the tests too when I communicated this in the team channel my manager pinged me and asked me to fix it urgently. I'm already on PIP and wth is this? am I suppose to fix these tests too?

  • 0
    I guess it depends on the tests.

    The dev should be absolutely responsible for breaking any JUnit tests or other tests that are in his domain and access

    But if these are say integration tests written by QA then QA would be responsible for maintaining the tests.

    I'm guess you, and the other dev are the same rank with same accesses, so in this case he should absolutely run the tests when he made any changes to the code and make sure they are green before pushing anywhere.

    In fact, his PR shouldn't be approved nor merged until his branch is passing. This should ideally be part of your pipeline, so there should be a big red X next to his PR and that is his responsibility to remove
  • 2
    @Hazarth yes there is a big red, but as the PR is critical, tests are skipped and PR will be merged, I was immediately assigned the tests to fix on priority without any explanation.
  • 2
    @Hazarth I have no problem if it's reasonable for me to fix it, also urgent fix will be an issue, it will impact my PIP project.
  • 1
    " Yes there is a big red, but as the PR is critical, tests are skipped and PR will be merged"

    how does this make sense?

    "QUICK, forget the failing tests that indicate that something might be wrong with the code, a bug, a regression or like 50 new issues, and just release this one tiny critical fix ASAP"

    Is this the "fixed 1 bug, created 50 new ones" meme? Are you working for the meme company? :c
  • 1
    @Hazarth haha, tests are related to some unused feature, mostly fixing test is the only option as the base functionality is changed and the feature impacted is not critical one.
  • 0
    IMO whoever made the change must ensure that all the tests are passing.

    Otherwise, if tests don't need fixing - perhaps they should be removed altogether?
Add Comment