9

Goodbye, imposter syndrome.

Today I patched a StackOverflowException bug (that I myself introduced a few months ago) which caused the prod application to crash the other day.

Now I truly feel like I belong! 😂

Comments
  • 1
    How did you do it? Tail recursion?
  • 3
    @Lensflare TIL tail recursion, thanks!

    The method checked to see whether a column is referenced by any column expressions in a table, and this naturally includes a check to return if the column we are checking is already in the collection of references.

    What I didn't account for is a user trying to reference a column in its own expression... I'd been adding the current column to the collection of references AFTER making the recursive call, so the recursion continued indefinitely 😅

    Ezpz fix, add the current column to the collection of references BEFORE the recursive call.
Add Comment