Ranter
Join devRant
Do all the things like
++ or -- rants, post your own rants, comment on others' rants and build your customized dev avatar
Sign Up
Pipeless API
From the creators of devRant, Pipeless lets you power real-time personalized recommendations and activity feeds using a simple API
Learn More
Comments
-
@theScientist I could understand getting wound up about this kind of thing if you were working on a project for GCHQ or NASA, but if you're in a less serious environment there really is no harm in it providing that the file gets renamed post-review. In fact, this is something that would keep reviewers on their toes and actually help maintain quality.
-
Neo-2627yLove it.
I encourage this kind of behaviour in my team. And they know that when the joke is over to push that already refactored and properly name commit! -
Bikonja23867yTo be fair, you did kind of tell him to fuck off. He asked for help in naming the file, you told him to figure it out yourself. Unless he realy didn't know that the file name should be something meaningful. I approve of this type of fun, if it's not under time pressure and obviously if it gets renamed to something proper (not SomethingProper.java though :))
Dev: what do I call this file ?
Me: just name it something meaningful so other dev's know what it is
Two days pass
Me: time to do code review .. oh look a new file ..
Git comment : new file for sax parsing , architecture gave the ok.
File name : SomethingMeaningful.java
undefined