Join devRant
Do all the things like
++ or -- rants, post your own rants, comment on others' rants and build your customized dev avatar
Sign Up
Pipeless API
From the creators of devRant, Pipeless lets you power real-time personalized recommendations and activity feeds using a simple API
Learn More
-
@dontPanic that's what I'm going to find out, the now I think about it the more ridiculous the situation isn
-
Addressing the unit tests, it should be common place to unit test EVERY exported client package, otherwise we run into scenarios where things don't work the way we expect them to or just don't work at all. In light of this, I've resolved a greater majority of our utilities that was butchered while adding "hot fixes".
As far as pep8/linting our Python code, why wouldn't we? We should ensure all of our code is consistent and maintainable. Otherwise, what's the point?
Regarding waiting until he left to get work done, to give some context --
I've been bringing up updating our codebase for the past 2 months in every single one of our weekly meetings. Every time I was met with the same response, "we can't just refactor all our code out of no where, we need to all agree and set aside a week to do so". It was *never* going to be done if I didn't take the initiative.
As for my code being too complex, if you're a hired Python dev and don't know what list comprehension is, there's a problem. -
@gberginc We have weekly meetings and I bring up my concerns consistently to no avail. I'm not going to beat around the bush, I'm about getting sh!# done. I don't think we should spend a week working on a feature that we can pump out in a day and iron out in two. I'm all for peer review, and for a team effort. But when you're team is riding a donkey on a nascar track, it's frustrating.
So I need to let off some steam, let me know if you think I need to calm down. Personally I'm just having a hard time understanding my team lead.
So I've been trying to update our codebase for the past two months so we run tests against the latest versions of each respective major browser. I've also been trying to cleanup our code and split it into logical modules.
Need I add, according to Bitbucket, I've written over 80% of our code on our 4 projects with 4 team members including myself.
He's out for a week, so I decide it's fine time to get some work done -- which is ridiculous in itself. I finish, add unit tests for crap I missed because he kept shutting down my PRs for shit he couldn't understand.
He tells me on Friday, when he got back, that he'll be declining my pull requests because my code is too complex -- my team lead -- thinks list comprehension and OOP in Python is too complex. Doesn't understand why we need to have pep8 lint tests, or why we can't just export one giant monolithic client package with over 3k lines of code.
Is it worth arguing or should I just let my department head know I can't work on this team anymore? He won't get talked to or fired, he's been at my company for 6 years and he's in the inner circle.
undefined