Learn More
Resend Email
9
MaNaNa
342d

My co-worker had to add some small feature, and while at it, he thought it’s a good idea to “refactor” the entire repo.

Now the code is over-modularized and full of disconnected 100 line files, just for the sake of modularity.

Sometimes less is more

rant
Favorite
Ranter
Comments
  • 1
    342d
    And he wrote no unit tests? I bet I know the answer to this one!! Holy shit, that must’ve been one huge monster commit, I bet GitHub or whatever vcs you use had a stroke. I would like to see the diff on that one lol.
  • 4
    342d
    That's some junior dev bullshit right there. 😬
  • 2
    342d
    @TeachMeCode It was about 3-4 pages of a diff 🫠

    Ah well, it’s the weekend now!
  • 1
    342d
    @MaNaNa ughh….damn. You’ve come to the right place. I feel bad you have to suffer this guy
  • 3
    342d
    Why do people go using a sledgehammer on a thumbtac?
  • 1
    342d
    Does your team have a PR process or code review? It’s one thing to push a HUGE commit but changing the ENTIRE CODEBASE?? Unless it’s really small and not well established. That’s scary, I would not want to work with someone like that
  • 1
    342d
    @TeachMeCode we do, but unfortunately his TL is VERY forgiving, hence the result.

    But it’s not a bad idea to actually talk to the TL
  • 1
    342d
    @MaNaNa damn, bad spot to be. Did he at least write unit tests?
  • 1
    342d
    @TeachMeCode he did write some, at least that part was solid and I cannot hate :)
devRant © 2021 Hexical Labs LLC
Privacy Policy  |  Terms of Service
Add Comment