Learn More
Resend Email
27
cafecortado
86d

Only 1000 files remaining to finish reviewing this PR. I'm almost there!

rant
Favorite
Ranter
Comments
  • 0
    86d
    Someone applied formatting on whole codebase? Thousand files, impossible to do
  • 3
    86d
    Hang in there!

    Wait, no. Refuse to review unless it’s a PR dedicated for reformatting only.

    Mixing features and formatting in a single PR should be a crime!
  • 5
    86d
    just hit MERGE and be done with it...
  • 1
    86d
    Hahaha what the fuck?! What kind of PR is that big? Hang in there fr
  • 2
    86d
    @netikras yeah, I'm sure that would be totally fine. Seems safe enough
  • 4
    86d
    And while you are reviewing, the Author rebased from the ever developing main branch and pushed more commits affecting the files you reviewed already
  • 1
    86d
    @netikras not a bad idea, do that and put more focus on manual testing. Make an exception

    1000 files. You changed programming language? 😂 What kinda change is it?
  • 2
    86d
    1000 remaining?! How many have you done already?
  • 2
    86d
    We've been working on a PR for a year that moves every class in the application into a new namespace.
  • 2
    86d
    instant rejection
  • 0
    86d
    @lorentz let me introduce you to IDE assisted refactoring :]
  • 2
    86d
    @spoiledgoods I mean honestly, yeah. If you can't submit a small and focused pr, don't do it at all. One of the few times where meetings aren't superfluous is when going over a refactoring commit
  • 0
    86d
    @Lensflare unfortunately C# allows retrieving type objects by qualified name, and evidently if it's possible we should do it, so we do that quite a lot.
  • 2
    86d
    @nosoup4u it's standard practice on my team to reject large PRs by default and I wouldn't have it any other way. at a certain point it's about respecting peoples' time (unless it's a critical change or something)
  • 1
    84d
    What's this? Rebase gone wrong?

    I mean I'll rather just write a new app at this point!

    One does not simply make PR after half year of pushes!
devRant © 2021 Hexical Labs LLC
Privacy Policy  |  Terms of Service
Add Comment