Ranter
Join devRant
Do all the things like
++ or -- rants, post your own rants, comment on others' rants and build your customized dev avatar
Sign Up
Pipeless API
From the creators of devRant, Pipeless lets you power real-time personalized recommendations and activity feeds using a simple API
Learn More
Comments
-
Can you give me his contact details? I'd love to have such a coworker! (no joke) 😅
I fucking pisses me off to death when my boss or coworkers commit code without using autoformat or use fucking meaningless (variable|function|class) names.
I can't write maintainable code if they continue to piss on it... -
mcmuffin486yYou should give that person a hug. I'd love to have someone on my team spending time on PRs to point out everything! Not even kidding.
-
tkdmatze4436y@PonySlaystation
Be careful what you are wishing for!
Anytime seen someone writing nearly every codeline of a unit-test in the javadoc-comment?
With certain rules about chapters (input, mock, mockreturns, call, callreturns)
With 100% testcoverage you will love(irony) to refactor code since no IDE will refactor all comments for you
Or talk about GENERATED translation files from angular
He re-formats them for "better readabilty" and blames you if you - and i repeat - do not format GENERATED FILES in his manor
I am not crying because someone better then myself tries to improve things,
i am angry because someone is thinking he is better then anyone, but only talks bullshit -
tkdmatze4436y@mcmuffin
All of our team members are taking time for PR
We often suggest simpler solutions or ask question why code is written in a certain way to let the author think about his solution
This certain guy doesn't care if it working as long it's well formatted and well named -
By PR I assume you mean peer review. The best of those are harsh ones. You don't learn anything otherwise.
Related Rants
How to deal with "Code Nazis" ?
Don't know how you call this guys that see each and every PR as a possibility to annoy everyone else
Team of 4 Devs, all with lots of experience
But there is a special one, that spams each PR with an incredible amount of comments
Most of them are non-sense like "formatting of comments" or "inlining things makes everything unreadable" or "call this variable this and that" although a reasonable name was their
Rest of team including myself is pretty pissed of by him
How to get over that?
rant
question