2
VINDIC
4y

story time
today I learned how to license a git hub project have I finally made it to intermediate developer?
------if Ur interested in a little something I did just for fun--------
https://github.com/vindicit/...

Comments
  • 1
    @shoop yep your right I should fix that thank you!
  • 1
    @shoop oh no you were kind of right it can repeat values that shouldn't be repeated through it
  • 0
    @shoop and if your wondering why it hasn't been added yet its that I plan on using noisy images of a lava lamp to generate randomness so I am just saving for server equipment
  • 0
    @shoop No, don't generate "own" randomness. Just use the OS' CSPRNG. It has already those things (and more) included and is properly designed.
  • 0
    @VINDIC Just use https://docs.microsoft.com/en-us/... , it will be secure enough.
  • 1
    @VINDIC Is there a diagram of the code so one can look at it? Is your encryption even reversible?
    Why do you have the characters of the alphabet in your code?

    This doesn't make sense:
    foreach(byte jkd in stringChars)
    {
    xor = jkd;
    }

    What?
    if(bytesTotal > 1000)
    {
    f = bytesTotal / 20;
    }
    else
    {
    f = bytesTotal * 2;
    }
    ...
    int finalSecreteSauce = ((bytesTotal*4) * 8);

    Additionally: Your long key in the author string degenerates to a single Int. If I assume thus string will be the secret part (and not your randomness, as this would make your algorithm very unusable, because key exchanges will get very, very difficult then), you effectively have 32-bit key.
  • 2
    140 line function. check
    Badly named variables. check
    Using loops instead of doing math on paper first. check

    Please fix those, my soul hurts.
  • 0
    @sbiewald yeah it doesn't make sense right now I plan on fixing that thank you for the feed back
  • 0
    @Khepu I will I am new to things like this so sorry
  • 0
    @sbiewald can i credit you for improvement on my Project ? :>
  • 1
  • 2
    @VINDIC my I suggest that you look up how DES or AES works? They're fairly straightforward things to implement (for education, never for production).

    *Why* they work well is a whole different thing though, you might want to start from an introductory book like Stallings' Computer Security and then try going through something more advanced.
Add Comment