Had a shameful moment today, when I got my PR kicked back with a comment "can you be patient and not rush this through?"

I knew that the person meant well and the code was not up to my usual standard but at the moment I felt a strong sense of inferiority. Worst thing is that it's still lingering as I am going to bed.

Hope tomorrow is a new day.

It will be, sure as the sun rises. Don’t take that feedback as indicative of your worth. That’s a shit comment from someone who is taking out their stress on you. It’s unprofessional and unwise to ridicule publicly instead of pointing out room for improvement in private. You’re being a good human by taking their feedback seriously and that speaks highly of you. Head up.

@Diactoros in my company we always discuss important improvements in the PR/MR or at least Take note of the outcomes there when we talked in private. I don't think it's rude unless the comments themselves are rude

Don't Take it to your heart too much. You already knew the code wasn't Up to your usual standards by yourself which is a good sign 👍

Thanks @Diactoros and @don-rager for your words. I woke up today feeling much better. And after a conversation with the reviewer we were able to work out the details and we are moving again.

Again thanks so much for your kind words!! :)

@don-rager There’s a difference between saying “Let’s focus on X improvement before we merge this” vs saying “Could you write better code? This is rushed”. One is professional and constructive feedback, one is demeaning and ridiculing another. I’m all for professional constructive feedback in public, it sets good standards and makes everyone strive for more. I’m not for generic public shaming.