Lensflare

4y

Today I have encountered some interesting piece of code:
In order to make a button disabled, the text of that button is assigned a grey color.
And in the click handler, there is a check if the color of the text of that button is grey, then return from it and do nothing.

That might be the ugliest hack that I had ever encountered 😆

rant

Ranter

Comments

20

Demolishun

34927

4y

I'd say this code falls into a grey area...
4

010001111

3082

4y

Whoever did this is a ducking genius in web-Frontend terms!
4

Lensflare

17166

4y

@010001111 yes. Except it wasn't web frontend but native iOS in Objective-C 😄
5

SortOfTested

20896

4y

Oh webshiters. You do you, no matter what language you end up writing.
3

C0D4

68138

4y

I am impressed, and horrified, all at the same time.

@SortOfTested we have "standards" to up hold 🤷‍♂️
10

dotnope

31

4y

"Hey, the user clicked the button! What should I do?"
"Well, it depends. Was the button...*gray* by any chance?"
1

Wisecrack

9986

4y

what if you want to change the style of color used for disabled buttons?

is this the type of situation that separation of concerns comes into play for?
4

C0D4

68138

4y

@Jilano 🤔something like

@hexbot #424242
1

C0D4

68138

4y

Or @hexbot #d2d2d2
1

hexbot

1

4y

@C0D4
3

Aedath

150

4y

I've seen some legacy code where button background color is used as a flag in code. As in if button background is green, execute x, and if yellow, execute y and so on.

devRant © 2021 Hexical Labs LLC
Privacy Policy | Terms of Service