29
10Dev
3y

Motherfucker if the project uses Eslint to enforce code standards, please don't start every fucking file with 20 lines of /*eslint-disable*/s

It's there to fucking help you and all the new devs who have to deal with your shitty code. I'm sorry that you're too fucking lazy to make a few small tweaks so that future developers don't have to deal with your sad braindead 1337speak JavaScript

Just use the fucking tool like everyone else, you don't have to fucking disable it so that your sad ego can continue to think you're the Bill Gates of JavaScript

Comments
  • 2
    oh no! 😠
  • 2
    Did somebody say PR review?
  • 5
    We had one guy (we'll call him asshat) who kept pushing code that kept reintroducing linter errors that other devs already fixed. Because asshat didn't have any linter installed. We raised it to our tech lead, but he didn't do anything about it. He also discouraged us from directly telling asshat because it would be "bad for morale" which was ridiculous.

    So every retro we'd raise the "linter errors in code" as an item for things that didn't go well, without directly naming asshat.

    Eventually one of the business partners in attendance asked if this was affecting the app, and one of us said it was producing bad quality code, and the business partner made it an action item for the tech lead to do something about it.

    Even though asshat finally installed a linter, unfortunately we don't trust his code. We've been shoehorning him into a very secluded part in the app so his stuff won't touch ours.

    Moral of the story: install a linter, use it, and don't be an asshat.
  • 0
    Raise the issue, or vote to exclude/fire that guy. Otherwise refuse to work/strike.
  • 5
    We have a very simple CI workflow that auto-denies PRs that have eslint disable for whole files or multiple times in a file and notifies the dev with a funky message to get their shit together.
  • 0
    I hated linters when I started, but then when I had a group programming project and NO ONE in the group used a linter I realized how big an importance of a linter even just for code standards so in a group of 4 there aren't 4 separate standards to work with and cause confusion and lead to unmaintainable code

    Now I still get annoyed at linters sometimes. But I do to their errors and suggestions
  • 0
    Have to admit, though... It does have some extremely redundant standards.

    Like multi-word names on files? Then you give it what it wants, rename your component to a multi-name, and it will literally tell you the same thing.

    To me, this is why eslint is a heap of shit. it will break your project because of a naming scheme.
Add Comment