3
T0D0
4y

It really irritates me when other engineers of various levels get hung up on pedantic, low hanging fruit bullshit in my merge requests. Like really, why keep a thread going just to force me to explain why I chose to make a particular magic string a constant that you don't see a use for? What about all the infrastructure setup code I spent 3 days on? Did you even read any of that to make sure it was sound and that my dumb/drunk/tired ass didn't make an obvious mistake, or could have done it better?

Comments
  • 1
    I was listening to the Coding Blocks podcast and they went over Google's code review practices / documents.

    There were a lot of rules that could have been translated: "Feel free to note these things but don't hold up a PR because of this kind of petty shit... and focus on the POINT of the PR."

    I think folks there long since recognized the time and moral wasting potential for such things.
  • 4
    I am writing an entire server for an industrial protocol. It communicates to another process and serves up data to other processes. When I asked someone to review the code the response was: looks okay.
Add Comment