Join devRant
Do all the things like
++ or -- rants, post your own rants, comment on others' rants and build your customized dev avatar
Sign Up
Pipeless API

From the creators of devRant, Pipeless lets you power real-time personalized recommendations and activity feeds using a simple API
Learn More
Search - "pull request"
-
Why write any specs anymore? The juniors don't read them, nor do the product managers. I'm just talking to myself at this point.
So, I waste time writing these nice detailed tickets, then when I go to review the pull request, the whole pile of horseshit is half done, and when I ask the product managers for resolutions, they don't have a clue either.
So just give me the whole fucking app, I'll do the whole damn thing myself. See you on Mars in 2025 while you and your pleb asses serve me fries and burgers.1 -
If you're going to request CRITICAL changes to thousands of records in the database, and approve it through testing which is done on an exact replica of production, then tell me it was done incorrectly after the fact it has been implemented and you didn't actually review the changes made to the data or business logic that you requested then you are an idiot. Our staging environment is there to ensure all the changes are accurate you useless human. Its the data you provided, I didn't just magically pull it from thin air to make yours and my job a pain the ass.undefined stupid data analysts this is why health insurance costs a buttload do your job fuckface idiots9
-
I made my very first pull request to a project of public interest.
It's just a paragraph in the React docs, but still.
I feel like a useful person.11 -
i was hired to join a team of old devs (40+) in an unnamed European country "yay goodbye 3rd world it's time to enjoy the quality of life" assist with enhancing already existing software and creating new solutions.
prior to my arrival most things were slow and super buggy, looking at the code base it shouldn't be a surprise, amateur hour everyone, logic implemented that is not needed, comment driven development, last time code review was done back in 1996. lots of anti patterns.
i swear there is a for loop that does nothing but it loops through a 100+ elements list, trunk based development with tfs since git is "not really needed"
test projects are not there.
>enter me an educated fool, with genuine passion for the craft and somehow a decent amount of knowledge.
>spent the last year fixing stuff educating people on principles and qualities.
> countless hours of training and explaining. team is showing cooperation, a new requirement comes in to develop with react.
> tear my ass creating reusable shit and self explanatory code with proper naming etc using git with feature branching, monday is first deployment day.
> today a colleague was working on an item submit a pull request and self approve it
> look at the code..... WTF the dumb fuck copied and pasted the whole code from different kendo components but somehow managed to refractor the name to test component, commented out all the code that he didn't use did the api call directly from the component, has 2 useeffects that depends on the a fucking text box changes for no reason, no redux implementation, the acceptance criteria is not achieved, and it doesn't work it just look right.
> first world country shit cannot scold, cannot complain, lead by example.
>asked him why you did this, the response was yeah probably i shouldn't have done that, i really didn't understand anything in the training but didn't want to waste time!!!!
> rest of the team created a different styled disaster with different flavors they don't even name their shit the same way.
fellow developers I'm stuck in a spaceship with a bunch of imposters, seriously i never cried in my entire life now I'm teary and on the verge of a break down.
talk with management "improving needs time" and offers me to join a yoga session to release the stress as if reaching nirvana would deliver shit on monday.
i really don't know what do is this a rant, is this a cry for help, I'm not sure, any advice is welcomed.7 -
As I went through old open PRs, to sort them out and resolve them, I started to feel you do when you look at your childhood photos or in case of YouTubers at their old videos.
That is to say, I'm dying of shame.
*Well at least I'm cleaning them up now so~*3 -
Continuing on the PR ranting.. That's six PR's in the queue now. The most important one took over a week to sort through because someone had a grand idea to generalize the work and that required a ton of changes. Great to receive that kind of feedback AFTER I've already done the work.. Then we waited on translations because can't miss those! Now the tests are failing. Not caused by me! Someone messed up the E2E tests. That's two weeks in the queue now.
Because one test is failing, that's a block across all the PR's. All of them have now been waiting multiple days in the queue. After someone manages to fix the broken test, all PR's go one by one into the QA testing queue and that takes 1-2 hours per branch to test and deploy to production.
Really love having a cycle time of four days for coloring a button differently! And the constant context switching. -
Kinda pissed. Ordered a WD red plus 8TB on November 20th from newegg along with some other stuff. He drive showed up DOA on the 26th, tested everything I could to make it work. But in the end I couldn't even get it to initialize.
Ok. No problem this happens. request a return and replacement.
Got that in today. Over 2 weeks later. Fucking EXACT same problem.
and just to make sure I'm not fucking crazy I grabbed a 1tb thats been sitting on my desk unused for years. Plugged that into my NAS. Works fucking perfectly. Even able to pull it and wipe it using my USB drive reader on my desk after. I can even fucking reinitilize it back and forth from mbr to gpt.
Not asking for replacement this time. Just refund. Gonna order directly from WD. If this one fucks up I'm switching to Seagate for a couple of years4 -
> Contribute to someones project
> Wait half a month for a response
> Ping them
> Have your PR denied without reason
> ??
> 'I reviewed it, and I'm not gonna include it.'
How about you say WHY you didn't?! -
My list of open PRs didn't descrease much since the last Rant, when I went through almost all and updated them.
Still 77 open ones.
On the other hand, my PR for the SteamCMD GUI that I had just finished was taken almost immediately!
https://github.com/DioJoestar/...1 -
Reason for rejected pull request on hacktoberfest: "wrong commit message"
...are you fucking dumb or what?
damn robot machine clowns, you wonder why you don't get better at your craft
"we love open source, making it so prohibitively convoluted to participate!!! why won't anyone contribute to our repo?!?!?!"
clowns, absolutely everywhere i swear10 -
I love when devs bitch about the size of PRs on a very standard sized one. They're all related changes that can't be broken up. Do you want the app to be broken between PRs? He spent more time bitching about the size of the diff and telling me how he does it better instead of just reviewing the code. A tip or an ask is one thing, this was a wall of text.
Oh and he still didn't approve the PR, which I know he looked at, and didn't leave any blocking comments.4 -
i hate you, you and you AHHHHHH
This doesnt have to make sense.
This is a freakin rant for god's sake, not a pull request. I'm not tryna be the best ranter?? Dont mind this rant. Just scroll. B if u can only hear my scream right now from the other side of the world, it sure can cause another big bang.
F u, this sht, (oh ya it's profanity, i got no better term for what im feelin, gahh please rip my head off) and that too, and this one too, all of u
I HATE ALL OF YOU. I BLAME ALL OF YOU FOR ALL MY INCONSISTENCIES. YE, IM TIRED OF TAKING ACCOUNTABILITY. F THAT SHT COZ IT JUST RAISES EXPECTATIONS. I CAN'T EVEN MEET THE DEADLINES I SET FOR MYSELF.
The hell are ambitions and all that "dream life" they tryna sell. Those won't even matter when I can barely get my sht together. UGH. I haven't even seen my friends, the SUN, trees and all normal people things. Dang, I want fried chicken. I haven't had one for a while. I guess I should end this rant here and order one.
I must just be hungry, no?3 -
My boss has been pretty insistent on us writing good tests (which I wholeheartedly agree with) for our new project, and being the less-experienced junior that I am, asked if we could get some guidance or a demonstration.
Took two weeks, but I finally got it said guidance... by opening a pull request with tests that weren't absolutely perfect.1 -
Writing my first code review. Even though it really is a nice review and I'm happy with the solution code, I still somehow feel like an asshole for each critique I make. Maybe it's unavoidable with code reviews / pull requests?3
-
Any android devs here? I created a simple interview tech assignment app with 2 screens (item grid and item details) with latest architecture (Compose, Retrofit, Coil, Room). Looking for a review or any kind of feedback/ideas regarding what needs to be fixed/refactored. Repo is here: https://github.com/appdevv/DemoApp
If you want, feel free to pull the repo and just make a pull request with your comments.5 -
I'm so sick and tired of the human dick head parade. Epic has us register for a fucking GitHub organization and people found a way to abuse the pull request and sending 300,000 close to 400,000 people notifications so now we're dealing with spam that's going out with random shit including someone ripping their ass hole open (picture...). Over 200 emails I swear to god. This is why castration should be legal.
Unsubscribed from one, someone creates a new useless PR.4 -
They should merge my pr first, so the one who will resolve the conflict is not me. I spent 3 days and nights cleaning 60 files in the projects. 60 files! Sadly, my manager merged other pr with 2 files changes from my junior first, destroying many of my changes.5
-
I just love when an API returns a set of results, some have property X as a string and some as a JSON array. Wtf? Good people had put great API wrappers and it works if X is string as per service specification, but breaks otherwise, unsurprisingly.
I had to do a pull request to the wrapper repository to account for this inconsistency 😶3