Join devRant
Do all the things like
++ or -- rants, post your own rants, comment on others' rants and build your customized dev avatar
Sign Up
Pipeless API
From the creators of devRant, Pipeless lets you power real-time personalized recommendations and activity feeds using a simple API
Learn More
-
Working with a team of interns, pointed out a bunch of unit tests are failing, they said they would take care of it.
10 mins later they opened a pull request to delete the tests that were failing.
fml, fml, fml, fml ... and ... oh yeah fml10 -
Git : Can't pull because there are uncommitted changes.
Me : *check the changes*
Git : None
Me : ಠ_ಠ9 -
When you've been getting lots of comments on your pull request and have to keep asking for approval.
7 -
Apparently this guy's pull request claims that his code is "very fast" (Official Linux github repository). I can't stop laughing looking at the file changes xD
File changes: https://github.com/torvalds/linux/...
Conversation: https://github.com/torvalds/linux/...
8 -
that moment when your first pull request to a major deep learning library is merged and you have no friends who understand what that means and to share your happiness!😓
no problem, you've devRant! 😁9 -
Just received my very first pull request on GitHub. Pull request: "Remove jquery as dependency".
* Makes repo private *9 -
Developer creates pull request.
I hold suggesting changes.
Developer creates new branch and new pull request with exactly the same commit.
Another Senior developer approves pull request.
This will be discussed tomorrow morning!29 -
Git Pull Failed, Merge Conflict.
Me:
don't do it
don't do it
don't do it
don't do it
don't do it
don't do it
don't do it
Me:
Delete local project folder and pull the project down again.13 -
Just did my first pull request for an open source project ever. And it actually increased test coverage for the whole project 😂2
-
!rant
Just pushed commit #512 today.
Was a huge refactoring effort which went sooooo smoothly <3
Pull from parent branch without merge conflicts <33
No issues with deployment <333
AND i'm now on vacation 🏳️🌈❤️🏳️🌈❤️🏳️🌈
Things are perfect6 -
Don't do "git pull" quickly. Always do a "git fetch" THEN "git log HEAD..origin" OR "git log -p HEAD..origin". It is like previewing first what you will "git pull".
OR something like (example):
- git fetch
- git diff origin/master
- git pull --rebase origin master
Sometimes it is a trap, you will pull other unknown or unwanted files that will cause some errors after quickly doing a git pull when working in a team. Better safe than sorry.
Other tips and tricks related are welcome 😀
Credits: https://stackoverflow.com/questions...5 -
I once reviewed a Pull Request made by a fairly junior developer. They had joined recently, and this was one of the first times they had to touch a bigger part of the code.
Due to a mix of inexperience, new (to them) coding standards and lack of git knowledge, they ended up with a mess of a PR, with a few thousand lines changed, and no way to split it off.
I ended up spending the best part of a day reviewing the whole thing and requesting changes.
Even with the long list of improvements, however, I wasn't sure they would get the magnitude of their fuckup.
So I decided to use a real-world, palpable way to show them what they had done: I went and printed the github diff for that PR. It rendered the glorious amount of 73 pages.
I'll never forget their face, and those of their teammates, when I barged into the room with a thick wad of paper and deposited them on their desk.
At least it worked. I never saw another big, ill-thought pull request from them again.3 -
I have a variable called 'stuff'. It's a test to see if my colleagues really read my pull requests.3
-
I tell him to submit a pull request, he just merges his code. I revert it and tell him to submit a pull request, he submits one then merges it himself immediately after...6
-
WHY DON'T YOU FUCKING READ THE CHANGES IN YOUR FUCKING PULL REQUEST???
If you did, you would realize that 50% of the stuff is total fucking nonsense. I don't want to see that you changed "var a = 0" to "var a= 0" just because you can't type with your shitty fingers.
Also, if you did read the changes in your PR, you would have realized that you added a bunch of totally unrelated changes in totally unrelated files.
Fuck! Am I the only one who always tries to produce a clean changeset?? Damn5 -
A badass pull request review comment: 'A wise man can learn more from a foolish question than a fool can learn from a wise answer.'2
-
[ Coworker walks up to my desk at 4:15 PM ]
Coworker: "Hey man. We had to make a few changes to the codebase because one of our unit tests were failing. Can you take a look at a pull request for me?"
Me: "Yeah sure, how many files?"
C: "About 600"
Me: [ thinking it might just be a ton of libraries or gradle shit] "...ooookaayyyy... that's a lot but doable... how many lines?"
C: “128,000 lines"
Me: "Fuck you"11 -
Why would you submit a pull request with the addition of such a comment and expect me to approve? What the hell is wrong with you?
-
Contributed to a open source project for the first time what hasn't been updated in 3 years and my pull request was just accepted!5
-
Ffs Bitbucket, is it really so much to ask for to have a mobile responsive website in 2020 to normally review my pull requests.
Not like we're giving you loads of money for your service already or anything.. 😌
6 -
```
Your branch is behind 'origin/master' by 562 commits, and can be fast-forwarded.
(use "git pull" to update your local branch)
```
`$ git pull`
```
251 files changed, 103274 insertions(+), 1361 deletions(-)
```
okay fuck.10 -
Slack Boss: hey, could you check work of dev that is okey, we want this update fast.
Me: hey, just tell him to open PR and assign me, I will check and merge changes.
Slack notification: Dev: Hey, could you please merge Pull request on the project ?
Me thinking, hmm weird, I didn't get email.
Checking github, 0 pull request.
Me: hey, I don't see any pull request open, and when you make pr, just assign me I will merge it right away.
Dev: takes half a day
Dev: Makes pr and assign correctly me.
Dev on slack: HERE is PR open now @me.
I get 3 notification to see this PR, sure at least it is there.
I check this PR, 50 commits, X conflicts, cannot merge this.
Me: Hey, @dev please fix conflicts in your PR.
DEV: takes another 2 days to respond.
Boss in the meantime: hey, have you pushed those new changes ?
Me: I am waiting for conflicts to resolve.
Dev: I fixed the conflicts @me.
I check the PR conflicts are there.
Me: are you sure you pushed your changes @dev ? I don't see them resolved
Dev: takes another day and pushes changes to resolve conflicts.
Me: merges PR to master becaus he based it on master, I will sync the developer branch myself.
All good, everybody happy.
I write to dev: Next time base your changes on develop branch and resolve conflicts before making PR.
Two weeks later new PR From this dev.
Based on Master, conflicts everywhere.8 -
Everyone complains that a certain developer's code is not up to standard and when they have to take over his project the lack of code quality is really slowing them down.
I look at code, agree it is poor quality and put together a learning plan for said developer.
Also look at who approved every pull request which allowed bad code into our codebase. Same developers as those complaining it's no good. You had your chance to stop it!9 -
Felt so awkward today. Bare in mind I am still a junior. I was on a pull request reviewing session on a repo I use. I was being super super pedantic with variable names, data types etc as the people who wrote it are brand new to the company. I then realise I had just reviewed the companies lead developers PR to a different repo. Every time someone comments on a PR on this repo all developers in the company get an email notification. I sat there litrually sweating, bright red with the words 'oh ****' on an infinite loop in my head, staring at the screen waiting to see what was to happen.
Thankfully he was ok with the comments. But now people keep calling me the lead developer (teasing) fml I hate anxiaty2 -
My coworker told me today that since my birthday was this week I could take Monday off. I was so stoked before I realized Monday is Memorial Day.
Considering the shit I pull on this coworker and the future shit I will pull on him. I have to say it was fair enough.9 -
It's 35 degrees. Reviewing pull requests or finding a beer garden was the easiest decision of my career.8
-
Time to do a little bit of shaming:
I'm specialized in e-commerce applications, mostly based on Shopware, a german out-of-the-box online-shop. They essentially claim to be a better Magento. In December of last year I found a critical issue within the code. Products within the shop can be declared as digital wares. In that case the purchase of a product will unlock the possibility to download a designated file.
As a customer you can access your downloads within the account section. Now here's the problem: The query that fetches the unlocked downloads for a customer is hard-capped at 500 rows. So after your 500th purchase, you won't be able to access any further files you paid for. Essentially their developers thought that this limit would never be exceeded anyway and called it a day.
Personally I think this unacceptable. For the merchant this is a potential law-suit in the making. So I took the time to refactor the code and fix the issue. The corresponding pull-request was flagged as scheduled back in December. Since then there have been numerous releases and the issue is still present. Not only do I ask myself why I should ever put in time and effort to fix their code again, but I also can't believe that they just chose to ignore the issue completely. Also mind that this is not just a small or non-profit open-source project. The responsible company behind the software is a stock corporation that claims to be the market leader in Germany.
5 -
Gonna make a pull request for Project!
"How to Project:
npm install
npm test
npm run start"
npm install: warning, warning, deprecation, warning
npm test: 30 tests, 15 failed
npm run start: error, C stack trace
Pull request status: on hold3 -
When programmers troll. The comments of this commit is also legendary: https://github.com/torvalds/linux/...
4 -
Had a five hour long debate with one of our Senior Developers today about pull request etiquette.
His view was reviewers should always email or call him before adding comments to any of his requests and they should never block them as he should be allowed to code in "his own style" and should be able to approve his own pull requests.
I explained that we have code standards and an agreed PR workflow be needs to comply with.
He then started talking about meteors and plane crashes. Literally no helping some people.18 -
So, I got a ticket to make a page using a given wireframe that had submit buttons and other buttons to add more items in the wireframe.
So, I pull the html, hook up the abilty to submit the form and add items, and send it out for review.
One comment on the review.
"Remove the functionality, you'll handle it in the next ticket"
So I commented out the javascript. Guess what I'm doing on the next 10 minutes.1 -
WOOO THE NEW YEAR IS GOING SO WELL!
I just published my first pull request to someone else’s repository WOOOO5 -
I was asked to fix a critical issue which had high visibility among the higher ups and were blocking QA from testing.
My dev lead (who was more like a dev manager) was having one of his insecure moments of “I need to get credit for helping fix this”, probably because he steals the oxygen from those who actually deserve to be alive and he knows he should be fired, slowly...over a BBQ.
For the next few days, I was bombarded with requests for status updates. Idea after idea of what I could do to fix the issue was hurled at me when all I needed was time to make the fix.
Dev Lead: “Dev X says he knows what the problem is and it’s a simple code fix and should be quick.” (Dev X is in the room as well)
Me: “Tell me, have you actually looked into the issue? Then you know that there are several race conditions causing this issue and the error only manifests itself during a Jenkins build and not locally. In order to know if you’ve fixed it, you have to run the Jenkins job each time which is a lengthy process.”
Dev X: “I don’t know how to access Jenkins.”
And so it continued. Just so you know, I’ve worked at controlling my anger over the years, usually triggered by asinine comments and decisions. I trained for many years with Buddhist monks atop remote mountain ranges, meditated for days under waterfalls, contemplated life in solitude as I crossed the desert, and spent many phone calls talking to Microsoft enterprise support while smiling.
But the next day, I lost my shit.
I had been working out quite a bit too so I could have probably flipped around ten large tables before I got tired. And I’m talking long tables you’d need two people to move.
For context, unresolved comments in our pull request process block the ability to merge. My code was ready and I had two other devs review and approve my code already, but my dev lead, who has never seen the code base, gave up trying to learn how to build the app, and hasn’t coded in years, decided to comment on my pull request that upper management has been waiting on and that he himself has been hounding me about.
Two stood out to me. I read them slowly.
“I think you should name this unit test better” (That unit test existed before my PR)
“This function was deleted and moved to this other file, just so people know”
A devil greeted me when I entered hell. He was quite understanding. It turns out he was also a dev.3 -
Git: Before you pull you need to commit your changes
*Doesn't even run a git diff to see what changes git was talking about.*
git checkout .
git clean -i
git pull2 -
Pull-to-refresh is useless.
If you are a mobile app developer, please get rid of pull-to-refresh. Your users will thank you.
I have the impression that mobile app developers choose to implement the pull-to-refresh gimmick just in order to make their app comply with a design trend. It seems like a desperate attempt to appear "modern" and "fancy", not because of the actual usefulness of the gesture.
Pull-to-refresh is one of those things that are well-intended but backfire. It appears helpful on first sight, but turns out to be a burden.
It takes effort and cognitive strain to avoid triggering a pull-to-refresh. The user can't use the app relaxed but has to walk on eggshells.
Every unwanted refresh wastes battery power, mobile data (if it is an Internet-connected app), and can lead to the loss of form data.
To avoid pull-to-refresh, the user has to resort to finger gymnastics like a shorter swipe for scrolling up or swiping slightly up before down. Pull-to-refresh could even be triggered while pinch-zooming in or out near the top of a page, if the touchscreen does not recognize one of the two fingers.
Pull-to-refresh also interferes with the double-tap-swipe zoom gesture. If one of the two taps are not recognized, a swipe-down to zoom in can trigger a pull-to-refresh instead.
To argue "if you don't like pull-to-refresh, just don't use it" is like blaming a person who stepped on a mine, since the person moved and the mine was stationary.
A refresh button can be half a second away in the menu bar, URL bar, or a submenu, where it is unlikely to be pressed accidentally. There is no need for a gesture that does more harm than good.
Using a mobile app with pull-to-refresh feels like having Windows StickyKeys forcibly enabled at all times. The refresh circle animation sticks to the finger.
If the user actually wants to refresh, pull-to-refresh is slower than a refresh button in a menu if the page is not at the top, meaning pull-to-refresh is useless as a shortcut anyway if the page is in any other position than the top.
An alternative to pull-to-refresh is pull-for-details. Samsung did it in some of their apps. Pulling down against the top reveals additional information such as the count and total size of selected items.
If you own a website, add this CSS to make browsing your website on the pre-installed Android web browser not a headache:
html,body { overscroll-behavior: none; }
Why is this necessary? In 2019, Google took the ability to deactivate the pull-to-refresh gesture on their Chrome browser for Android OS away from users. On Chrome for Android, pull-to-refresh can only be disabled on the server side, not the user side. The avalanche of complaints? Neglected.
Good thing several third-party browsers let the user turn off this severe headache.
12 -
Submitting a pull request seems a good way to end the week. That's what I love about (some) projects on GitHub; instead of just ranting about bugs or out-of-sync documentation, you can fix the problem and send a pull request upstream. :-)2
-
Me: Is git male or female?
Friend: male.
Me: why?
Friend: it does all the pushing and pulling!
Me: Really? I think we push and pull into git.3 -
All bugs in Linux kernel removed . for more info check pull request at https://github.com/torvalds/linux/...
3 -
taylor "cunt" otwell, too busy selling and shilling laravel addons to maintain the existing shit.
"0 issues"
https://github.com/laravel/...
https://github.com/laravel/...
https://github.com/laravel/...
13 -
When u finished 80018939018282983 pull requests on a single day hoping to get extra stickers for Hacktoberfest..3
-
Getting called just to ask if i have made the pull request. You could've just text me for fuck sake.1
-
Code review, intern style:
Intern: Here is my pull request ...
Colleague: I see a problem with x, y, z. Could cause memory leaks.
Intern: Oh yeah you are correct, i'll fix that in the next one.
Intern: *merged* -
"Pull the lever cronk
...
WROOOOOOOONNNNNGGGGG LEVVVVVVEEEERRRRRRRR"
*some time later*
"Why do we even have that lever"
^^^ my code be like -
When it comes to nervewrecking situations, what I've encountered so far is a pull request for which the 2 reviewers had opposite opinions.
Something like this:
* opens pull request *
reviewer 1: "update using approach A"
* updates code *
reviewer 2: "this is wrong, change to approach B"
* updates code again *
reviewer 1: "this isn't what i asked for, i'm rejecting your PR"
Oh, also, each of them had their own set of coding standards.
What was your most challenging situation when writing code?1 -
Trying to resolve merge conflicts and you cant remember which changes are the ones you want to keep. Lesson learned, make sure your pull requests dont sit waiting for weeks while master is happily being worked on.2
-
I completed my 4 pull requests for hacktoberfest and guess what all of them got approved. Yayyy!!
So these are the issues which I fixed in hacktoberfest2019.
1. Fixed readme of imba
2. Fixed the script of devTea
3. Added screenshots for the same (2)
4. Helped a friend with a blockchain script.
Thanks a lot!! @devTea, for giving me the chance.
5 -
My life has been pretty rough this week regarding personal life context, but at least my pull requests are being approved and having good comments, which is nice.1
-
PR used to mean public relations to me few months back. Now it just means pull requests to me.
The fuck happened. Anyone says we need to improve our PR, I'm like how do you improve a pull request and I end up face palming -
That moment when you feel that you are a great developer ready to do some pull requests to the framework you are using and then you check the source code of it and wonder if that's even the same language.
-
I'm doomed.
My first production worker script is making multiple active attribute of a user. My script should be able to deactive the old attributes if there is new one.
Months ago, this issue occured. My teammate from team A take over the script to investigate since I am busy working with team B.
Yesterday, I found out that I, myself, overwrite the fix my teammate made for that because of a new feature.
I have to clean up the affected records on production on Monday..and i have to explain to my manager. T.T
LPT: ALWAYS PULL REPO before developing new feature... -
Contributing on github projects.
Especially when my pull-requests finally merged to the original master ^^ -
TEAM MATE: let me sync my branch with upstream master
*starts typing*
git pull upstream master
ME: Nooooooo!!!!5 -
I got an interesting idea, but i hit a wall. Basically i have location info, and i want to pull pictures of buildings nearby. For example, say im standing in Ny, Whatever street 420, and the trump tower is nearby, so i wanna pull a picture of that. Does anyone have experience with something similar? Or can i pull images from google street view?4
-
When someone actually commented on my pull request, rather than just clicking approve without reading it.
-
when github autocorrects my pull request message that contains the word splunk.
(or when devrant also decides to) -
I think what's worse than bad coding is bad network connection. Can't load StackOverflow, Network Assets, Run Reports, or pull updated repositories because somebody is hogging up the bandwidth. FFFFFFFFFFFFUUUUUUUUUUU
-
That feeling when you've been on holidays for 15 days and the `$git pull origin master` take hours...3
-
Remember this : https://devrant.com/rants/1547095/... ?
FINALLY some updates.
Just to say they deleted the branch I was trying to merge on during the month, so I need to redo the pull request and rebase.
(ﾉ｀□´)ﾉ⌒┻━┻5 -
`alias pull="find . -name .git -print -execdir git pull \;"`
A while ago, I found someone asking about personal favorite aliases. I cannot find it now.
I am not a huge terminal user so I don't really care about keeping aliases until now.
It became annoying to `git pull` before doing anything when you are using two different machines regularly and there are always about a dozen active repos.2 -
Just submitted my first ever pull request on GitHub. Here I am frantically waiting for it to get rejected or take my first step towards the Hacktoberfest shirt 😁1
-
I shall delay your PR with my giant egotistical scrotum by:
- Use less words for your function name
- Use this obscure pattern you have not learnt in your outdated compsci degree
- Each loop should get their own function
- Your function has too many parameters
- You must name every instance of magic numbers / strings
- Here, have another obscure test case to write9 -
When Monday comes round and all you can think about traveling to work is the giant pull request you were asked to review on Friday 🙈
-
Oh you have a pull request that fixes a bug impacting customers atm? This is a perfect opportunity to write a novel that debates optimal coding practices in the review
Smiling eye twitch3 -
So I made a pull request on a PHP public repo fixing line lengths and adding some spacing for readability. All in the hopes of improving it to follow PSR-2 standards which they specifically say they follow.
Pull request got rejected, reason: "No thanks, the code is good enough."
Lol! 😐Time to move on to others who appreciate help. -
When you keep on refreshing the tab to see if your pull request got merged but it still says
”Pull requests 1”
3 -
Indian developers were committing hundreds of garbage pull requests to get a free Hacktoberfest t-shirt.
Meanwhile repository admins:
2 -
Love it when the maintainer of an open source project you contribute to runs a linter over the whole codebase and force pushes the changes to origin master so now all the Pull Requests in the queue have to be rewritten and have tons of merge conflicts to resolve. Awesome! 😠2
-
guess who is working on a 10+ GB hg repository using sourcetree on a macbook air
hint: I DO
pull, update lasts so long, there are new changesets to pull (hours, i kid you not)2 -
So to keep me going through the day I sometimes entertain myself by adding funny comments to my pull requests. I sit there giggling to myself like some sort of lunatic and the rest of the office probably think I'm a nutcase.
Todays gem was:
Added timeout to prevent hanging. Bet they wish they'd had this feature in the 16th century
Honestly I think my talents are wasted here...1 -
Does anyone here create pull requests when working on projects alone? I am wondering how effective this is in practice.3
-
> push code on staging and promote on production works fine
>.come home
> pull from master and code doesn't work locally
> pull from the feature branch, same issue
> fml
I'd be so fucking disappointed in myself if I hadn't pushed it and merged it. -
Something I hate about working in the team is that the code reviewer will stall the time and leave a lot of pull requests unreviewed. As more code changes more commits and more pull requests.
The code base is conflicting with each other, what the fuck? I hate this.5 -
Want to pull pranks on your friends or just confuse the craps out of people?
Www.github.com/DeveloperACE/MetricTime -
Pull requests with 900 changes across 27 files and not a single comment. But Ruby is self-explanatory!1
-
So we 3 devs working on a real estate system.... The guy who initially wrote the system wrote it in a fucked up state
Project structure was shit so we had a meeting and I suggested we restructure the project and also have some minimal documentation coz the system is growing we adding more features before current ones are finished
We agreed and started polishing up the system coz it seemed more features we wanted were now becoming more and more difficult to implement
So the other guy tells me to pull some updates.... To my surprise he had started documenting the system without restructuring first.... Had to quickly restructure the thing and push updates
How can 1 start documenting the very same design we want to abandon 🤦 -
Yeeehaw,
i finally get rid off that over-the-top dependency on Zend\Config in upwork/phystrix
The Pull-Request is on it's way:
https://github.com/upwork/phystrix/...
After 4 years of "this will take minutes to refactor" and "yeah. I totally agree. Replace Zend\Config with Array Interfaces", someone (in this case me) took finally care of this easy to solve issue :)
I hope it will be merged soon into the master branch -
I wonder if anyone ( especially a highly experienced engineer ) can tell me what kind of pull requests are rude or inappropriate to do.
I saw some newbie do small fixes in docs or readme folies or some just add unnecessary lines of codes and then do a PR.
I don't know whether these are rude ones or I am thinking about it the wrong way ...
I've also attached an example ...
5 -
Dude i asked you to review my pull request because i thought we were cool. The code change is about a simple rename, SO FUCK OFF WITH THE REFACTOR SUGGESTIONS. STOP DOING THAT TO MY CODE REVIEWS
2 -
pull request that made my day - a colleague of mine wants to make the open world subject to some master. of course I rejected this attempt ;)
4 -
...Firefox I feel like you just stabbed me in the back.
Version 49.0.1 I pull out Internet on Mac, navigator.onLine returns false. I pull out Internet on PC (windows 8) same version navigator.onLine returns true even though work offline mode is off. -
My team is split on reviewing pull requests individually vs as a group.
Personally, I don't like being interrupted to come look at a projector for 20 minutes only to go back to work for an hour, and then get pulled into yet another review. Am I the only one that thinks this is incredibly inefficient?
I prefer to go over pull requests on my own time, asking questions/making comments as needed.2 -
REBASE BEFORE CREATING A PULL REQUEST
Especially if you've had to pull from main 7 times. No one has pulled from your branch, you have no excuse!7 -
Writing my first code review. Even though it really is a nice review and I'm happy with the solution code, I still somehow feel like an asshole for each critique I make. Maybe it's unavoidable with code reviews / pull requests?3
-
*click 'create pull request'*
*satisfied*
*pat on shoulder*
Will get comments surely, but I'm happy that I could make a PR -
Pull an all nighter and Fuck up my exercise schedule or have sleep and code tomorrow (imp and might take multiple nights and day).....
Such hard decisions, 50 pull ups is hard to do after an all nighter 😥1 -
Draft Pull Requests : With draft pull requests, you can clearly tag when you’re coding a work in progress. Next to the “Create pull request” button. Toggle the dropdown arrow whenever you want to create a draft instead.1
-
When it's holiday season and your teammates are on leave, so you have to open a pull request and approve it on your own.
-
I made it as dev when the repository owner increases stale time for pull requests to wait just a bit longer for my change
-
First pull request to an open source project :D
Well, a small project, without contribution guidelines. -
New guy likes to both approve and merge other people's pull requests have he approves them. Please don't merge other people's pull/merge requests. Other team members may have comments too! The person who created it should merge it.1
-
I'm about to create a pull request for adding devRant as one of the default services in Rambox. Anybody dig it?1
-
They should merge my pr first, so the one who will resolve the conflict is not me. I spent 3 days and nights cleaning 60 files in the projects. 60 files! Sadly, my manager merged other pr with 2 files changes from my junior first, destroying many of my changes.5
-
This team mate of mine always finds a way to escape my suggestions in his pull requests.
Today he told me that what I'm asking him is just my personal preference and that it's not a thing just because our formatter isn't powerful enough to do it automatically.3 -
I submitted my first pull request 2 days ago and guess what maintainer closed the issue without accepting and merging my request even 1 day ago I have commented on the issue comment box that I have a pull request please accept.
Not feeling good, I was thinking the hardest task is to find an issue we can contribute to, but the hardest task is, which we can't have control in and that is merging the pull request. -
People that approve pull requests without looking at them!
No tests or so bad they would do more use by not existing, typos, the code follows none of the design practices and the code obviously will not compile and thereby breaks builds in trunk for everyone.
Because of course they only asked one person to review it and then merged it immediately. -
When you are tearing you hair out trying to figure out why the PR you're reviewing isn't working. Then you realize you forgot to pull the latest changes!
-
The cringeworthy moment when you approve a pull request and a teammate starts suggesting a ton of changes :/1
-
Well this morning has been fun with Github's pull requests and issues not working.
status.github.com -
Your branch and 'origin/foo/bar' have diverged,
and have 2 and 1 different commits each, respectively.
(use "git pull" to merge the remote branch into yours)
git pull
hint: You have divergent branches and need to specify how to reconcile them.
git merge origin foo/bar
Already up to date.5 -
Finish the story and all tests pass
*notification another merge request been approved
Pull changes build, all tests faill
-
Is there a way to create pull request on git using CLI? I have tried request-pull option but quiet lost over there.9
-
If I use a connector to pull files from an SFTP server and when I configure it to pull all files from the root folder after it logs in but it actually pulls from the machine's root directory, is that really an SFTP server or just a server? Is that even secure?4
-
Fellow developer likes to request changes on pull requests to do major refactors on untouched code or change functionality which is outside the scope of the ticket.
Manager doesn't work on the codebase and doesn't care. This blocks our work and we often have to submit to their demands.
Feels very micromanagy even tho we are all experienced.
Asking for advice and a friend. (mostly a friend)4 -
Pull >>>> Rebase
The advantages of rebase (clean git history) are minimal but the risks are massive (rebasing in the wrong direction, rebasing after raising a PR, rebasing a public branch)4 -
Legend has it that auto-complete pull requests only ever actually autocomplete while you're watching them1
-
Weird git when i pull it does not conflict or anything just merge it with smiling face, then when i checked my repo, my work is gone. Whats wrong with this, anyone encountered this?
-
What to do if the repository maintainer taking a lot of time for accepting pull request of hacktoberfest?5
-
Completely noob question and before you say it, yes I have googled but I'm tired and I just get walls of text.
How do I merge a pull request?
A nice guy has submitted a pull request to my repository on GitHub, how can I merge it??
I tried what I thought was merging but it said that a file is conflicting. I tried deleting the file and it still didn't merge.
4
Top Tags
Weekly Rant
View