Backend Dev here and this is a true story

Would you merge this shit into your project?

Team member just requested a code review in French (s'il vous plaît)

Yea, I'm not reviewing your code you pretentious prick

Before we started a new project, as a team, we set some ground rules like: frequent, small, digestible PRs.

PR#1: 52 files (week 1)
PR#2: 107 files (week 2)

JUST FUCK OFF MATE!!!

New developers(5-6 years experience) these days are so pathetic. They dont have any sense of code review. All they want is to put their opinion out without giving any thought.

I had a PR for review today which contains mock specification to match a regular expression and return the corresponding response

The regular expression I put was

104000(02|06|20|48)

Now, this guy comes and puts a comment that we could "simplify" as 104000\d{2}

I replied, the ending digits are not contiguous. The specific pair of digits have to match for these mocks.

Then this guy replied, then we could simplify as 104(0{4}(2|6)l0{3}(20|48)).

I said, I cannot understand how that is simplification. Why do we need such a complex regex to match something very straight forward.

And the guy replied, we should be writing proper regexes, otherwise we could just specify everything explicitly.

I was like WTF man. You try deciphering this next week without taking at least a minute to know which values are matched.

Anyhow, another senior person approved my PR, and I merged it.

Overworked team spends 2 months hacking together a Codecademy clone in record time: avoiding best practices, conflating paradigms, throwing shit at the wall until it stuck.

But today I submit a small UI fix that used a table instead of `display: table`...

A co-worker on a gigantic PR i made:

"the worst thing about this pr is that while i was reviewing it, I forgot about my coffee and it turned cold. Otherwise good job!"

Don't update your pull requests half asleep, I repeat don't.

Now it's 2 AM, I am fully awake regretting my decisions.

> Opened PR on May 2nd
> No response
> Bumped them on August 3rd
> Closed without response 🎉
> Questioned them, no response yet..

When you finish writing your PR and just a minute or so later it's reviewed / merged!

Ｉｓ　ｔｈｉｓ　ｈｅａｖｅｎ？

To fix a bug I added a few log messages to trace what gets executed and in what order (very new to the project). Fixed the bug, pushed PR and the only comment was to remove the log files. 🤦‍♂️🤦‍♂️

Please tell me this is normal or should I start looking for a new place that hires "only the best" 😭

How the fuck am I supposed to fucking keep working if these fucking clowns add mandatory peer code review and passing build gating on main repositories (which I completely agree with to be fair) but they don't fucking review pull requests at all? For fuck's sake, am I the only one that reviews them seriously and promptly in this shit ass fuck company? I follow all the recommended guidelines so don't bullshit me with "iT iS nOt FuN tO rEvIeW pUlL rEqUeStS", do your job or just remove yourself from the fucking gating process, you worthless admin ass crust.

And don't get me started on fucking builds that fail randomly because some worthless shit bucket added unstable networking tests as unittests somehow, making your pull request get auto-disapproved by peers upon failure.

I got so many pending pull requests and management won't do fuck all about it because they won't force people to do their job by fear of pushing them around and get HR complaints that I am tempted to simply give up and just start playing videogames.

Draft Pull Requests : With draft pull requests, you can clearly tag when you’re coding a work in progress. Next to the “Create pull request” button. Toggle the dropdown arrow whenever you want to create a draft instead.

It was so close...

Has anyone had success with GitFlow hotfixes and GitHub branch protection rules? Finishing a hotfix requires pushing directly to develop, but GitHub prevents it if PR policies are set up :/