11

> Opened PR on May 2nd
> No response
> Bumped them on August 3rd
> Closed without response 🎉
> Questioned them, no response yet..

Comments
  • 5
    Life of a readme warrior
  • 3
    @electrineer Sounds like a great book title!
  • 2
    Did you create an issue before? Some maintainers ask for that to discuss in the first place if a PR would be appropriate
  • 2
    @devRancid we have a requirement that any commit message must start with the jira ticket, and that is enforced on push so it has to be a valid ticket.

    That way any code will be tracable to the reason it was created.

    Its a bit more work but it also makes it very visible that we work with the things we decided we should.

    And yes we do prioritize fixing technical debt, not only features ;)

    And we also have the general rule that its the creator that merges or closes a PR, reviewers only comment and either approve or deny, they must not close or merge unless agreed upon with the creator.
  • 2
    @devRancid There wasn't any requirement nor would that justify closing it without any commentary / ..

    It's not a giant repo that has a lot of activity anyways~
  • 0
    I mean if it passed through QA, no worries much
Add Comment