Just me, explaining how my code works.

Wasn't there myself. Came back after weekend or being sick or something and after the daily stand-up one of the guys came to me:
"hey man not to be rude or anything but we're not going to use your code for the project. You're programming in a wrong way."

They explained me where I was going wrong and then it appeared that my study taught me some principles of PHP programming wrong.

I felt like shit, downish and had to fight the tears because I felt quite humiliated.

Looking back at it, they were completely right.

I was suppose to review this code.

if (null != value) {
return value;
} else {
return null;
}

- "I disabled unit test to make this work..."
- *Force choke*

Reviewed the code of one of my employees and found that comment: Todo: Improve this if thomas complains.

"I didn't understand what you did, so I deleted it all and started over"

What's code review?
*programming in production*

What code review?

Wrote 800-1200 LOC
It went through code review which was apparently my first code being reviewed
Took me 1 month and more to fix most changes (per day more than 10-12 hrs of effort)..
That 1 month was a nightmare. Every day I thought of giving up programming. I shouted to myself every night why did I never considered these myself. How can I be so dumb.
Half of the reviews I didn't even know how to implement. Didn't even know what to Google.
I consider it as one of my toughest phase as a developer till date.
I still get goosebumps remembering those days.

New guy at work asks me for a code review. 16 lines added, and I have 4 comments, all about readability. Only the major stuff because I went easy on him. I even ignored a missing semicolon.

Guy comes to me and explains that code review is about if code works, not what it should look like. "You want me to write it your way, and we'll have endless arguments if that's how you do code reviews. But I'll do your requested changes." Reduces his entire code to two lines, which make a lot more sense.

Later, I ask him why he used "void 0" anyway. I was wondering if he's thinking of security aspects or if there's another reason. His answer: "because it looks cool and nobody else does it".

I've never had a code review.
Eventhough I proposed to my boss that we at least review our intern's code once a week, he doesn't think it is needed.
Our intern writes ugly, shitty code...
it usually takes hours for me to fix his abominations... but yeah, what the boss says is always the best.

Last year I signed in for a course called "Best Practices in Programming", and part of the course was to get the code of our current projects reviewed by a professional developer. I had a horribly written (out of inexperience) code in Python. The guy who had to review my code basically said I had no idea about coding but went on helping me a lot. Since then I started to learn some concepts of software engineering, how to code more efficiently, and so on and I've been much better ever since. So kudos to him for putting up with my spaghetti code and sending me in the right direction!

It was 1999. I was just starting my first real job as a programmer for a major insurance company. We were working on code that would screen scrape legacy mainframe data output and convert it to a web-based UI. REALLY stupid project approach I had no input on. I happened to find a programmer in Germany who had released his code in the public domain that would help with making a certain conversion task easier. I downloaded his code and put it to work.

During a code review, a programmer who was probably about 60 asked me where I got the code and what it was doing. I didn't even get to the part about what it was doing because he made fun of me so badly, in a fake German accent in front of a room full of non-programmers, for using code that today is no big deal due to the prevalence of open source. I just clammed up in humiliation because he got everyone laughing at me. His philosophy was if we didn't buy it or write it ourselves, we had no business using it.

I guess I was just ahead of my time?

Porting of a huge web application from ZF1 to Laravel 5.5.

In summary:
1. approx. 200,000 lines of spaghetti code (ZF1)
2. approx. 2500 custom Javascript files
3. approx. 600 CSS files
4. hundreds of node modules and libraries
5. 12 different layouts (Home, Member, Admin,...)
6. ...
7. ...
8. ...
...

I've got six days to get this done. God help me.

I was assigned a ticket which was about a drop down menu which was not aligning properly.

Turns out the drop-down was positioned absolutely and my co-worker (read bestie) had written media query for every 10 pixels to match the position for mobile and desktop devices (from 320px to 1040px and beyond ~150 lines for a drop-down). No one noticed any flaw for few weeks until one of the QA had to check the site in landscape mode on mobile device.

I replaced it with 4 lines of JavaScript.

"Code reviews don't really offer any benefit to the business."

"And how are you?" I said.

Eeyore shook his head from side to side.

"Not very how," he said. "I don't seem to have felt at all how for a long time."

"Dear, dear," said Pooh, "I'm sorry about that. Let's have a look at your code..."

And then Eeyore looked at Pooh with terror in his face, before he vanish into the forest.

He never let me review his code again...

When the client writes a 100 page novel about his problems, but never sends the ACTUAL CODE to review.

Reviewer1 asked me to change something in my code. Reviewer2 asked me to revert the changes I made for Reviewer1. I hate this industry </3

So here is my week 72 as a reviewer. But first, let me ask y'all. Am I weird to think that you should finish coding the thing and testing the thing before kicking it out to review? Cuz that's how I do it. And that is the process at my work place.

So anyway, I was doing this review. And it was very wrong. Like really, really wrong. We give a thorough intro to our product (perhaps too thorough) so this guy should have known every test case he had to cover. Or at least, if he was unsure, asked. It was all documented.

Anyway, he kicks out this peer review. First thing I notice, it is not following the standard. Fair enough, we didn't give him the coding standard. BUT HE DIDN'T EVEN MAINTAIN THE FORMAT OF THE ORIGINAL FILE. HE JUST DID HIS OWN THING!!! So I email him the coding standard and make a comment in the review. He denies the finding. No reason. Just turns it down. Strike 1.

Then, I'm going through and he didn't even cover all of the core cases. I found several core cases that he missed. And every edge case. Make a not of it. He fixes only the couple of examples I gave him. Strike 2.

Guy decided to redesign a major chunk of our interfaces. Our interfaces are not just used by us (hence interfaces). We designed them the way they were for a reason. It was not a fun design process. Myself, the architect, one of our customers, and the guy that did the implementation all told him to roll back his change. Especially since it wasn't in the scope of what he was doing. He wouldn't. Strike 3.

I go to the lead and bring him in. He has a talk with him. All of the sudden he is putting out multiple builds per finding. Like most times I will put out like 2 to 4 for the whole peer review. No he kicks out minimum one per finding and chokes the review queue. Strike 4.

Strike 5: he tells me, a former DBA, that I didn't know what I was talking about when I told him to move something into a new table, even after I told him that "while in database terms it doesn't make sense, this is for product robustness".

Strike 6: he was just a condescending asshole. Bragging about how he did this job and that job over his career. His longest position held was about 18 months. Bragged about working at my company and being some hotshot at the company: only worked here for 8 months and that was 5 years ago.

You know. I have never really wanted to fight someone after about undergrad. But he came close.

Well must say Python is really a great language.

Where somebody says code review..

If I disregard all Wordpress code examples, this must have been one of the best examples of bad code. It took minutes to understand what it does.

The guy was a complete asshole. He criticized every line of code i did and said he could find someone else who could do it better for less.

It also doesn't help the fact that i worked alone in that project.

This one time at an internship I was getting flamed for not 'coding' valid html5 (me being a backend dude) after some painful hours it was html5 valid... Only to then get flamed on for the text being one pixel off or something... I mean if you want a front end intern then don't look and hire a backend

I once reviewed some code that parsed HTML using regex (red flag #1), and it turns out that it had to be done that way because the company's HTML was so malformed that no actual parser would accept it without erroring

Saw this in a previous developer's code which is currently in production.

public bool reset;
public bool Reset
{
get{ return reset; }
}

This was done for most if not all the properties.

I'm so glad I had none yet.

I would probably get killed for my shitcode.

When you emphatically explain the code you've been working on non-stop for the past week, only to have the boss hit you with that "but what's the point?"

And your heart fucking breaks

*senior dev comes over to my desk*
"Your code is so wrong I didn't even bother to comment on the review." He proceeds to lecture me about why the code that I modified (a 2 year old file I included a tiny helper module in) needs to be rewritten.

A pull request with 6000 lines changed, with mixed fixes and new random uncorrelated features.

I once got criticised for adding doxygen to function declarations.

I shit you not.

int someFunc()
{
int result = -1;
// imagine all the fucking ifs in the world...
{
{
{
{
{
{
{
{
{
}
}
}
}
}
}
}
}
}
return result;
}

The reviewer wants better and more syntax sugar than actually implementing better logic.

Not the code review itself, but having repeatedly to nag my project leader just to get a review is the worst.

I'm "only" a student and it's a project without fix deadlines so it's alright with me that it is low priority.
But - I want to learn something here, I really do, I'm new to C# and far from mastery. Apart from that my focus was mainly hardware during the last years.
I need some fucking brutal and honest criticism on my code, damnit!
That's all.

Worst code review had to be when a senior architect told me that my new library was good, but should be a bunch of files that we copy paste from project to project instead.

His comments were just so out of touch with a) what we were trying to fix with the team. b) basic understanding of good modularized code.

I’m far from a stuck up dev. Not stupid enough to think I’m better than everyone, or have nothing to learn from anyone.

But I totally had a “my boss is a ****ing retard” moment. It was hard to listen to him after this as it was hanging over my head “was I wrong? Or is this just no-library man striking again?”

At the moment I'm working on a project where every line of code is actually garbage. However, the client insists on continuing to use ZF1.

Zend_Locale is a mess. I've been sitting on it for five hours and nothing's working.

My worst code review involves line endings. In one of our products we use the facade pattern, and one of the facades is about 5000 loc.

Well, a dude in our team messed up with line endings, so our diff tool showed that 5000 lines have changed. A newb I was at that time, I didn't know any other diff tool, so I went through all the lines manually only to see that 2 lines effectively have changed.. and the newb I was, didn't thought about rejecting the change immediately! We then had somehow to revert that commit, but messed up our central repo (was still with CVS). In the end we had to restore the daily backup for the repo because we couldn't manage it to do it right.

Never ever had such a disastrous code review again.

This is very long along. Senior Developer was doing my code and telling the best way to write jQuery and PHP codes.

The funny part is that he doesn't know anything about PHP and whatever jQuery code he told me to correct was very shitty and difficult to maintain.

That's when I knew. This world is fucked up!

Not sure if it's the worst code review but it's a recent one.

We don't really do code reviews where I work unfortunately but my coworker used my framework for the first time (build some nice composer libraries for cmdline projects) and asked if I could make them do autoloading.
He never used namespaces before so I was glad to help him out.

What I saw was a dreadful mess. His project was called "scripts" so good luck picking a namespace...

Than it was all lose functions in the executable file. All those functions are however called by a class in another file (if they where not calling eachother as a cascading mess). That class was extending an abstract class from my library as instructed. However I never imagined my lib being raped like that.

The functions themselves are a horrible mess. Nothing uniform completely different style (our documentation states PSR's should be used).
Parameters counts higher than 5.
Variable names like Object and Dobject (in calling function Dobject is Object but it needs a fresh one.

If statements on parameters that need basically split it in two (should simply be to functions)
If else statement with return of same variable as a single line (sane people use ternary for that)

Note that I said functions. All of it should have been OO and methods. Would have saved at least some of the parameter hell.

I could go on and on. Do I think the programmer is bad yes (does not even grasp interfaces, dep injection, foreach loops). Is this his best work no. He said that for a one of script like this it just has to work. Not going to be used elsewhere. I disagree as it is a few thousand lines of code that others have to read too.

Around 6 years ago I started at this company. I was really excited, I read all their docs then I started coding. At every code review, I noticed something was a little off. I seemed to get lots of weird nitpicking about code styling. It was strange, I was using a linter, I read their rules but basically every review was filled with random comments. About 3 months in I noticed, "oh! there aren't actually any rules, people are debating them in my code reviews!" A few more reviews went by and then I commented, "ya I'm not doing any of this, code review isn't a place to have philosophical debates." All hell broke loose! I got a few pissed off developers, and I said, listen I don't care what the rules are, you just need to clearly fucking articulate them and if you want to introduce one, I don't care about that either just don't do it in the middle of my review. I pissed off 1 dev real bad. Me and this dev were working together, the QA person on the team stood up and said "hey! you know what I love about your code reviews?!" The other dev and myself looked at each other kind of nervously, "I love that you're both right, these are all problems!"... 1 year later (and until now) me and the other dev are still friends. Leave it to QA to properly identify the bug.

Some cheapskate insists on writing a guide to selfhost <software> on Heroku and wants to add it to the official documentation, promising to maintain it (since none of the other devs are using or planning to use Heroku). I volunteer to give them a chance on grounds of it being high quality and maintained by that person in the future which they both promise.
Our docs are written as markdown files on github.

So here we go:
Starts a pull request: uploads their """guide""" as a docx. The content is completely unformatted, basically just an enumerated list.

Tell them to format it as markdown, suggest using github gists.
They go ahead and copy pasta their unformatted list into a gist.txt "allright i made it into gist for ya"

Tell them that they did not format it as markdown.
"sorry updated it in markdown :P"

I look at the file, it is still raw text in a gist.txt. Maybe a bit more spaced out, not that I would care to notice any changes at this point.

Tell them it is still not markdown and link them to a perfect example of another guide that takes advantage of code fragments for commands etc and is properly rendered since it uses .md

"I updated it to the markdown this time XP Can you give me some suggestions on how it looks?"

"How it looks"... "how it LOOKS"... I click the link for the 5th time and IT IS STILL JUST A RAW FUCKING GIST.

Jfc that person has some serious reading/thinking disability. To imagine them to be proactively keeping their guide up to date in the future is absolutely impossible. At that point I pulled out my support for the request since it was already taking more effort to even get a readable version of guide than I estimated for the whole process of adding it.

Oh, and one of the steps originally suggested in the """guide""" was adding the credentials file into the vcs.

when CodeClimate reports it 2.0 GPA but your colleagues says it's good code-wise and styling wise...

turns out I didn't have the YAML override

Some of the worst code reviews I had were at my 1st proper workplace which incidentally was the strictest one! I was such a lazy oaf and hated those.

Still don't like code reviews but I do admit those first ones did me a tom of good.

Nowadays when I am the one co ducting them I tend to be more relaxed and chill and not be a nazi coz I still remember the repulsion of my first ones ^^'

Code reviewer tried as hard as possible to find issues in my commits.

After timereportimg 3 hours extra in a small ticket, he concluded we needed to try a different approach, even if code was OK? Why?

Simply because it was his idea and his idea is better. The reviewer needs to feel his superiority by any means.

Ticket waiting for code review for days. I have to rename methods.

Tickets goes again to code review. Waiting there again for days. Oops! there is something the code reviewer didn't see before!

Ticket goes to code review again, waiting for days there.

Boss comes to me telling it takes me too long to close tickets.

When it takes way to long to upload files to a server to show off you

Well, I am not sure whether this is supposed to be about worst experience as a reviewER or a reviewEE so I'ma do both. First as a reviewer.

So, on my first project in this company, I introduced automated build scripting (read: suggested, was "volunteered" to do it, then had to bust my ads to get it done). Prior to this, our process was run the thing in Visual Studio a bunch of times (don't ask) and package the resulting files. Well, new requirements made this not sustainable.

So after many many meetings in which I assured my co-workers that the script wouldn't cock up and go sideways and format our server (HOW???) and showed them how to work it AND added all the features they requested. I finally send the script out for code review. Oh the joy. Questions like: "why did you implement this?" Came from the guy who told me to implement it. "Can you change the formatting?" I checked and no. "Why isn't this to the code standard?" Because the code standard doesn't include scripting languages.

And here is the piece that takes the whole piss soaked shitsicle pie "I don't understand why we're doing this in the first place. We have a build process already, why do we need a new one?" FUCKING REALLY?!?!? YOU WERE IN THE GODS DAMNED MEETING WHERE WE DECIDED TO DO THIS!!! SET OUT THE REQUIREMENTS!!! LITERALLY EVERYTHING TO DO WITH THIS SCRIPT YOU WERE THERE AND YOU'RE ASKING WHY WE'RE DOING IT NOW!?!?! Fucking hell. I forced it through anyway because I had the higher ups all signed off on it, but seriously. Just because we're doing something new that slightly inconveniences you, doesn't mean it doesn't need to be done. Stop being afraid of change.

Side note: these people actually would regularly hold up process and product improvement because change is scary.

Never once had I have the worst code review. Simply because I never had one.

One time I had to review some SAP / Excel / Visual Basic toolchain.

It was a huge mess with like 10 layers of if-then cases in around 1000 lines of code analyzing excel sheets, resolving error codes etc. in maybe two functions.

It turned out that I programmed that code about 8 years ago :/

Haven't had one..... Yet. 😨😐

The first one

Delete completely a project and start from zero.

Someone at work asks boss something stupid. He gets mad and says "omg don't they teach you anything at school?" and proceeds to give us all a pop quiz... On paper... Then tries to read all the code pieces like a lecturer.

I was working under the title of mid-level developer when I felt I was clearly still a junior and was tasked with making changes to the core search functionality of the company website. After it was 'reviewed' by 3 people more senior than I and merged to production it took the majority of the site down.

I got the blame and the reviewers weren't even questioned 😒

code reviewed a "senior" developers code (guy has been at the companyny since noah and his clay computer tablets), he replied with my comments against it stating he has more experience than i have and that i shouldnt do anything except just sign off the stuff to production, stuff goes to production and breaks a massive financial cluster fuck of a mess, who gets the blame for releasing the code to production ? Junior me !!! gotta love it when management needs scapegoats of FIFO people.

code review schedule on weekend
we have no life
</fuckedup>

I work at a small company (less than 10 developers). We tried to do code review but all of our projects are "work for hire" for our clients and we always have deadlines. Code review step always had the least priority and whenever the deadline gets closer, we would stop doing code review all together.

Finally we are starting our own projects and we are planning on hiring more developers and interns. I think code review will have a higher priority now.

if (!$something){
if (!$something){
echo "Error";
}

Can someone review this code?

As long it runs that mean it good to go

Do a backup, override the project with an older project.

Going through the docs of the new tech...

Pseudo-code:
function edit(data){
// DB delete where data.id

// DB insert new data
}

just yesterday, commiting a pile'o'shit code which u know is pile'o'shit but you had to do it like that because correct non-hacky solution wouldn't meet non-negotiable, client-critical deadline, and getting back a code review criticising precisely all the points which you are aware of and want to kill yourself for but you had no other option under the circumstances.

p. s. still under probation because it's a new job, and the review ends "no time right now but we need to talk at the end of next week"

p. p. s. second best job i ever had. week of fear of losing it commences.

Not really a bad review, just that one change was to remove a log where the message was nonsense text I put just to figure if the code block is reached! I felt so unprofessional

The last 2 days trying to fix a code with 5 String arrays and static indexes that you have to guess.
The nightmare of ArrayIndexOutOfBoundsException.

Reviewing my own code next morning after heavy drinking.
Drinking and coding should be illegal!

Not having any code reviews

AND

Not even merge requests...

Shiiiiiiiiiiit.... where am I ?!

Thinking about upgrading a laptop, 4gb ram, i3, and an hdd. Should I upgrade the ram to 8b or the HDD to an SD? Mostly use it to web browsing, and occasional app development.

It was a weird day today, overall good. My web development books arrived by courier and I got started straight away with them, Thought I was reluctant at first to learn HTML all over again and try JS or CSS, Completed 3 projects by 22:00 and now can't hold myself together and now I falling apart to sleeping state. (No caffeine) Perhaps, I should continue Learning Python along with Web.
#devdiary #day1

:D

This one is funny for me because my current team lead and I have a really comical dynamic regarding reviews.

I can't say I've ever really had a bad experience but I brought up one stand up about how he had rejected my PR and that he was probably just going to reject the next one. So now it's this joke if I get a PR through in one review (which is usually).

One time he spiked a ping pong ball towards me in a match and I replied, "Hey whoa man, this isn't a code review calm down!". 😂

I don't know if it counts, some weeks ago I wanted to publish my first telegram bot on github, so...
Well, I was quite nervous when I wrote it, and I didn't care about writing good code... That wasn't even passable... It looked like an american coffee... Washed, tastes bad, looks ugly...
I wrote it back in two days, changed module from telepot to python-telegram-bot (more pythonic), wrote a c extension for a xorshift algorithm and pushed it on github.
Well, that was quite satisfying, but I became pale when I noticed it didn't need to be restructured, but entirely rewritten

Not really the worst but it happened last week. Our lead Dev reviewed a pull request based on works that have been validated several times.
Suddenly, 5 minutes before leaving to take a plane for the week, he tells me that everything is to be refactored because it has no semantical sense, even if it worked perfectly and could be refactored later.
He told me that the day before the delivery and rewriting and restesting everything that had been done took 2 days, several out of worktime hours and huge stress phases. The delivery had to be delayed twice.

I'm easily stressed and a lot of things went by with bad timing (one other coder who could help me was not present, another had to leave early for his kids etc...)

That refactoring was unnecessary but it gave a bad impression to our client and made feel bad fr something I wasn't responsible for.

Can anyone guide me for proper pyhton learning ?

When you are reviewing a PR in which the author has used utilities/libraries that were written by you(which were very generalized and DRY but required for you to read the docs to clearly understand their usage). But instead of using it properly they modify it for their specific usage and made a freaking PR. 

I just can't wait to finish the review and slap their face with a printed copy of the FUCKING docs. 

Seriously, read the goddamn docs. And, if you do change the lib, please update the doc too.

Every day when I wake up I thing today is the day I start to create codeignitor application but I am not do anything ?????why this happen

Hmm, I guess I'd say that time when we never had a code review

Pixel 2 design looks like shit.