7

I was working under the title of mid-level developer when I felt I was clearly still a junior and was tasked with making changes to the core search functionality of the company website. After it was 'reviewed' by 3 people more senior than I and merged to production it took the majority of the site down.

I got the blame and the reviewers weren't even questioned 😒

Comments
  • 1
    here in our company is the reviewer the one who merges stuff into the stable branches, so it is their duty to do proper reviews and take responsibility for the change, even if it is not his code. That means in concrete terms that a reviewer is at the same time also a tester. if code looks bad, or functionality is not given, then reject, otherwise it is at least to some terms their own fault if shit happens in production. I like that a lot, because that means we are getting a lot lesser errors in production.
Add Comment