Join devRant
Do all the things like
++ or -- rants, post your own rants, comment on others' rants and build your customized dev avatar
Sign Up
Pipeless API
From the creators of devRant, Pipeless lets you power real-time personalized recommendations and activity feeds using a simple API
Learn More
Search - "code quality"
-
Yes Linus Torvalds is an asshole and the world is better because of it.
In short Linus's acid takes on code quality over developer fee fee's might be one of the things that has made the Linux kernel and the GNU/Linux project such a long lasting open source success and in my opinion the risk of him falling for all this "let's be nice and non offensive" bs trend may impact negatively on code quality.
Being an asshole has it's downsides and it's not always the best response, I'll give you that, but personally I think most of us who are viewed as assholes are seen like that because we put quality over convenience, facts before feelings and dedication over mediocrity; it is not because we hate you, it's because we measure ourselves with the same stick.
It depends on one's character, but when you've been toughened up because of bullying(I don't doubt many devs have been since being a nerd has never been hip) or life in general, you learn to stop whining & pick yourself up and you expect everyone to be competitive and competent as you are and it gets frustrating to manage people who don't fulfill your expectations.
Pros: You get shit done and you do it well.
Cons: People won't like you and you don't tolerate failure (much less mediocrity).
Yes Linus is an asshole, my coach was an asshole, some of my best teacher's have been assholes, I had friends who were assholes, heck I'm an asshole!
But I thank them because they made me better than I was, just as people have thanked me for being the right amount of asshole.
A warm thank you and fuck you Linus, keep being the asshole we need.36 -
Heard the plumber yelling because of the work someone before him did on my heating system...
As a programmer: -
Me: code quality is important
Everyone: <no shit given>
Director: code quality is important
Everyone: yes, it is very important, hurray!
Fast forward few weeks/months...
Me: why this function accepts 14 arguments?
ShitDev: yhm, you know, we need to fix it... maybe
Me: why this exception is swallowed?
ShitDev: oh, really? yhm, yhm
Me: why this function is copy-pasted and repeated (20 LoCs)?
ShitDev: yeah, true, but we wanted to make it fast.
Me: Dear director, this project sux and its quality is shit.
Director: you're exaggerating, it can't be that bad, it works, right?
Me: <polishing CV>
ShitDev: got praised for delivery14 -
Please for the love of god name your variables in a sensible way! How the FUCK am I supposed to read your shitcode if you decide to write 6 (!!!) nested loops with variables each named by exactly one character. With no comments whatsoever!
I would rather crack password hashes than this nonsense.13 -
Today I felt sorry for my boss.
Story behind it:
My boss always encourages me to do the right thing. One of those right things is to enforce quality gates in our build pipelines which, as many of you know, means that the build fails if certain quality parameters are not met. Now an external vendor team merged the code this past thursday for a large feature that they had been working on and our build failed majestically throwing out the statistics and the offending files and lines of code.
All hell broke loose and there were escalations and what not and people working extra hours and over the weekend to try and get it right. So, I get a call from my boss earlier today to explain to me how important it is to release the feature and how it's going to be very bad if we don't. He was trying to justify his ask which was to lower the quality criteria and let the build pass for this week. Of course the dev in me was furious but then I realized it's not him but the corporate culture. Why would he or anyone would risk losing their jobs over the quality of code?
If you work at a place where IT is a support function of the company's primary business, I understand the moral compromises you guys have to make sometimes to keep the ball rolling. Thank you for your effort to make the world a better place.
So, thank you boss for all your support. I know it's not always up to you to decide on things but keep up the good work.4 -
I'm not sure if my in-laws know me really well, or if they are secretly plugged into Github and are making a comment on my code.4
-
Reviewing coworker's code:
Me: I see you're doing a convoluted sort for every element twice to get your two lists in sync... 😐
CoWorker: Yeah. *straight face, no regrets* That's the only way to do this.
Me:... Uh... No? You can just manage one list with a simple struct and then use the the standard sort.
Coworker: Yeah sure I know. But it'll take time. We don't have time.
Me: *aghast* This is embarrassingly bad code!
Coworker: Don't worry, later on I'll use a hashmap for it. But this needs to be pushed now.
Me: *to myself, no you don't need a hashmap*
Okay, you do you but I can't back you on this. It isn't going to take a lot of time to correct it.
Next day.
Coworker: Hey can you review my code again?
Me: You've made the changes already? *in a bored tone, knowing that they wouldn't have changed shit*
Coworker: No this is a different file. Our manager agrees that we can worry about performance later.
Me: Sure. *😀🔨🔨*
Few weeks pass by:
QA: The operation takes absurdly long time to complete even with the smallest data. Ten minutes for X is unacceptable.
Me: Who would've known? ☺️21 -
Volunteered to fix a brittle component in our app. Turned out to be 26 classes of mostly copy pasted code that is riddled with todos and void of feedback for the user. Here's a pretty representative sample of this code's quality:5
-
KISS.
Keep it simple, stupid.
At the beginning the project is nothing but an idea. If you get it off the ground, that's already a huge success. Rich features and code quality should be the last of your worries in this case.
Throw out any secondary functionality out the window from day 0. Make it work, then add flowers and shit (note to self: need to make way for flowers and shit).
Nevertheless code quality is an important factor, if you can afford it. The top important things I outline in any new non-trivial project:
1. Spend 1-2 days bootstrapping it for best fit to the task, and well designed security, mocking, testing and extensibility.
2. Choose a stack that you'll most likely find good cheap devs for, in that region where you'll look in, but also a stack that will allow you to spend most of your time writing software rather than learning to code in it.
3. Talk to peers. Listen when they tell that your idea is stupid. Listen to why it's stupid, re-assess, because it most probably is stupid in this case.
4. Give yourself a good pep talk every morning, convincing you that the choices you've made starting this project are the right ones and that they'll bring you to success. Because if you started such a project already, the most efficient way to kill it is to doubt your core decisions.
Once it's working badly and with a ton of bugs, you've already succeeded in actually making it work, and then you can tackle the bugs and improvements.
Some dev is going to hate you for creating something horrific, but that horrific thing will work, and it's what will give another developer a maintenance job. Which is FAR, far more than most would get by focusing on quality and features from day 0.9 -
A guy breaks into your house and start slapping your face with a huge C programming book for 5 minutes until you bleed top quality code from your nose.
Well this is what I was going to comment to the "learn C in 5 minutes app" rant, but can't find it anymore.2 -
Boss: Have you finished that feature?
Me: Almost there, i'm refactoring some classes...
Boss: What? Refactor? But thisnis a new feature, it does not need refactor! We don't have time for this!
Me: 😵🔫
This is what happen when you care about code quality.5 -
!rant
Some days ago I finished "Ray tracing in a weekend" (Peter Shirley) and I'm learning a lot :D
In the new year I will start with "Ray tracing the next week", but there are still some things I want to tackle before that (improve code quality, optimize... it's my first project that is bigger than a codeforces problem solution, a part from the projects at work).
Any sources of wisdom and recommendations are welcome!!9 -
The rants I read here make me want to be a better developer. I started writing tests, linting code and ensuring 'quality code' because of the devrant community. Being a self taught developer, you never really have anyone to thank. But today I would like to appriciate you all for the rants, comments and advice that make us developers become better at our craft.2
-
"Quality CSS" is much a fucking misnomer. As someone whose been writing this shit at scale for 15+ years I can tell you all CSS code is garbage. The only thing you should do is make sure you don't have name collisions. Classes/components are self contained. And use variables when possible. DRY makes sense usually, but if you're dogmatic about it you shoot yourself in the foot.9
-
No matter how much product owners claim "bugs have priority over anything else", "we value high quality structured code", and "we do test driven development"...
...Once a big client wants a feature to be developed before they sign up, dirty code will be written from napkin specs, and that code will always be refractored "soon".4 -
"I strive for code quality and maintainability. I actually do. And i will not work for a company that does not care about it and just wants something done as fast as possible.
The only time i will do something quick and dirty is if it's actually urgent. And even then with one condition - my next task will be to fix it properly.
I do not care about your deadlines. I will do my best to meet them, but not at the expense of code quality. I've seen too many projects fall into technical debt, where productivity is so low, that the only way to move forward is hire more people and start working on a project 2.0
And please do not lie about how great your company is, if it's not. These kind of things surface very soon, and you will have wasted both of our time, because as i said - i will not work for a company that does not care about code quality."
you think i'll ever get a job again if i put this on my CV ? :D10 -
A nice word to all developers who say stuff like "I know I write bad code, but what does it matter.":
Please try to think in a logical way about what this part you are about to write has to do. It is much more difficult to rewrite code, the longer you wait after you started to code.
Bad code can have big impacts on different levels.
For example financially: Bad coding style or program structure can lead to thousands or much more in losses because of nasty bugs, bad performance, expandability or maintainability.
Think about quality over quantity.
A little example: I had to work together with other coders to meet a fucking tight deadline. The last day we coded like crazy and these dudes started to apply styling changes (CSS) directly as inline styles to the HTML code, instead of taking a few minutes more to find where in the CSS files they had to make the changes.
At the end of the deadline we had more stylingbugs than before. It took us another whopping 3 hours to fix what they had done.
So next time you code: Thinking before coding is mostly faster than just straightahead coding and fixing at the end. 😉2 -
I'm real tired of my coworkers always trying to one up me and being elitist about their code. Like I get it, you think PHP is shit, C is so much better than Java. Wow, you must be so knowledgeable! /s
Just because you're bashing on bad languages and talking shit doesn't mean you write good code, and in fact your code isn't top quality, I've read it. All you're going to accomplish with an elitist mindset is close yourself off to improving, and that's probably the worst thing you can do as a developer.8 -
1. Refactor shitty code because it is hard to maintain
2. Rant about how can someone write a code like that
3. Check commit log to see who is the person to blame
4. Found out that's me1 -
That moment when the you actually think that this huge refactoring isn't worth it, but you do it anyway so you can live with yourself...
Code quality is love. Code quality is life.1 -
Cringed when I saw camelCase, snake_case, PascalCase and CONSTS (for non consts) in 10 consecutive lines of code! 😖😖😖
I suppose if you don't know which coding style to pick... Just try them all!!!!! 😱7 -
An open letter to those who think lines of code == a decent metric for productivity:
NO!!!
Just because I wrote 10 lines of code all day (yes just 10 very well thought out, many times rewritten) lines doesn't mean my day was unproductive. Quite the opposite, while other devs pad their shit with:
//Adds 1 to I
I++;
Yup. Quality code. LOC doesn't lie.10 -
!rant
Our lead dev in the company seems to be a smart guy who's sensitive about code quality and best practices. The current project I'm working on (I'm an intern) has really bad code quality but it's too big an application with a very important client so there's no scope of completely changing it. Today, he asked me to optimize some parts of the code and I happily sat down to do it. After a few hours of searching, profiling and debugging, I asked him about a particular recurring database query that seemed to be uneccesarilly strewn across the code.
Me: "I think it's copy pasted code from somewhere else. It's not very well done".
Lead Dev: "Yeah, the code may not the be really beautiful. It was done hurriedly by this certain inexperienced intern we had a few years back".
Me: "Oh, haha. That's bad".
Lead Dev: "Yeah, you know him. Have you heard of this guy called *mentions his own name with a grin*?"
Me: ...
Lead Dev: "Yeah, I didn't know much then. The code's bad. Optimize it however you like. Just test it properly"
Me: respect++;2 -
Yo, is this devrant or spamspace???
Like, do you even fucking work, mates? Are you a dev? How doesn't a fucking legacy code piss you off on a daily basis? What are all the ways you want to respond to your customer's/PM's abuse? Does your lead dev even know jackshit?
Where did all your quality rants go? Why do you all sound like second graders writing essays for school? Have some passion for your job, and hatred for the incompetence for others!
Now, go produce some quality rants! Funny ones too! Bonus points if it's angry-funny.20 -
How I spend my days at work working with legacy code:
* Writing tests before I do anything
* Noticing that i cannot write tests because of antipatterns. Lots of them.
* Refactoring to make at least a tiny bit testable.
* Then writing tests.
* More rewriting and refactoring
* Finally adding that one feature my boss asked me for
* Writing tests for that new feature (my do that before implementing)
* Explaining to my boss why it took me so long and agreeing on stopping writing tests.
* 2 days later: explaining why i still broke something.
But in the end my code works just fine.
my colleagues handle things differently. They just ignore problems as long as at least one feature works a bit.13 -
My teachers use the number of commit you do as measure for the quality of your work.
I've the least number of commits this week since I spent most of the week doing encriptions algorthims instead of UIs and unit test as the rest of my team.
But, by their logic, I'm the worst of the group. It's simply stupid.9 -
I worked someplace once that fired a person for lack of quality output. Before that he sued the company over a labor dispute. After they fired him he went and founded his own business. A year later the company decided to recycle his old laptop to another developer and discovered the source code and business prospectus on it. The company took it to court and said it was actually their business because it was created on its own equipment and the time stamps confirm during business hours also. Courts agreed and they got possession of his business and then fired him again.6
-
Our CEO suddenly wanted to work with an outsourcing company to build the product. On one of the "sale" meetings I asked a guy from that company:
- Can we interview developers before they join our project?
- Our company is responsible for the quality of the service we provide, - the guy replied
- What are you going to charge us for?
- For all the hours developers worked
- So your service is developer hours, and we'll be obligated to pay for all the hours they worked regardless the code quality or the performance, right?
So it seems outsourcing company is only responsible for their time sheets to correspond to real hours worked? :-)
We call such a companies in Ukraine - a galley2 -
Everyone complains that a certain developer's code is not up to standard and when they have to take over his project the lack of code quality is really slowing them down.
I look at code, agree it is poor quality and put together a learning plan for said developer.
Also look at who approved every pull request which allowed bad code into our codebase. Same developers as those complaining it's no good. You had your chance to stop it!9 -
A) Create something that works, is fast, minimum bugs, have edge cases covered, nice testes, clean code. Cool, you did your job. END.
B) Create something shitty with bugs, performance issues, non or poor test coverage, mess code, etc. Cool, you did you job. But...
Next week you reduced bugs by 50%. Wow, you're rockstar.
Another week you improved performance by 15%. Again, you're the hero.
2 weeks later, you reached 85% test coverage. Management is so happy that almost got orgasm.
"A" took 3 months, "B" took 3 months plus few months of fixes. The only time where B was winning was first 4 weeks, where A was carefully building it's architecture and quality.
Yet B is seemed more successful.
This industry is F****d Up beyond my understanding.6 -
OK so I'm just going to announce this. I'm done with my WPF client for devRant. It's not really "Production" quality but it does what I want and well... it's good enough for me and I need to move on.
Here's the release and code if anyone is interested. If you want any other feature, you can just fork and implement it yourself.
Repo:
https://github.com/allanx2000/...
Release: (ClickOnce installer in app.zip)
https://github.com/allanx2000/...23 -
Apparently some freaking man in my ex-team tried to learn Vim because he thought he could become more efficient but he spend more than two weeks trying it while delivering poor quality code with extra spaces, bad indentation and extra "wq" strings10
-
I was having dinner with two girls, one a project manager and the other some finance reviewer or something like that. We were discussing our line of work and I was talking about how bad quality code affects everybody and the finance reviewer girl goes like (and I quote) "In our company we use polymorphism, inheritance and encapsulation so it's not a big problem. So our database has a parent class and we only use the parent class". I was at a loss for words. I mean, if only more programmers just did that, right?14
-
I saw this on the first page of a book that discusses techniques for writing clean code... The more I think about it, the more accurate it tests.
-
My current project is a fucking nightmare.
It started in 2007, using a solution developed by an Indian company due to outsourcing (aka low-quality code).
It's running on Java 7 on the back-end and its front-end side is pure Javascript files. There are thousands of little .js files everywhere, no documentation, no comments, differents coding styles, outdated API that were already outdated at the time, mixed oop and procedural.
Not even when I started coding, I wrote something so horrible.
Yo, it's a clusterfuck and I just wanna get drunk.5 -
I'm task to amend the code smell in the project. I literally can cry a river.
I see such thing as i = i++; - It's flag out as a bug.
I have also seen check in classes. With un-used variables. I literally cried.
In the past, i ask why do i got to care about code quality. I actually start to get angry like the team leads in my project.7 -
I'd say one of the best advice a dev gave me, was that, I should not write duplicate code, but rewrite these parts to a single function.
And another one: If you use specific values in the code, instead of putting it in multiple places, assign it to a variable at one place and use the variable later on.
These advices sound quite trivial, but I think every beginner should learn these as eary as possible.
Boiiii have I seen shitty code from people who don't give a hobo's ass about maintainable code.
Be a good coder.
Write for quality, not quantity.
Care about your successor.
Thank you.
If not, I will fucking find you, fill your guts with napalm and light you up alive on a rusty pole while laughing hysterically.1 -
I think Clean Code: A Handbook of Agile Software Craftsmanship by Robert Martin should be a must to read.
In school no teacher puts emphasis on code quality.
They should learn how to name variables and functions the right way at an early stage in order to better perfect their craft :)3 -
I dont see why recruiters find it relevant to ask how many lines of code a piece of software has. Like seriously why!?!?!?!
It by no means measures the quality of the code or the usability or complexity of the software.6 -
Today I started work on a new project that contains a lot of legacy. I asked the developers about unit testing javascript and was told that not only is there none in place, but it's not worth adding any in.
At first, I grimaced and thought fair enough. This is their codebase, it's their choice. I've now been thinking about this for a few hours and have instead decided that screw those guys, I'm adding in a testing framework, a module pattern that's compatible with the existing code, and unit testing the crap out of it. If they don't want it they can refactoring it out, but I can't bring myself to intentionally deliver code I know is crap.
I WILL FORCE CODE QUALITY ON THEM.7 -
Management: Create [totally idiotic and complicated feature, near to impossible to create]
Me: that's close to impossible and could probably destroy some other parts of the application.
Management: well, then your application is poorly programmed.
DAFUQ? HOW DARE TO JUDGE THE QUALITY OF MY CODE WITHOUT EVEN ABLE TO READ 2 LINES OF CSS? WHAT THE FUCKING FUCK IS THIS?
I'm really not easily offended but this sentence hit really hard.4 -
Code quality check punishes writing massive documentation strings due to "too many lines of code"
FML1 -
Hired a designer below me.. guy never wrote a full back nor frontend... Used npm shit for all his solutions and worked his way above me just by kissing ass and polluting the codebase in such a way 70% would be open source shitty plugins for shit he could not do by himself code wise...
At some point he assigned some of his tasks to me and I couldn't work with his patchy framework that was non existent within the codebase I worked on ...
At some point between npm installed tantrums I got pulled up to HR because my code quality dropped... And it was this fucktart that accused me of this saying I could not do modern development...
In the end I either had to butkiss after his butts or just quit, so I did the latter... I told him and HR I owned alot more code quality than this asshat but just not his way of working and therefor it was more an issue of code equality I was never aware of ...
A month after that the company got overtaken by some silicon valley bullshit company buying up competition, and he is still working within that shithole dealing with 90's tech...
Was the best thing that happened to me, after that I grew alot in skillset and such by investments from other jobs and projects... If I would still work there today I would consider myself a caveman6 -
Coding-related ads are always entertaining. They nearly always contain easily spotted nonsense and error-filled code. Not even sure where to start with this one...9
-
All the noob jokes about "tee hee I write such bad code exdee" fucking drive me nuts.
There are absolutely such things as good codebases, in any language. By posting "tee hee funny relatable" "memes" about your shitass code you just make yourself look like a fucking idiot who excuses poor quality with "haha so relatable!" bullshit excuses.
Thank you for being the literal cancer of the industry, oversaturating the markets and making all of our managers think we're fucking idiot babies that have to be wrangled like cats in order to get a single feature out the door, devoid of rational thought or a modicum of expertise.
Fuck you. You're the problem. Be better or find another profession where slacking off is acceptable.18 -
New GitHub Copilot Research Finds 'Downward Pressure on Code Quality': https://visualstudiomagazine.com/ar...
No shit, who would have thought that automated garbage generation could hamper quality?9 -
Gotta love moments when you find legacy code like this :)
P.S. Yeah, that was the whole script, written by just one guy.3 -
The weekend is here!!!
Time to go out and have fun!!!
Nah just joking. Time to write some quality code after cleaning our company's backend (pun definitely intended) all week! -
Our CTO doesn't believe that tests improve code quality. We have no tests on any level, no testers/QA, no code reviews. Nada. I wonder why production keeps breaking 🤔 Guess I'll start looking for another job 🤷♂️20
-
2019 goals:
- finish my masters
- improve my code quality
- build at least 3 personal projects
- learn 2 new technologies
- find better clients or a good job1 -
Found my old code.
You gotta admit, that's some clean code there, considering I learned C# only for a year at that time.
But those comments....
VeRy WeLl WrItTeN, vErY dEtAiLeD, vErY gOoD8 -
Everyone is on their vacation and I am in good mood so time to refactor some 3 year old frontend, angular, javascript code. After 5 minutes of looking, some great quality of code snippet on the image below.10
-
The feeling when random dudes downvote a question, because a guy who finally earned some points on SO dared to format the code with `<code>`<br> He pasted code, log, even explained a little bit and ~500 point guy even flags it like _unclear_ although there's clearly visible import error.
I mean... as an answerer or moderator, I'd be damn ashamed for such behavior! I have absolutely no problem kick a person with words + explanation in my answer or comment, so that (s)he remembers to ask better questions and feels bad about that, because nooby questions are already answered so many times there.
But to downvote because of formatting even if you have a permission to edit and a flag for low quality or because you can't read ~40 lines of log makes you just a retard and hurt the whole remaining community of guys like me who find time to sit there and answer questions to help another people.7 -
"Potimized imports and remopved temp code"
Can't help but wonder what's the code quality like from an author of such a carefully written commit message 🤔3 -
You know you have a quality teacher for C code when you are writing a test and you have to write the code on a piece of paper4
-
I carry the same mindset as an aspiring programmer as I did when I was a music major. There were times I practice for hours and got very little out of it in terms of quality (because I wasn't interested, focused or willing) and then there were times I practiced for 20 mins and really made progress on the piece. So I always keep that in mind to save me time and to produce better code overall.1
-
Staying up late night and sacrifice on sleep to complete the task at hand. A good night's sleep will result in good quality code.1
-
let's try something...
Roast thread, please tag and insult your fellow devRanter in this comment section. Get creative in finding swearwords. Too many ++ bombs, poor code quality or you're just secretly in love with some other Ranter and hate it.12 -
Engineering managers will say things like -
- "I'll let the team decide what's best for them" & "code quality is our primary goal" -
but then they'll shoot down any & all requests to go back to some old piece of code and refactor/clean it, because of "deadlines".
Hypocrites, all of them.3 -
End user when criticizing a developer for 'taking long' to create something of value from scratch:
(4 hours later): "What's taking you so damn long? Are you retarded?"
Oh I don't know, maybe I have to make sure that tests in my code run well, maybe I have to evaluate everything to meet the custom satisfactions of the user for his ever-so-custom requirements and I also have to make sure I discard what they don't like? And maybe it takes time to deliver a quality product, and so on?
Or would you prefer I deliver an untested product that I didn't bother to think about and I haven't bothered to make sure it matches with their requirements?
What end users don't understand is the involvement in a quality product.2 -
Let's start by saying: God do I love programming and hate work!
My dream job would be a place where I get to write quality code for something that's actually useful and makes sense to people (or a group of people) without all the usual job bullshit; all the politics, fucking useless hours of meetings, the pretentious ass holes, and the useless mindless product owners with good pay to live comfortably and some organization (not being a complete disaster). It's only a dream though...5 -
When you're judged by the number of lines you wrote/commits you pushed/any other non relevant stat rather than your code quality1
-
SonarQube reduces our code quality through arbitrary nonsense rules, and it's inability to understand perfectly decent Kotlin code. Unfortunately we have a CTO who is completely enamoured with it. I hope someone from Sonar is reading this: You made my pleasurable Dev job a misery, and it may very well be the thing that makes me quit. Fuck your arrogant product. I honestly wouldn't mind it so much if your UX offered a way to discuss each warning and provide affected code snippets so you could argue your case and collaborate on the rule set. But no, you know my code base best right? Fuck you and and your ivory tower.8
-
in Russian the word “шляпа” (fedora) means not only the specific hat but also something that makes no sense, something ridiculous or something of low quality.
So when someone sends you some spaghetti code on a review, you can just say “That’s fedora” and I love it. You can also WEAR a fedora and point to it as a response to someone saying something that makes no sense.4 -
Why is source code so crappy? May career is not the longest, buy in my 8 years I talked to so many developers and every one told me how important quality, standards, tests and architecture are - but every codebase I've seen is lacking all of it. Everything is running on constant live support.
I don't get it. It is like I live in a world where everyone does know what has to be done, but no-one does it. I suspect it is because people are lazy, lying and won't say no but that's also not a world I want to live in.24 -
It's making me really anxious that I have to cut down on UI/UX as well as code quality just to meet my deadline.
-
Fuck unreasonable deadlines. Just do your stuff as if you have the time of the world. Stop compromising the quality of your work and things are going to be done when they're done. Good quality stuff that's worth the wait.
I started to tell this to myself this week. For months now I took the bait that everything is urgent. And whatever crap management want has to be done yesterday. But.... Well... They pushed it too effing far.
Redo this module that took the former team about six months to finish. You have 10 days.
Well... What? Everyone is saying yes?... Everyone going full code monkey making no progress?
This is the moment I stop compromising and stop listening to your suggestions. I am going to do what I know how to do, the way I know it works, and I will not cut one corner based off your suggestions. I'm sorry, I've been dealing with this shit for too long already, and I don't want to suffer the consequences of degrading the quality of what I write anymore.5 -
I've taken a year's break from university to work on projects using various languages. For the first half, I've been trying to produce as much as possible. Now, I'm taking my time and producing less. I've gotta say, I'm enjoying it far more now. I feel like I'm learning more and producing better quality code.
-
Work of a my co-workers good work! It's called colspan you dumb fuck! Best part is that no way I'm changing this coz I work in place where they don't give a fuck about code quality! So fuck it!6
-
When reading through someone else's code, what about it made you think "Damn this is well written" or similar?
Any language - I have a bias towards PHP, C++ and C though.9 -
Introducing the unified standard of quality measurement.
WTFs/Minute
is a new standard coming from code reviews, which also applies to movies, porn, women, ....
what's your opinion ?2 -
A friend of mine wrote a Rubik's cube timer in c# as suggested by me for him to practice. This was so terrible....There were lines like:
start.Stop();2 -
One of my TL said to me during code review that place a break statement after return statement in switch case.
Being with a bar leader can certainly degrade your code quality.10 -
I am driven by my love for this industry and wanting to do everything to the best of my ability.
Being a strong advocate for quality i am always on the look put for new practices and finding new ways to improve my code.
If you consider a project 'done' then you gave up on it.1 -
Was helping my dad with his Arduino project when I realized something beautiful about being a programmer.
I have never worked with Arduinos and I'm clueless about hardware stuff but I was still able to debug, go through documentation, example code and fix the issues.
Programming is equally about the passion, dedication and ability + curiosity to solve a new problem as is writing some piece of quality code.
I might have taken a while to realize it but it sure is a wonderful feeling.1 -
I already had a previous succesful interview the day before and just went to my current employer out of decency.
The previous day gave me so much confidence, that I dominated the complete interview and asked them what they could offer me, that I would choose them.
On my way home they send me a text how much they were interested in me and that they will show me code as I demanded.
I took the job because the were as much interested in quality, as I am.2 -
(I guess the Question category is the best for this)
Do you believe that someone can be a good dev even if they write shit code?
I personally do, if that person acknowledges the fact that their code is shit, wants to improve it, is humble, is always in the search for constructive, etc as in to make their code better and more readable, I'd think they are a pretty good dev.2 -
My senior and I started pair programming to improve my code quality. He likes it and I find it fun (and convenient that he helps me) but it feels like I'm making him do my work. I also fear that I am too horrible to be trusted with code alone but if that was the case they would kick me out right?5
-
[Half question / half rant]
Would you rather work with a laid-back, humorous colleague who produces shit code and won’t understand advice for improvement?
Or would you rather work with someone who’s more serious, even slightly boring, but who takes quality seriously and is open to advice?
Yes I’ve worked with both types. Hands down I prefer working with the latter. With the first dude I’ll have good conversations and a good laugh at his puns and jokes. But at the end of the day I’m pulling my hair trying to make sense of his code and spending a shitload of time reviewing his PRs just to make sure he’s not fucking things up even more.4 -
I was mentoring a group of students and helping them with their graduation project. I taught them NodeJS, MongoDB & few other things.
One time, one of them came to show me her code, and it has the weirdest and most bizarre structure ever!
I asked her, “who told you to structure your code like that? This is wrong! I didn’t teach you this way!”.
She replies: “<<a local shitty tech startup name>>’s CTO”
When I searched about him, he’s a civil engineer who founded a startup and assigned himself as CTO with no technical background or knowledge whatsoever! FFS students believe that he’s a real CTO and started learning from him 😑 His code was so bad in every way that a fresh would write a better code!5 -
Coding faster is more important than code quality? GitHub shows a call to action: "Code 55% faster with GitHub Copilot". WTF?14
-
Code review?......... what's that?
Joke apart, We literally don't do that in my workplace, only few people care about code quality and what they are pushing to production2 -
“We mob every thing so that means we don’t need pull requests, because by the time the code is committed it’s had plenty of pairs of eyes on it”
Well, I beg to differ.
Today I read through some of this spaghetti mobbed code to look into a performance issue. Wasn’t supposed to but bored stiff so I ‘went dark’ and did it without the mob.
After about an hour I figured out it runs a few lines of dubious code and if there’s an error it tries many times over with an exponential back off.
And each run of the methods will fail for sure because of how it’s written.
Someone must’ve seen this problem but instead of realising it can never work, they’ve wrapped it in retries and back offs.
So many back offs and retries that it just sits there doing this for 25 minutes.
But yeah. The mobbing works great guys, keep churning out this quality code. 😂😂😂
Can’t wait to see the back of this joke job.4 -
I have a 4S I leave lying around and most apps are dogs on it or crash.
Not DevRant app, though. Pretty solid. Impressive job.9 -
So... the company I work started a selective process to hire some interns. Since we had a lot of applications and little time, they created a simple test with coding, theory and interpretation questions (9 questions in total) to filter the best candidates then focus on the better ones.
One of the questions (the only one the candidate would actually code) was asking to write a simple FizzBuzz function. The idea was to check the quality of the code and clever/creative ways to solve the problem.
Turns out ONE of the candidates were able to write the function. So now, this question is not being used to evaluate the quality of the code; instead, it's being used to check if the candidate knows how to code at all.
Such disappointment...
-----
PS.:
The idea to put this question on the test was heavily based on the arguments of this video: https://youtube.com/watch/...
:)2 -
I'm a junior dev, been on placement a year.
I get tasks done mostly on time, my pull requests are merged, yet I still feel like what I'm writing is seriously under quality.
What point will I stop writing code that isn't good enough to not be stressed about? 😷7 -
So I got this new job as Java developer, the people are really great but is the kind of companies that only takes care for fast results and not for code quality.
Because this I have to deal with libraries updated 4 years ago, classes with 8000 lines, methods with 500 lines, a WHOLE lot of work arounds because there is no time to really fix the issue unless it affects directly the customer (something not working or being really slow) aaand we use fucking svn.
Some of this practice's they know and encourage it (+1000 lines classes for example) and every time I try to talk about good practices in the code everyone seems so interested but there is always no time.
Sooo I will stay here for at least two years, I hope I can make a change for good in their code smells.3 -
Fuck my project manager. He wants to sacrifice code quality, test coverage and technical debt in favor of more features. In the future when everything takes longer or breaks guess who is responsible? Certainly not him.3
-
Spent 2 days refactoring code written by our "offshore team". I've done refactoring on the same code in the past, probably upto about a week in total of refactoring now. The code looked like it was written by someone who had literally just finished their first "Hello World" app - loads of code blocks copied and pasted instead of declaring reusable functions.
The whole thing should have been done by us in the first place.
And yet our money-conscious company wants to employ more of these developers. Cheaper than us? Sure. Quantity over quality though, but I guess money is all that matters to the big cheese1 -
For the first time apart from Data Structures and Algorithms, there was a Machine Coding round where they asked me to create a small app using any language without data persistence or GUI, to see my code designing ability, LLD, code quality, whether I can implement OOP and write modular code and to see how extensible my code will be.
I did well.2 -
I coded part of feature 2 months ago.
Left it to help frontend guy a bit, deal with fire after release. ( we’re missing frontend integration tests and every release is pain in the ass ).
My backend code coverage is about 80% so not much can go wrong at this point.
So I added more code today and it looks like new feature is working but don’t know what the code I added 2 months ago exactly do.
The only thing I know is that it definitely needs refactoring ...
Being only backend dev / release manager / administrator/ dev ops in project is painful I need to deal with everything on my own 😔
At least client doesn’t care if it’s done in one week or in one month right now.1 -
A client asked for a tool for his website. So I built it for him and he was satisfied with the thing, cause it did what it should. Nevertheless I was not, because it kind of had a messy backend. I made it working and charged my time. Now I am wondering if I should rebuild the thing to satisfy my code quality for free, or just keep that thing as ugly as it is....
What your opinion on this?6 -
> do you feel sorry for freelancing contractors
> whose previous client abandoned them
> they ask you to help them fix some trivial bugs in the shitty code
> you believe you can change the world by going overboard by also improving the code quality, along with fixing the bugs
> initialize an empty file where you'll translate the shitty code into a more organized one
> start creating variables and generic functions which can be used in a modular and organized fashion
> meticulously document the first function you write
> realize this is not worth your time
> insert some glue code into the original code which fixes the trivial bugs
> glue code has hard coded values so it adds to the shittiness of the code
> submit the work
> get $$$ -
Got a senior dev at work.
The guy is good at his job, no doubt, but his insecurity drives me up the wall.
- Constantly double checks work done by non-seniors.
- Setup a policy where only seniors can code review.
- Tells non-seniors not to give out advice as they don't know what they're talking about.
- Edits pull requests for you.
- Demands unobtainable quality for insignificant pieces of work.
- Patronising teams messages on the regular.
We're all just trying to get work done and he's always acting like we haven't got enough stripes on the badge.11 -
Working on codebase of a 20+ year old system that the company I work for bought five years ago and in that time there’s been no refactoring, no security updates, no attempt to create automated testing (there is none), new features have just been built on the codebase with no regard for quality and it’s just spun into the horror cesspool that it is today.
I joined one year ago and I’m slowly refactoring the codebase and updating it to get it to a more modern codebase, cleaner code, faster load times and creating a ton of dev documentation so the devs in India can start getting into best practices and start producing quality code.4 -
Just going through some old code from git repo's and code examples and I have a message to every dev out there after seeing some of the code quality...
Never... ever... ever fucking give variables with names like vx, tr and sq.
Give your variables names that explain what they are, it is so fucking hard trying to follow code that has 2 letter variable names and there is a special place in hell for you :-)3 -
Since graduation, I have worked in IT for 2 years, mostly in testing and implementation side. Finally I got a developer position in the field I wanted (Data Engineering). I had never thought that it would be such a soul crushing experience. My current company is very notorious for its bad management practices, but there is indeed a bigger picture to this. The IT industry in general has devolved into a gigantic ponzi scam built on exploitation and BS. Quality of solution and quality of work was replaced with a ‘Does it work now?’ approach with zero contingency. And the fact that geeks and nerds are naive only helps the white collar crooks to exploit them as code monkeys. Fuck all of this!1
-
I hate those morons who do QA by simply clicking around. You are a disgrace to people like me who like to code and still enjoy doing testing.
Get a life you fuckers. You are the sole reason why many people in industry thinks that QA is something anybody can do.
Yes, I agree you can test the application, but in no way you could ensure the quality of the product.4 -
If you have no defined business processes whatsoever nor code quality practices, why bother putting on the job offer "software engineer" or "full stack web developer"?
WHAT YOU'RE LOOKING FOR IS A FUCKING PHP HACKER -
Recently, I failed a lot. Most of them were interviews. Some failed at code challenge. Some of them were leet code type challenge. Some failed at less quality vs other people. Used to be ashamed or angry. Now able to embrace it. Thanks to jack ma's documentary. Start to integrated his philosophy into life.1
-
Worst experience?
Fourth semester. Programming project.
We were 4 persons, I did almost all the work (including fixing the stuff they broke) but that's not the point.
One of them somehow killed our git repo at least once per weak. It was really annoying, because I had to fix it.
Also he named *all* of his commits 'Pfuschpush' (Pfusch is German for botch). And the code had exactly this quality. I often had to rewrite everything he did (or simply revert the commit).1 -
My colleague told me today that companies with shit code quality, complete chaos, no tests of QA of any kind, and poor security practices still make loads of money and are extremely successful so it's all a waste of time.
I detest this idea and I refuse to work like that anymore. But I also think he's right :(8 -
What do you think of pair programming?
Does it automatically allow for (much) higher quality code?
Is there truth and practicality in it?
Have you applied this in your company?
I think it's a bit of a dogma and its benefits depend on whom you're working with. Sometimes two incompatible people will waste each other's time, or a person who works much better alone will instead work in a worse manner.
I know for a fact there are colleagues (including myself) who can't stand it when someone else is looking at their screen.
source:
http://extremeprogramming.org/rules...13 -
So just saw an email from our team's vice manager about need to improve code quality by using some new system.
Well that set me off on a huge rant about all the issues I see in my team and what exactly needs to change... (just some new sytem he's pushing isnt going to help)
wonder if i might get fired... even though i m right...
And so much for my plan to update docs... I've forgot what I wanted to do...2 -
Commit functional changes separately to code quality changes
Otherwise I'll make you do it all over again 😤 -
!rant
when you find 3 spelling errors in the same line of code and realize that these are legit 'cause the objects and methods are actually coded misspelled.
That's when no one dare doing code review but simply it builds and its fine.
Luckily #NotMyCode -
A: Hey yo, that function should only support up to 20 objects
B: Say no more fam
https://api.flutter.dev/flutter/...16 -
One day a week should be for improving the quality of the code, not just bugfixing and rushed implementation of new features.
-
How seriously do you take TDD, CI/CD, automated testing, clean commits, good architecture, Agile, low coupling/high cohesion, etc ... ?
How much time do you invest in those things if you have a deadline up ahead?
Have you seen these things being valued or disregarded at the previous companies you worked for?17 -
Start the reading of "clean code".
First thing that i have learn "The only valid measurement of code quality: WTFs/minutes".
What do you think about it ? Agree or not ? -
I read this rant on Quora. Is this true ?
“The IT industry has devolved into a gigantic ponzi scam built on exploitation and BS. Quality of solution and quality of work was replaced with a ‘Does it work now?’ approach with zero contingency.
And the fact that geeks and nerds are naive only helps the white collar crooks to exploit them as code monkeys.”9 -
Them: Maintaing code quality is a vital part of our team culture!
Me: Really, how important? Can a feature slip to facilitate necessary refactoring?
Them: Well no. We've made a commitment to the client.
Me: So, code quality is not very important then is it... -
Fixed a high priority bug today just prior to release. There was 100% test coverage. The tests pass both before and after the change. The product behavior is correct now where it wasn't before. Just one more reminder that test coverage does not equate to either quality or correctness. Tests are alarms (at best), and quality of tests are no better an any chunk of code. All tests have costs, but not all have value. All reasons why I am skeptical of the value of code coverage, TDD, or anything that posits that "all tests are good".6
-
I used to love my job, the guy that looked forward to mondays, there was always something new to learn, I was passionate about clean code and learning new languages like Elixir. As a software engineer I thought my occupation had a special significance in this world, I saw possibility and potential of creating something so impactful on the world that it would become my legacy.
Now after 5 years I’m realising that none of this stuff really matters to the world, software engineers aren’t special and it’s evident from our salaries how valuable we are compared to other professions in sales, medicine or law. My friend who works as in customer success management makes more than me.
While some of us will be in the lucky few whose work will change the world, most of us will just be another cog in the wheel, all that matters is how many product/features you ship out, nobody gives a shit about code quality, concurrency and architecture design other than us5 -
!rant
So this has probably been asked loads of times but I've never seen it. When working on solo projects for yourself do you still use source control like git or mercurial?
I usually don't because when I do personal projects its usually filthy and fast development to prototype quickly.
However, this current project I'm working on I am using git and I'm finding that slowing myself down just to follow good practice is actually improving my code quality and my understanding of my own project.14 -
!rant
I've always been wondering why do tech companies need everyone to have a strong grasp of algos and data structures?
I've been coding most of my life but didn't get a CS degree so ended up in IT but I kind of want to get into a tech company as my thinking is the quality of code much higher (I spend a lot of time cleaning up other people's code and prod issues over the years...), I've been learning Algo/DS but when I see those technical questions on CareerCup, I go WTF.... it's this the kind of problems you guys do every day?6 -
I need guidance about my current situation.
I am perfectionist believing in OOP, preventing memory leak in advance, following clean code, best practices, constantly learning about new libraries to reduce custom implementation & improve efficiency.
So even a single bad variable name can trigger my nerves.
I am currently working in a half billion $ IT service company on a maintenance project of 8 year old Android app of security domain product of 1 of the top enterprise company of the world, which sold it to the many leading companies in the world in Govt service, banking, insurance sectors.
It's code quality is such a bad that I get panic attacks & nightmares daily.
Issues are like
- No apk obfuscation, source's everything is openbook, anybody can just unzip apk & open it in Android Studio to see the source.
- logs everywhere about method name invoked,
- static IV & salt for encryption.
- thousands of line code in God classes.
- Irrelevant method names compared to it's functionality.
- Even single item having list takes 2-3 seconds to load
- Lag in navigation between different features' screens.
- For even single thing like different dimension values for different density whole 100+ lines separate layout files for 6 types of densities are written.
- No modularized packages, every class is in single package & there are around 100+ classes.
Owner of the code, my team lead, is too terrified to change even single thing as he don't have coding maturity & no understanding of memory leak, clean code, OOP, in short typical IT 'service' company mentality.
Client is ill-informed or cost-cutting centric so no code review done by them in 8 years.
Feeling much frustrated as I can see it's like a bomb is waiting to blast anytime when some blackhat cracker will take advantage of this.
Need suggestions about this to tackle the situation.10 -
Following my first rant, my boss had the brilliant idea of running the old and the new architecture in parallel. I had advised that it won’t be ideal since the same Scala code was ingesting into 2 different Kinesis streams and one was running an old KCL written in Java where as other was consumed by a Firehose delivery stream(eventually we will be ingesting it into Firehose directly). I had told few manual + automated tests on Code as well as from a functionality of the new architecture and a set of tests for checking the integration of the new Producer code with Consumer.
The statement I got from my boss was “This is the test, we test it on production in parallel”. My boss had a brilliant idea to fucking test the new code on the production directly but running them in parallel without accounting for undefined behaviour it might cause in the current production system. I mean my boss should get a Nobel peace prize for shattering our mental peace.
Anywho, we started the deployment today at 5AM in the morning. I had all the aws services deployed. Was just waiting to deploy the new Collector code which we did at 5AM. Immediately after 5 minutes the system went bonkers, there was fire, blood, demons and I was smoking a cigarette with the biggest “I told you so smile” on my face. I’ve just written an email to my boss and have told him calmly that “Listen motherfucker, 90 percent of the software companies aren’t idiots to focus on testing and quality. We need to start spending time on testing and quality else we’ll again be in the same soup after few weeks again”.waiting for his reply1 -
I felt so good after revisiting a project and everything runs ok
Code readable
Managed to pick off where I left off and fixed some existing bugs
Added new features and uploaded the update2 -
Stakeholders must learn that code quality and a user-friendly frontend are not "nice to have". If they don't fix their priorities accordingly, someone will have to pay their technical debt and that's going to be expensive.5
-
That feeling when the code in a massive PR is of very high quality... Only comment is about some class name...1
-
If the codebase quality drops below levels measurable by way of "WTFs per minute", determine further negative code quality by counting the amount of times per hour you wonder if you're in Hell and what exactly you did to deserve this torment
-
Wk33:
Best experience of 2016 is probably just realising I'm a pretty good programmer. I have a physics undergraduate degree and a 1 year masters in CS, I'm working on back end algorithm stuff so pretty mathsy at times, but I've found from working with others that I write good quality code. I've still got lots to learn but I've got a solid foundation, am reading, learning and coding outside of work.
Worst experience of 2016 is working with people for whom it's purely a day job, only about the money, get things done in whatever hacky way works.10 -
The quality you perceive your code to be 6 months after writing it is inversely proportional to the quality you perceived it to be when you wrote it.10
-
generally, the quality of code is inversely proportional to the number of public booleans
thing.IsThatTypeOfThing
thing.IsAVerySpecificTypeOfThatThing
thing.CanDoSomething
thing.EnableSomething
apparently that's where we're heading now :/ -
I was thinking about the problems one of our clients faced with the launch of their project the other day, because things were rushed, stuff was omitted and in the end they could not meet the launch date, and I started making a list of hard lessons I learned over the years that would have helped them avoid this situation.
Feel free to add yours in the comments.
- Never deploy on Friday
- Never make infrastructure changes right before a launch
- Always have backups. Always!
- Version control is never optional
- A missed deadline is better than a failed launch
- If everything is urgent, nothing is important
- Fast and cheap, cheap and quality, quality and fast. Only one pair at a time can be achieved
- Never rush the start or the end of a project
- Stability is always better that speed
- Make technical decisions based on the needs of the project two years from now
- Code like you will be the only maintainor of the project two years from now. You probably will...
- Always test before you deploy
- You can never have too many backups (see above)
- Code without documentation is a tool without instructions
- Free or famous does not necessarily mean useful or good
- If you need multiple sentences to explain a method, you should probably refactor
- If your logic is checked beforehand, writing the code becomes way easier
- Never assume you understand a request the first time around. Always follow up and confirm
There are many more that should be on this list, but this is what came to mind now.2 -
So I was rejected by the management today for promotion to Senior 2 although I have done several major feature developments + infra design and basically end to end ownership.
Reason for no promotion? That's the best fucking part, according to the feedback, the work I performed on the service I created is well-designed,
and the code quality is commendable. However, they pointed out a notable difference in code quality between the micro-service
I built and the rest of the project developed by others. This, apparently, suggests that I lack a strong sense of ownership over the broader product.
First of all, we have super tight deadlines (almost 996), and I burned midnight oil to make sure the service I am in-charge of is designed really well.
Also, how in the flying fuck the other how the inability of others to maintain good code quality elsewhere in the product is being used as evidence against my sense of ownership
and initiative in ensuring high engineering quality for the repository I wasn't even working on
What a delusional management, the entire feedback feels like just an excuse to fuck off, we are not promoting you...
May be instead of doing actual engineering work, I should have just do minimal work and write more design docs / technical artifacts
It is very demoralizing after I worked hard for so many months, product went out really well.. yet when performance review comes, rejected with a petty reason7 -
I've realized that what I once thought of as a glamorous job is really no different than any other. Speed and quantity is praised over quality and adoration is never received. Prestige is as much dependent on who you know than your code.
Maybe I'm just jaded.1 -
dev: ugh we need to set and implement coding standards
same dev: no I don't need to follow what you just said, it's already clean and readable (it's not) -
"Whenever there is a decline in quality of code and rise of bugs and errors oh dear coder, I manifest to show the path of bug and error free coding" said code-god
- Chapter 1 Verse 1, Code Gita -
So in our last retros some of my colleagues suggested to (forced) limit the number of lines per method in order to "maximize our code quality".
In the one hand I can see the benefits of this, such as easier testability when having more sperate testable blocks of logic.
But on the other side their code contains lots of such one or two lines private methods which get most of the cases not more than one time called. (And which I then can't even test separately)
I don't understand how this should help...
Is this really a thing? Am I just not "clean" enough?
(it's c# btw)3 -
I love how our industry has invented such important sounding yet meaningless job titles...
Developer, software engineer, software architect, developer evangelist, dev ops engineer, systems analyst, quality assurance engineer, code monkey...4 -
Quality != more work + less talk
Quality = more talk resulting in less work.
That makes no sense mathematically.
“Let’s talk more about shit before we create shit”.
That’s a little better.
“Let’s talk more so we don’t create shit”.
Getting closer.
“Let’s talk more about what is needed till we all know what is best before we program a damn machine?”
...This is going nowhere fast.
Okay fuck it. Let’s just code some stuff. It’s more enjoyable.7 -
So we have a confluence page all about best practices (there’s not even a lot in it) but when you check the repository, most rules are not followed 😭4
-
We have all experienced inheriting a project and crying because of quality of coding. Somehow the project works but you can't explain how.
I guess I will not blame the previous developer. I guess in most cases it's the teacher who teaches that horrible method of coding.
I may be a self taught developer. But I can gladly say that I know how to code. However I can't say the same about my professor. Who makes you add percentage based margins and paddings (CSS) And make a fluid layout calling it responsive.
Fuck you Professor.1 -
The code of conduct is a good thing. It doesn't persecute cis white men. All it does is tell you not to harass people on the basis of traits they cannot control. You say you only care about code quality and nothing else? There's a whole untapped market of talent from women and lgbtq+ people who stay the fuck away because of toxic communities. When you call people faggot it makes them not want to contribute to your codebase.
Linus stepped down of his own volition to try to become a more constructive voice. Heaven forbid the assholes have some introspection.
Hate it because it's vague. Hate it because it means anyone can be banned without evidence. Don't hate it because the assholes are finally being called on their bullshit.11 -
The cool feeling when you see your static analyzer that compare previous version and future release and code quality is improved.
At the same time the bad feeling because you was the same dev that made the previous version. -
Reading code takes time!
Everytime I read:
"var" or "auto" Add: 10s
- Just use the type
Everytime I read:
if(Expression1 && Expression() ? GetNumber() : 0 > 0) Add: 30s
- Just write two if statements or create two bools the line above.
Everytime I read:
delegate = () => {} Add another 5 minutes of reading time.
- Just write a separate function for it. It helps with searching and understand what it does
Please code like the person that needs to check your code or change it just knows basic coding skills and logics.
I do know all these concepts I just never use them because it makes the code unreadable. hard to follow, mistakes that can happen everywhere. difficult to search.
And it frustrates that I need to read 10 extra lines to understand code flow or hover my mouse in an IDE to figure out what type object it is.
It's properly just me... I just like clean readable code. that is logical and failsafe and strict and deterministic with its behavior9 -
I was watching this fantastic talk on coding through refactoring:
https://m.youtube.com/watch/...
Highly recommended....
And it got me all enthusiastic about coding again and then I realised, at my last work place, the "we value code quality" corporate hellhole you'd be criticised for taking too long by management and for changing too much code by coworkers.
And a month later, you'd come back to the code and some other coworker would have jammed in a bunch of extra if statements and absolutely fucked your nice structure....1 -
- finish that ML course I started back in June 2017
- get more experience from my job
- improve my code quality even better.
- build some cool project in Java ( there's this company I need to impress, but I haven't found any good idea to implemen 😣)
- be more active on Hackerrank
- do some stuff here and there
- use that freaking LinkedIn to create some meaningful connections
- contribute to an open source project
Hmmm ...
... yeah that's a lot ... *sigh*7 -
I wanted to deploy the code of the project I'm working on on the test server to try something.
The code wasn't deployed because the automatic quality inspector detected some methods used are deprecated. So I check the documentation of the methods used. The method is a pass-by to avoid some errors launched by the automatic quality inspector.
So the quality inspector stopped my deployment because I used something that should stop the quality inspector provoking errors.
god dammit5 -
Customer: The quality of the software you’re delivering is going down
Me: That’s because we’re developers, support, and spend all day on meetings without mentioning that deadlines are defined by you, not the technical team
Project Manager: I have added more members to the team so you can deliver faster
Me: That’s just slowing us down because this inherited code is shit, there’s no documentation and we’re always in a rush, without time for a proper ramp up
Customer: *throws money to our faces* I’ll remove two weeks to this delivery so we can test it better
Me: …1 -
I just submitted my professional goals this year.
As I was writing them a lot of them actually sound like things my manager should be doing to increase code quality n agility n reduce the # bugs that end up in prod... -
When I have bad day and I doubt in quality of my code and my skills overall I open another project that is backbone of company business and I immediately feel much better after seeing what crap others produce.
-
I want to code something today but don't want to get into it then have visitors show up.... Now I'm downloading Christmas music (FLAC in highest quality possible of course) and just browsing reddit.2
-
One thing that is really difficult is when you are writing let's say C code for months, and then you switch to C# or Python, you immediately use C-style logic and forgo the easier, shorter Python syntax!
I did a python kata on the Codewars website. After submitting it, I realized my solution was like 10x longer than every other solution. Talking about hand in face.
Stuck to basics and forgot about Python's amazing shortcuts. What are you going to do!1 -
...is that someone who finds some, let's say, questionable quality code that I've written in previous roles, finds me again and calls me out on it...
-
Teach students the importance of clean code/architecture and testing. Even if they dont yet understand the more complex topics such as architecture, they should understand why quality is important and that software is a craft more than a science. You cant just apply principle X and insert design pattern Y and profit++. You actually have to think and constantly improve. AND TEST.
Think I would probably also cover things like build automation and continuous delivery. These are now important things for junior devs to know about going into companies. -
I am still confused why people treat testing as secondary position? Tester are paid less and they hire lower quality engineers. I think testing is as important as any other phase of development, like design or implementation. . . and yeah we do testing of our own code. The only thing I can do in my case is to see that people who change my code may not break basic functionalities. And again about edge cases, try to handle some other left to be seen in production( those which I could not think of due to lack of time) I take care not to leave edge case but sometime cannot do it. I just hope people realise the worth of testing.1
-
Fixing out of scope/unrelated code quality issues when working on bugs/features.
Especially with older projects where pretty much the entire code base is a quality issue.1 -
You all enjoying and excited being coding until someone asks you to test your code and care about code quality6
-
The key to any good relationship is compromise. Ladies and Gentlemen, allow me to introduce the 2-4-tab alternating space indent style!
if (x) {
somemethod();
}
else if (y)
{
someOtherMethod();
} else {
iDontKnowHowToTabOnAndroidMethod();
}5 -
Your code quality is pajeet tier.
You consistently make poor design and architectural choices.
Your project has maintained 50 plus unresolved bugs for about 6 months, and yet you're consistently under delivering against what you commit to.
Other developers refuse to work with you.
So tell me again how you feel you're an effective lead developer5 -
My coworker had to face this one: When SonarQube shows you 50 years of technical debt within 1.5 million lines of code from someone else and you have to fix the worst.
#FeatureDrivenDevelopment -
!rant
So I'm making the system for my University's cafeteria.
Pretty ez and all but THIS FUCKING PAGE, THIS GOD FORSAKEN PAGE JUST BUGS.
I'll elaborate: Basically I have a bunch of pages that bring up some pie charts and a .pdf of earnings, all of them work and they are pretty much cookie cutter so I can re-use the code. But this random one, with the same code, repeats the same entry a couple of times.
And by god have I tried to change every variable, code format and minimal shit. Still doesn't budge.
Guess I'll have a cheeky ciggy break and try to fix it later when I'm not steaming my noggin
Ps: yeah yeah, shitty jpg quality but its the "Busca Unidade" field that just cloned itself 7 more times underneath -
Found this in a book and i can tell you that wtfs/min is the most effective code quality measurement technique programmers have known to this day! xD
(Book: Clean code Robert C.Martin)4 -
In my current job, I was let go of the project I was handling for almost two years in place for a new hire with less experience. The reason is that I got complacent while sacrificing code quality as more similar tasks were assigned. I'm glad it happened and grateful for all the code practices I've learned. Transferring to a new project with the same client though. 😂1
-
We only recently started and we can really see the benefits of code review.
It motivates you to follow the standards, writing good quality code and using variable/function names that makes sense. Especially that you know someone is going to read through it.1 -
I always wanted to post something under the devrant tag.
I've worked on the anti spam bots! End result: one process handling four bots that down votes users with a low upvote count having certain content. What that certain content is, is still to be defined / fine tuned. Now it has very minimal criteria but it did successfully flag all spam posts tonight. Down vote function is not ready yet - I did not know what value to post. Probably @feuerherz / @Lensflare can provide that to me.
Not my best source ever, it's made quite quickly and it literally started with c/p-ing stuff from everywhere like several devrant clients on github to make one complete one. They all sucked :P
I hope to finish this project tomorrow night and it will be then of spam as far as I've seen how effective they are.
This is the source code: https://retoor.molodetz.nl/retoor/...
Review regarding code quality isn't needed for this one, since I've spent zero effort regarding quality. But tips about how to recognize scammers even better is highly appreciated. A review on other projects on molodetz would be appreciated btw, especially on C stuff.
I go sleepii16 -
I'm not really active here recently but thought it would be nice to share a cool website I ran into: https://refactoring.guru/design-pat...
Imo every developer who aspires to be more professional should have it in its bookmarks and ocassionally look into it when facing a code design dilema. -
"Always program as if someone who has to work with your code is a violent psychopath who knows where you live."
-
I am just student looking for job, and got this pre interview test:
Develop an Android or iOS app with login and password input field, download button, place for image we prvided.
... reading further:
What we are looking for in the code ?
internal quality:
-consistent formatting of the source code
-clean, robust code without smells
-consistent abstractions and logical overall structure
-no cyclic dependencies
-code organized in meaningful layers
-low coupling and high cohesion
-descriptive and intention-revealing names of packages, classes, methods etc.
-single small functions that do one thing
-truly object-oriented design with proper encapsulation, sticking to DRY and SOLID principles, without procedural anti-patterns
-lots of bonus points for advanced techniques like design patterns, dependency injection, design by contract and especially unit (or even functional or integration) tests
external quality:
-the app should be fully functional, with every state, user input, boundary condition etc. taken care of (although this app is indeed very small, treat it as a part of big production-ready project)
-the app should correctly handle screen orientation changes, device resources and permissions, incoming calls, network connection issues, being pushed to the background, signing deal with the devil :D and other platform intricacies and should recover from these events gracefully
-lowest API level is not defined - use what you think is reasonable in these days
-bonus points if the app interacts with the user in an informative and helpful way
-bonus points for nice looks - use a clean, simple yet effective layout and design
... I mean really ? and they give me like 2 days ?4 -
Performing code review for design quality.
So you return HTTP code 200 for 'ok'. So what do you return when things are not 'ok'?
Obviously something that's not 200. Like 300 (The message with the code was literally "not okay").1 -
I'm not too proud of it but.... https://github.com/PythonTryHard/...
It's garbo, especially on code quality but it's my coolest piece of garbo9 -
Someone has to start manufacturing quality HUD glasses...
Imagine the possibilities and comfort...
no more neckpain from crouching above your laptop/tablet/smartphone, imagine the navigation systems, imagine you could read messages, articles, code, watch videos whatever you are doing, even work on your code with some kind of keyboard (or with speech recognition)
I want this soo bad..3 -
Continuing to learn k8s ecosystem and to achieve acceptable level
With trying eventually Helm, Argo CD and even trying to use not managed setup for k8s.
Going though books to find out theory about being SRE.
And about data intensive apps.
Learning and trying Kafka
Learning and trying FastAPI and diving in generally to async python ecosystem
Learning Go.
Learning few more books to increase code quality and its compositioning.
Getting more practice in monitoring and logging systems with applicating them to k8s.3 -
How do you usually divide the commits?
I'm a student and I would like to know your coding preferences at both work and your personal projects. Do you prefer to commit almost fully coded classes or you just rapid-fire all the functions you finished?7 -
Over the last few weeks, I've learned two things about the head of my division:
1. They "don't care about code quality"
2. They want to try a "low-code" approach for the web frontend of a completely custom piece of what is currently desktop software
This is despite the fact that we have three full time developers with a wide range of both front and back end skills on the payroll, a deep library of existing components for various frontend frameworks, a custom CSS library, and a decent deployment pipeline for frontend code.
But sure, let's try low-code. Let's see how far that gets us. -
We have decent linting on our codebase which covers off code quality and style.
We also have a developer who insists on making code reviews about formatting and spacing rather than functionality even tho we've tried in multiple ways to say:
- our linting covers it, if that's happy we should be (and the rest of the team is)
- it's a waste of time doing it
- it wastes the time of the team reading it
- the noise it generates makes it hard to see any legit comments
I swear to god if I see another comment saying "new line" i will scream. -
It's frustrating when you tell your teammate after code review that they have to rework their code a bit to capture certain scenarios they've missed and they just scowl at you.
I'm just trying to make it easier for us in the long run! -
I am fairly new to "enterprise" programming, but have some experience with self-study and open source. I'm getting more frustrated by the day because the code quality of our software is appallingly bad: functionality that should be centralised isn't, assumptions about internal structures and functionality of objects are made throughout the code, concerns are not separated, and so on. In my current team, we explicitly disabled SonarQube because "someone would have to fix it and our software wouldn't pass even after a month of work".
While I understand the concerns that companies would rather see new features than "quality improvements", so what? Every time we want to add something, we either have to restructure half the source code or add it in a really horrible way (and get pressured to do it that way).
Is it normal that code quality in companies is so bad?10 -
Upper management has a huge meeting and decides NOT to merge in buggy or incomplete or untested code just because it's the due date (you know, quality over quantity? And an attempt to cut back PM's unrealistic expectations)
2 sprints later: "So we're going to go ahead with the merge. Yes, we know the feature isn't complete, but we promised blah blah blah"
So much for that <.<;;1 -
I took a project. Wild mix of php and html including db stuff and data processing. About 200 files, some 3000+ lines long with if else cases processed in another template/logic behemoth...
I wrote a js file included it at the footer of the monster and update dom + data via ajax on my own api implementation because I'm too afraid to write in any of those files.
I've been told its quality code and well documented3 -
I just found a class in the codebase which was named "Ariadne". Coz it was responsible for holding the information of where you are on the site wrt the homepage. Talk about giving meaningful names. There was no other documentation whatsoever. You know you've serious code quality issues when you expect fellow developers to know entire stories from Greek mythology to understand the code.1
-
Hi all!
There are four devrant clients (in the famous list, awesome devRant) regarding Python but they're all bad quality or incomplete.
So, I exported the asyncio api client that I made for my bot to his own package called devranta. The a in the end stands for async.
Source code and pre-build packages can be found here: https://retoor.molodetz.nl/retoor/...
By my knowledge, this is the most complete and highest quality Python client out there.
I hope someone will use it someday.
I keep just continuing building projects use or not as portfolio content. Also, i needed this client for another project. I want to make a bot that auto-corrects my English. Only the typo's / grammar will be fixed. They will remain my own sentences. So most texts won't be updated at all. It doesn't rewrite my texts. I created a web service for correcting English for that, i'll release that soon. Some minor fixes left.
Still have to add types and such for all my
python related projects. I consider them useless. Terrible to spend time on.18 -
I cannot write my shopping list on paper anymore. I'm unable to sort it alphabetically, refactor it, group the items by theme...
-
I think there’s a correlation between my code quality and listening to A Tribe Called Quest. It’s weird. Everything time I put them on I make great code 🤷♂️
-
Does the perfect codebase exist? Or is it just a myth?
PS. I'm just a new grad with ~3 years of experience, and in my 4th company now.10 -
I guess it's my third or the fourth company that am currently changing.
I have the will to improve and write better code quality level up. But sometimes i guess i have the lack to find the how to do these stuff and how to practice and who is going to tell me that i have to change these lines of code so you can improve am just in a big mess and i feel so bad about it.
Now i had just received a new warning at my current company that i either improve or i get fired. So i have been searching over google and internet how to improve as well i had just created a new project for the will to practice and become better.
Can someone tell me what i should do?
How to fix everything and let my colleagues gain my trust in my code commits ?
Because literally i feel so bad about everything and you can't imagine how miserable i feel.3 -
!rant about WordPress
I came across a rant about WordPress this morning. Whatever the quality of the code, there is a lot of good that has come from WordPress.
For a substantial number of people, it has made it possible for them to create their own spaces on the Web that they can use to express themselves, build businesses, and share their lives.
Remember that WordPress arrived at a time when you basically had to use a few large blog services if you wanted your own site. It wasn't perfect then (and isn't now) but WordPress did a lot to democratize the Web.1 -
Program seems to work better when there is about 2-3 times the amount of code related to error handling the task than just the task. I'm always glad to see quality stuff that accounts for the edge cases especially with helpful error messages.1
-
It's kind of depressing looking at how bad the source code has transformed from a previous project that I had planned, designed, and did the initial implementation.
But I guess this is the problem of having developers who don't really care about the quality of their work, especially when it comes to PHP. -
You can be very good at writing algorithms and good quality code, but if your architecture is garbage, you'll be doing hacky fixes and end up with a spaghetti code.3
-
What's the point of using TypeScript if you type all of your code with `any` or worst part is you don't provide any types!?
P.S
If you're anti-typescript or any static linting tool, I know this will not prevent any runtime errors, but this is part of the testing/code quality. My teammates do not care for quality, and I'm tired of it.2 -
Damnit onion, this is a little on the nose. But hey, code complete is always worth reading.
https://theonion.com/hopefully-neig... -
Best way to measure code quality is by using wtfps method. Less "what the fu#*s per second" you get, better the code is.
-
- Lead: we need an iteration of 3 weeks to stabilize our code (bugs, code quality, ...)
- Manager: ok go ahead
- Lead: cool thank
3 weeks later one day before the end of the iteration :
- Manager: are you ready for the demo ?
- Lead: ...
- Manager: I invited the boss and the clients
- Lead: ...
We are discussing what to show them.5 -
I'm mostly self-taught, but there are a couple people who defined my understanding of computing
- My amazing elementary school friend whose father worked at IBM and who initially turned my interest from astrophysics towards computing. I don't know whether physics would've been fruitful but I know computing is.
- My high school friend, who taught me the basics of OOP. Though we agree on almost nothing today, his explanations about code quality defined my understanding of the matter which I then used to draw completely different conclusions
- My high school mathematics teachers, who tolerated the way I abused every tool at my disposal to construct proofs that resembled a rollercoaster, and helped me develop my own understanding of mathematics
- 3blue1brown for producing replayable videos in a similar quality to my high school maths lectures with additional stunning visuals. No content on the internet fits the way I think quite as much as that channel. -
Some programmer or QA person somewhere in the world is having a moment of great reflection on the subject of thoroughly testing their code. If not that, then on the subject of a super crappy manager who knew better and pushed to production anyway.
“Then in September this year, nearly three years later, he got a letter from Wells Fargo. "Dear Jose Aguilar," it read, "We made a mistake… we're sorry." It said the decision on his loan modification was based "on a faulty calculation" and his loan "should have been" approved.
"It's just like, 'Are you serious? Are you kidding me?' Like they destroyed my kids' life and my life, and now you want me to – 'We're sorry?'"
https://cbsnews.com/news/... -
What are you supposed to do in an environment where your peers can't take criticism on the code and their approach to problem solving? They like to take shortcuts which end of making the software less maintainable. Is it worth to convince them to use best practices and be labeled as a bad guy who keeps on ranting about stuff they don't understand?2
-
!rant
What font size do you normally use for programming?
I've been using 12-14px for years, but I switched to 16px for the last couple of hours. Feels weird but I kinda like it.
Sure, you do lose some real estate but it feels like it's way easier for the eyes. Less physical strain == less mental strain, which in turn makes for higher quality code.
Also, selecting stuff is more satisfying, but that's probably just me since I'm weird ( ͡° ͜ʖ ͡°)
Any thoughts?4 -
Studied applied physics and electro engineering for 3years since I'm a stubborn idiot, went shit. Had my first code course in C and knew that I had to change education. Life quality increased by a factor of 10 for me. And I haven't looked back ever since.
-
If you were to work on pure JavaScript code for local and web development, what IDE would you use? Not a quality question, I'm looking for personal opinions mainly.9
-
After the American mass layoffs, Silicon Valley software is getting worse in a worse way than it used to, maybe also due to AI generated code and content, especially Google product quality keeps dropping continuously. I am afraid I will have to switch to Apple eventually2
-
Spent 30minutes trying to find What was wrong in my Bootstrap code because some things didn't appear on my screen (grey background, lines).
Turns out it was because of the crap quality of my second monitor. -
Fuck, I can't stand ppl who brag about learning new languages when they can't produce quality code in their work language, and dont know any other rules than few basic ones that you learn at the beginning of being a programmer. Go kill yourselves, thanks1
-
doing documentation in word and having meetings about it, code reviews where people say great code quality with all good practices but... we would like to do it differently, reasons? less lines of code but real reason is not understanding design patterns, also 6 levels of hierarchy and wasted effort to prove that approach is good and considered as good practice just to be changed by someone who doesn't write code anymore. Decisions that other approach is better because they did it that way 10 years ago on last project where they were developers on totally different tech stack. dear friends, welcome to corporation!1
-
Continuos Integration and Code Quality Systems should work automatically...fucking Jenkins need me all the time. Arrrgh!😠
-
My advice would be to have fun with coding and make things that you like. Consider all other job fields. Only work in programming if it makes you fulfilled and gives you good memories looking back. If you do work as a dev, be passionate about making the code and projects beautiful and high quality. Search for mentorship from developers you admire.
-
Fuck Swift. Such a garbage language. The last 3 days I tried multiple web server implemented in Swift for mocking API's and none of them worked. Old, not maintained, wrong documentation, wrong code examples and just low quality shit.
Finally I decided to not give a crap and move to use Wiremock and it works out of the box, start and configuration is a breeze and it just plainly works. I should have done that from the beginning.
Btw., as a warning these were the frameworks I used and you should avoid them if possible: Swifter, Embassy, Ambassador and Succulent.1 -
Some magic happened about situation talked in earlier rant at below link.
https://devrant.com/rants/2910513/...
Now magically even before I inform about this situation directly to the client, now after 8 years they used some proprietary static code analyzer on latest app source & found out around 200+ security issues which covers most pain points I told in the above rant.
I also found out that there is a list of 100+ vulnerabilities documented in client doc repo, which were pending since around 5-6 years.
Now I have to work along my junior to fix these both kind of issues.
Suddenly dull maintenance project became much challenging & interesting. :-) -
Just a warning to Web Dev's out there. My university has taken to marking our web coursework by "machine marking".
The necessary steps to getting full marks? Upload files with the specified name and extension and voila! No need to worry about code quality or whether it works. Full Marks!
Misspelled a single file name? Straight 0.
Nothing. -
I am planing to create a reading list for technical books and am looking for recommendations.
Currently I have:
- Spark: The definitive Guide (need it for a university project)
- Clean Code
- Clean Architecture
- Functional Programming, simplified (or any other beginner-friendly book about FP)
Do you have any recommendations and must-reads for a more junior developer? I am looking for stuff about FP, Code Quality, Java, Python, Scala, and any general interesting technical stuff.3 -
In our class we have one subject where we take notes on one shared Google docs document. To be honest, this may be the worst "teamwork" that I every had to deal with.
• Simply copying the stuff from the blackboard:
• Missing context
• document consists of keywords and occasional sentences
• These fucking deep nested lists
• No quality control whatsoever
--> nobody fucking cares
• What, nobody made notes for this point?
• Any attempt to speak up result in me being scolded
• Be me, the only one not shopping on amazon instead of taking notes
• Wtf does this mean, where's the context
• one line of code without needed context code
No quality, no Motivation, no better alternatives, no fun. -
Working as a Dev for a while now, I tell new people not to bother with it. There is never any job satisfaction as people in charge never understand the basics.
Instead of learning to write efficient code, figure out how to solve real business problems, work towards a maintainable flexible product to quickly deliver value on changing requirements, write automated tests to improve quality, maintainability and prevent live issues - basically do anything a good Dev strives for - you will just constantly end up working for people with no interest beyond the next couple days, on a shit code base that no one can understand, with people that don't want to learn anything about software design and just check boxes off.
Apart from pay this must be the worst career possible in a technical field.4 -
In your opinion, is it better to work in a dedicated development company (or otherwise dedicated to your IT specialization) or be in-house?
I'm currently one of 2 in-house devs for a small enterprise. So my software engineering practices and code won't be of the highest quality but at this early stage of my career I'm gaining experience in various different aspects of the job and doing many individual different things. So overall I'd say being in-house is good early on for initial exposure, so long as you have a mentor to help you out. -
Holy shit, writing code is fun again. Isn't it nice when things actually work for a change, and you can focus on code quality and improvements?
Hard work pays off. -
Isn't it stupid that authors of research work are never vetted for the quality/correctness of their implementation? The code gives them all their cool results and fancy graphs, right?
-
What I just had to learn again, if you are the one who brings in (quality) standards in group tasks (like everybody does his stuff until day x, specify image sources, not only Wikipedia Copy & Paste), you are with a 95% probability also the one who more or less works alone on it at the end.
(Works the same with group coding projects where the one person in your group that's able to code relies on you doing most of the work because that person is lazy playing games) -
Has anyone ever resumed at a new place and was impressed by the code inherited from their predecessor? If yes, did you see any need to communicate this information to the admin or the superiors he left behind?
For as long as I delved into code quality, I've taken great pride in my work and have been enthusiastic to show it off to anyone who cares to listen. I'm morbidly afraid of a colleague berating my work over something I didn't do correctly or don't know. But none of those I've worked with have that kind of time for pedagogy. The only thing I've witnessed them care about is how much your code breaks, to what extent your endpoints break, etc
Does this make code quality practically an overrated metric? All your fancy oop patterns and clever algorithms or business logic basically goes unnoticed. The business cares about output and your colleagues are more concerned about implementing their deliverables.
Is this just my experience or a more general situation of things?7 -
Anyone know any nice code quality tools/bug finders (besides find-bugs) plugins for Intellij IDEA?2
-
When doing a project from scratch, what would you prefer?
Code Quality + Time = Product
Bad Code Quality + Les Time = Product7 -
There's so much money in technology right now and so much easy success ... and so much poor quality code that is good enough ... that people can not only "function" in rolls they aren't qualified for ... but can excel and even be promoted through the ranks without ever becoming actually functional.
-
Test your code. Take extra time to do self-review. It'll improve your code quality and position within your peers.
When you enter that "minor change-trial-error" phase. Go to sleep or take a long break. You're loosing time and adding more work to be reviewed and corrected later -
I was reading about Lumnify's project analysis (https://lumnify.com/project-analysi...) and now I'm curious about my own probably horrendous code quality and how to improve.
Time to learn about code quality and tools I can throw my work at and get analyses back to help me not suck1 -
My client wants great quality and time consuming code
And wants to pay least 😧😑
Defaq i still gonna do it but uh...2 -
{
-i won't follow logging practices
-i won't follow secure coding
-i won't leverage profiling n monitoring tools
-i won't reuse best practices
-i won't listen to thought leaders
-i will outsource writing UT
-i will outsource code quality checks
-i will outsource all testing
-i will ignore n overide CTO team
But I still want high stability, security n 4 9s availability. Just want it done. My team is best. Am a fast-track leadership program leader who never has or ever needs to cod. I just know ...
}
People I have to deal with every sprint. Site reliability is not easy ...
Teaching good code makes great products to morons, toughest ...
"Beginners mind needed"2 -
I'm super bored, but I think I found a good way to spend my time.
https://theitsloth.github.io/contex...
https://theitsloth.github.io/editor...
https://theitsloth.github.io/tabbed...
p.s. Code quality varies between meh and awful. -
This article about the types of legacy code bases you will have to deal with just made my day!
Not only do I have every one it describes but somehow it even made me laugh at thought of each of the std riddled petri dishes of code that I reluctantly maintain... My "Happy Place" is a folder dedicated to reliquary projects I like to look at when I feel sad to lift my spirits and restore hope that one day things will be better.
Do you have any definitions to add or know where to find more? I'm hooked.
Link: https://medium.com/@dylanbeattie/...
Excerpt:
The Reliquary
The reliquary is that one repository full of really good ideas. Clean code. Brilliant algorithms. The OpenID implementation that you optimised until it shone. Classes so beautifully designed and perfectly documented that they’d make a senior architect weep.
You remember the big rewrite? The project that was going to fix everything, only you never worked out how to actually launch the thing, or get any revenue from it? The reliquary is where you’ve preserved it, pickled in revision control like a fabulous museum specimen. A treasury of good code and good ideas; maybe even an entire codebase that was “a couple of weeks” away from shipping before somebody finally looked at the number of critical features the team had somehow forgotten to include and discovered — to everybody’s surprise — that validated XHTML, normalised data models and 95% test coverage are not actually features any of your end users cared about.
Like Buran or the Spruce Goose, the surviving artefacts stand as a testament to the quality of your engineering… and a poignant reminder of just how much fun engineers can have building high-quality stuff that nobody actually wants to use. -
I made a very obvious realization since the last time I rewrote Orchid; the 3 year project that has now become an eloquent documentation of my learning process; Types aren't free. Sure they're free at runtime, in fact the more you have the less the language has to work to separate values, but they generate significant cognitive load.
Oftentimes it's better to have one enum with 12 variants 3 of which are specific to a narrow case to be able to define operations for this enum once, than it is to have 3 distinct enums of 10, 11 and 8 variants respectively, and to have to define common operations (or the dispatch part anyway) thrice.
As for my previous observations about catchall abort acting like the new type abort, I still think that, and I still think that this is only justifiable if the number of invalid variants is low enough in every case that you can list all of them before the abort.4 -
Code comments are good and all, but there's a time and a place for them. They're more or less an opinionated free-form version of what code is doing.
In a library, they're good for documentation. However in a platform, it makes less sense. Especially one which is changing at quite a fast rate (though it has matured in recent months).
Dont get me wrong, we aren't doing wades of horrible, unintelligible code. We need to be sure of what happens when we call a function, so we make sure the signature is always correct.
def do_good_things(puppies): # "good things" is opinionated. Say what you're doing
"""give treats to puppies""" # doc string is wrong
pet(puppies)5 -
Can anyone suggest a good opensource or free app for dependency mapping?
I have a large monolithic django application with lot of apps and I want to study each app's imports and dependency. This also can help me remove cyclic dependencies.8 -
Do dev or engineer needs to know how the program works?. I mean that should they know about time and space complexity?
Till now my answer is yes, they should know. But i have met more than triple Dev's with absolutely no knowledge of complexity and they all are behind code quality.6 -
I've just received a merge request for a feature that we outsourced. How do you best deal with substandard quality?
It's a merge request for roughly 2k lines of code and I've already noted down 25 comments and I'm only at my first file :(4 -
Me: By mandating code coverage pct. (very high ones) and integration test coverage pct. you are building an ever growing Rube Goldberg machine that you will end up spending most of your time fixing rather than working on the actual product.
Them: (Staring and whispering in the background). Wow, you must be stupid. This is how you created quality software.
...time passes and now most time is sucked into figuring out why all branches have failing integration tests all the time.
Me: I told you so. I've seen it multiple times. How about doing it differently?
Them: (staring and whispering in background). You are stupid. This is exactly how quality software is built. We know what we are doing. You must like waterfall.4 -
Whatever it costs to improve myself and my coding skills, to be honest.
So guys suggest your favorite way to improve and enhance your code quality.4 -
Recently joined new Android app (product) based project & got source code of existing prod app version.
Product source code must be easy to understand so that it could be supported for long term. In contrast to that, existing source structure is much difficult to understand.
Package structure is flat only 3 packages ui, service, utils. No module based grouped classes.
No memory release is done. So on each screen launch new memory leaks keep going on & on.
Too much duplication of code. Some lazy developer in the past had not even made wrappers to avoid direct usage of core classes like Shared Preference etc. So at each place same 4-5 lines were written.
Too much if-else ladders (4-5 blocks) & unnecessary repetitions of outer if condition in inner if condition. It looks like the owner of this nested if block implementation has trust issues, like that person thought computer 'forgets' about outer if when inside inner if.
Too much misuse of broadcast receiver to track activities' state in the era of activity, apપ life cycle related Android library.
Sometimes I think why people waste soooo... much efforts in the wrong direction & why can't just use library?!!
These things are found without even deep diving into the code, I don't know how much horrific things may come out of the closet.
This same app is being used by many companies in many different fields like banking, finance, insurance, govt. agencies etc.
Sometimes I surprise how this source passed review & reached the production. -
Seems like a pretty cool dev community.. Some quality memes with code puns are always a crack(err)..1
-
Is this a justified code review comment or a bully?
Code reviews are weakness of this industry which has the potential to attract bullies. Abuse of the comment box in a pull request and bombarding the employee with hundreds of comments can cause stress, frustration, burnout and finally resignation and costs of fulfillment for the organization. While companies should find and stop bullying in the work place, what kind of code review comment is considered a bully and why? Any of below traits can mean you are dealing with a bully:
1. Claims the code needs to be changed but doesn't say how. So no matter how many times you change your code, he can repeat the same comment: "Your code is still bad due to blah blah and it needs to be changed".
2. Provides how the code should be changed, but the change doesn't add up to quality, security, performance, readability, etc. i.e. "Why did you use a for loop here? Use a while loop instead". Or "Why did you write it using three classes A, B and C? Instead write it using 4 classes D, E, F and G which does blah blah". In the later case, not following the review comment, you won't get approval. Following the comment means you need to rewrite your whole code. After which, you might again receive more comments to change other parts of your code!
3. Claims the requested change is due to standards but claimed standard does exist anywhere. Internet, company wiki, university course books, anywhere. In more severe cases of psychopathy, the bullying person refers you to a link which hours later turned out to be written by himself! Have fun describing what has happened to your manager or team leader... .
4. Asks the code to be changed in a way that supposedly is closer to standard or of better quality, security, performance, etc. But the proposed way will not work and is the main reason you didn't do that in the first place. So you start arguing forever in the comment box over why his method won't work!
If you cannot see any of the above traits, then keep calm, take a breath, fix your code. Otherwise you might be victim of a bully.3 -
How do people check code quality during interview process online? I believe I write a very good one after 9years+ experience but never got passed...
-
When you have a BA who types things to prove that they do work, then you get to be the BA too. Good thing that architecture, test design, code quality, and sanity aren't really a priority.
-
Why every time Adsense reject my website
At first, due to not finding the URL, because at the same time I was handling the server
Then, Some errors in the AdSense code.
And now, they are not finding any quality content.6 -
Screw clients man, request multiple complicated changes to the payment and authorization model for month on end, not enough time to test and no QA team and then act all surprised when we can't consider 20 possible scenarios for every code change. Suck a dick while you're at it, we have other projects and clients that value quality over money milking customers with bullshit.3