Quality code I made, as always

Quality code you say...

Yes Linus Torvalds is an asshole and the world is better because of it.

In short Linus's acid takes on code quality over developer fee fee's might be one of the things that has made the Linux kernel and the GNU/Linux project such a long lasting open source success and in my opinion the risk of him falling for all this "let's be nice and non offensive" bs trend may impact negatively on code quality.

Being an asshole has it's downsides and it's not always the best response, I'll give you that, but personally I think most of us who are viewed as assholes are seen like that because we put quality over convenience, facts before feelings and dedication over mediocrity; it is not because we hate you, it's because we measure ourselves with the same stick.

It depends on one's character, but when you've been toughened up because of bullying(I don't doubt many devs have been since being a nerd has never been hip) or life in general, you learn to stop whining & pick yourself up and you expect everyone to be competitive and competent as you are and it gets frustrating to manage people who don't fulfill your expectations.

Pros: You get shit done and you do it well.
Cons: People won't like you and you don't tolerate failure (much less mediocrity).

Yes Linus is an asshole, my coach was an asshole, some of my best teacher's have been assholes, I had friends who were assholes, heck I'm an asshole!

But I thank them because they made me better than I was, just as people have thanked me for being the right amount of asshole.

A warm thank you and fuck you Linus, keep being the asshole we need.

Still true

Heard the plumber yelling because of the work someone before him did on my heating system...

As a programmer:

Your code is your karma 😅

The actual metrics to evaluate the quality of code 😂

How do I code....

Me: code quality is important

Everyone: <no shit given>

Director: code quality is important

Everyone: yes, it is very important, hurray!

Fast forward few weeks/months...

Me: why this function accepts 14 arguments?

ShitDev: yhm, you know, we need to fix it... maybe

Me: why this exception is swallowed?

ShitDev: oh, really? yhm, yhm

Me: why this function is copy-pasted and repeated (20 LoCs)?

ShitDev: yeah, true, but we wanted to make it fast.

Me: Dear director, this project sux and its quality is shit.

Director: you're exaggerating, it can't be that bad, it works, right?

Me: <polishing CV>

ShitDev: got praised for delivery

The only useful indicator of code-quality is the wtf-per-minute scale.

Please for the love of god name your variables in a sensible way! How the FUCK am I supposed to read your shitcode if you decide to write 6 (!!!) nested loops with variables each named by exactly one character. With no comments whatsoever!

I would rather crack password hashes than this nonsense.

Found this aesthetic gem in an ionic project which I have to enhance now 👌🏻

Today I felt sorry for my boss.

Story behind it:
My boss always encourages me to do the right thing. One of those right things is to enforce quality gates in our build pipelines which, as many of you know, means that the build fails if certain quality parameters are not met. Now an external vendor team merged the code this past thursday for a large feature that they had been working on and our build failed majestically throwing out the statistics and the offending files and lines of code.

All hell broke loose and there were escalations and what not and people working extra hours and over the weekend to try and get it right. So, I get a call from my boss earlier today to explain to me how important it is to release the feature and how it's going to be very bad if we don't. He was trying to justify his ask which was to lower the quality criteria and let the build pass for this week. Of course the dev in me was furious but then I realized it's not him but the corporate culture. Why would he or anyone would risk losing their jobs over the quality of code?

If you work at a place where IT is a support function of the company's primary business, I understand the moral compromises you guys have to make sometimes to keep the ball rolling. Thank you for your effort to make the world a better place.
So, thank you boss for all your support. I know it's not always up to you to decide on things but keep up the good work.

The first code review

I'm not sure if my in-laws know me really well, or if they are secretly plugged into Github and are making a comment on my code.

Volunteered to fix a brittle component in our app. Turned out to be 26 classes of mostly copy pasted code that is riddled with todos and void of feedback for the user. Here's a pretty representative sample of this code's quality:

just another day at office working on legacy code.

International quality of code measurement? WTFs/minute

KISS.
Keep it simple, stupid.

At the beginning the project is nothing but an idea. If you get it off the ground, that's already a huge success. Rich features and code quality should be the last of your worries in this case.

Throw out any secondary functionality out the window from day 0. Make it work, then add flowers and shit (note to self: need to make way for flowers and shit).

Nevertheless code quality is an important factor, if you can afford it. The top important things I outline in any new non-trivial project:
1. Spend 1-2 days bootstrapping it for best fit to the task, and well designed security, mocking, testing and extensibility.
2. Choose a stack that you'll most likely find good cheap devs for, in that region where you'll look in, but also a stack that will allow you to spend most of your time writing software rather than learning to code in it.
3. Talk to peers. Listen when they tell that your idea is stupid. Listen to why it's stupid, re-assess, because it most probably is stupid in this case.
4. Give yourself a good pep talk every morning, convincing you that the choices you've made starting this project are the right ones and that they'll bring you to success. Because if you started such a project already, the most efficient way to kill it is to doubt your core decisions.

Once it's working badly and with a ton of bugs, you've already succeeded in actually making it work, and then you can tackle the bugs and improvements.

Some dev is going to hate you for creating something horrific, but that horrific thing will work, and it's what will give another developer a maintenance job. Which is FAR, far more than most would get by focusing on quality and features from day 0.

A guy breaks into your house and start slapping your face with a huge C programming book for 5 minutes until you bleed top quality code from your nose.

Well this is what I was going to comment to the "learn C in 5 minutes app" rant, but can't find it anymore.

Boss: Have you finished that feature?
Me: Almost there, i'm refactoring some classes...
Boss: What? Refactor? But thisnis a new feature, it does not need refactor! We don't have time for this!
Me: 😵🔫

This is what happen when you care about code quality.

When I show someone my code

The rants I read here make me want to be a better developer. I started writing tests, linting code and ensuring 'quality code' because of the devrant community. Being a self taught developer, you never really have anyone to thank. But today I would like to appriciate you all for the rants, comments and advice that make us developers become better at our craft.

!rant

Some days ago I finished "Ray tracing in a weekend" (Peter Shirley) and I'm learning a lot :D

In the new year I will start with "Ray tracing the next week", but there are still some things I want to tackle before that (improve code quality, optimize... it's my first project that is bigger than a codeforces problem solution, a part from the projects at work).

Any sources of wisdom and recommendations are welcome!!

Gotta love XKCD Fridays

I am that colleague that writes bad quality code

This is how you know you write good code

"Quality CSS" is much a fucking misnomer. As someone whose been writing this shit at scale for 15+ years I can tell you all CSS code is garbage. The only thing you should do is make sure you don't have name collisions. Classes/components are self contained. And use variables when possible. DRY makes sense usually, but if you're dogmatic about it you shoot yourself in the foot.

No matter how much product owners claim "bugs have priority over anything else", "we value high quality structured code", and "we do test driven development"...

...Once a big client wants a feature to be developed before they sign up, dirty code will be written from napkin specs, and that code will always be refractored "soon".

I'm real tired of my coworkers always trying to one up me and being elitist about their code. Like I get it, you think PHP is shit, C is so much better than Java. Wow, you must be so knowledgeable! /s

Just because you're bashing on bad languages and talking shit doesn't mean you write good code, and in fact your code isn't top quality, I've read it. All you're going to accomplish with an elitist mindset is close yourself off to improving, and that's probably the worst thing you can do as a developer.

A nice word to all developers who say stuff like "I know I write bad code, but what does it matter.":
Please try to think in a logical way about what this part you are about to write has to do. It is much more difficult to rewrite code, the longer you wait after you started to code.
Bad code can have big impacts on different levels.
For example financially: Bad coding style or program structure can lead to thousands or much more in losses because of nasty bugs, bad performance, expandability or maintainability.
Think about quality over quantity.

A little example: I had to work together with other coders to meet a fucking tight deadline. The last day we coded like crazy and these dudes started to apply styling changes (CSS) directly as inline styles to the HTML code, instead of taking a few minutes more to find where in the CSS files they had to make the changes.
At the end of the deadline we had more stylingbugs than before. It took us another whopping 3 hours to fix what they had done.

So next time you code: Thinking before coding is mostly faster than just straightahead coding and fixing at the end. 😉

"I strive for code quality and maintainability. I actually do. And i will not work for a company that does not care about it and just wants something done as fast as possible.
The only time i will do something quick and dirty is if it's actually urgent. And even then with one condition - my next task will be to fix it properly.

I do not care about your deadlines. I will do my best to meet them, but not at the expense of code quality. I've seen too many projects fall into technical debt, where productivity is so low, that the only way to move forward is hire more people and start working on a project 2.0

And please do not lie about how great your company is, if it's not. These kind of things surface very soon, and you will have wasted both of our time, because as i said - i will not work for a company that does not care about code quality."

you think i'll ever get a job again if i put this on my CV ? :D

I wonder who is the imposter then

1. Refactor shitty code because it is hard to maintain
2. Rant about how can someone write a code like that
3. Check commit log to see who is the person to blame
4. Found out that's me

That moment when the you actually think that this huge refactoring isn't worth it, but you do it anyway so you can live with yourself...
Code quality is love. Code quality is life.

Cringed when I saw camelCase, snake_case, PascalCase and CONSTS (for non consts) in 10 consecutive lines of code! 😖😖😖

I suppose if you don't know which coding style to pick... Just try them all!!!!! 😱

An open letter to those who think lines of code == a decent metric for productivity:
NO!!!

Just because I wrote 10 lines of code all day (yes just 10 very well thought out, many times rewritten) lines doesn't mean my day was unproductive. Quite the opposite, while other devs pad their shit with:

//Adds 1 to I
I++;

Yup. Quality code. LOC doesn't lie.

!rant
Our lead dev in the company seems to be a smart guy who's sensitive about code quality and best practices. The current project I'm working on (I'm an intern) has really bad code quality but it's too big an application with a very important client so there's no scope of completely changing it. Today, he asked me to optimize some parts of the code and I happily sat down to do it. After a few hours of searching, profiling and debugging, I asked him about a particular recurring database query that seemed to be uneccesarilly strewn across the code.
Me: "I think it's copy pasted code from somewhere else. It's not very well done".
Lead Dev: "Yeah, the code may not the be really beautiful. It was done hurriedly by this certain inexperienced intern we had a few years back".
Me: "Oh, haha. That's bad".
Lead Dev: "Yeah, you know him. Have you heard of this guy called *mentions his own name with a grin*?"
Me: ...
Lead Dev: "Yeah, I didn't know much then. The code's bad. Optimize it however you like. Just test it properly"
Me: respect++;

if ($id != $product->getId()) {
return false;
}
return false;

What's the point?

Yo, is this devrant or spamspace???

Like, do you even fucking work, mates? Are you a dev? How doesn't a fucking legacy code piss you off on a daily basis? What are all the ways you want to respond to your customer's/PM's abuse? Does your lead dev even know jackshit?

Where did all your quality rants go? Why do you all sound like second graders writing essays for school? Have some passion for your job, and hatred for the incompetence for others!

Now, go produce some quality rants! Funny ones too! Bonus points if it's angry-funny.

The quality of my code and how often people reuse may be directly correlated to how shit it is.

How I spend my days at work working with legacy code:

* Writing tests before I do anything
* Noticing that i cannot write tests because of antipatterns. Lots of them.
* Refactoring to make at least a tiny bit testable.
* Then writing tests.
* More rewriting and refactoring
* Finally adding that one feature my boss asked me for
* Writing tests for that new feature (my do that before implementing)
* Explaining to my boss why it took me so long and agreeing on stopping writing tests.
* 2 days later: explaining why i still broke something.

But in the end my code works just fine.
my colleagues handle things differently. They just ignore problems as long as at least one feature works a bit.

My teachers use the number of commit you do as measure for the quality of your work.

I've the least number of commits this week since I spent most of the week doing encriptions algorthims instead of UIs and unit test as the rest of my team.

But, by their logic, I'm the worst of the group. It's simply stupid.

Yes, high quality code...

why dont any startup company concern themselves with quality.. oh i hate shipping shitty code.. 😞

Yeah git... I want to do this, too...

Use Meaningful variable names, they said.

I worked someplace once that fired a person for lack of quality output. Before that he sued the company over a labor dispute. After they fired him he went and founded his own business. A year later the company decided to recycle his old laptop to another developer and discovered the source code and business prospectus on it. The company took it to court and said it was actually their business because it was created on its own equipment and the time stamps confirm during business hours also. Courts agreed and they got possession of his business and then fired him again.

How often does this happen????

Then they can't blame us for code quality.

Me : *writes code and feel good about the result and quality *
Code reviewer : Dafuq is this shit

Everyone complains that a certain developer's code is not up to standard and when they have to take over his project the lack of code quality is really slowing them down.

I look at code, agree it is poor quality and put together a learning plan for said developer.

Also look at who approved every pull request which allowed bad code into our codebase. Same developers as those complaining it's no good. You had your chance to stop it!

Our CEO suddenly wanted to work with an outsourcing company to build the product. On one of the "sale" meetings I asked a guy from that company:
- Can we interview developers before they join our project?
- Our company is responsible for the quality of the service we provide, - the guy replied
- What are you going to charge us for?
- For all the hours developers worked
- So your service is developer hours, and we'll be obligated to pay for all the hours they worked regardless the code quality or the performance, right?

So it seems outsourcing company is only responsible for their time sheets to correspond to real hours worked? :-)

We call such a companies in Ukraine - a galley

the only valid measurement of code quality

A) Create something that works, is fast, minimum bugs, have edge cases covered, nice testes, clean code. Cool, you did your job. END.

B) Create something shitty with bugs, performance issues, non or poor test coverage, mess code, etc. Cool, you did you job. But...

Next week you reduced bugs by 50%. Wow, you're rockstar.

Another week you improved performance by 15%. Again, you're the hero.

2 weeks later, you reached 85% test coverage. Management is so happy that almost got orgasm.

"A" took 3 months, "B" took 3 months plus few months of fixes. The only time where B was winning was first 4 weeks, where A was carefully building it's architecture and quality.

Yet B is seemed more successful.

This industry is F****d Up beyond my understanding.

Apparently some freaking man in my ex-team tried to learn Vim because he thought he could become more efficient but he spend more than two weeks trying it while delivering poor quality code with extra spaces, bad indentation and extra "wq" strings

"Whatever, it runs fine..."
"So does a burning bus"

I was having dinner with two girls, one a project manager and the other some finance reviewer or something like that. We were discussing our line of work and I was talking about how bad quality code affects everybody and the finance reviewer girl goes like (and I quote) "In our company we use polymorphism, inheritance and encapsulation so it's not a big problem. So our database has a parent class and we only use the parent class". I was at a loss for words. I mean, if only more programmers just did that, right?

I saw this on the first page of a book that discusses techniques for writing clean code... The more I think about it, the more accurate it tests.

I'd say one of the best advice a dev gave me, was that, I should not write duplicate code, but rewrite these parts to a single function.

And another one: If you use specific values in the code, instead of putting it in multiple places, assign it to a variable at one place and use the variable later on.

These advices sound quite trivial, but I think every beginner should learn these as eary as possible.
Boiiii have I seen shitty code from people who don't give a hobo's ass about maintainable code.

Be a good coder.
Write for quality, not quantity.
Care about your successor.

Thank you.
If not, I will fucking find you, fill your guts with napalm and light you up alive on a rusty pole while laughing hysterically.

My current project is a fucking nightmare.

It started in 2007, using a solution developed by an Indian company due to outsourcing (aka low-quality code).

It's running on Java 7 on the back-end and its front-end side is pure Javascript files. There are thousands of little .js files everywhere, no documentation, no comments, differents coding styles, outdated API that were already outdated at the time, mixed oop and procedural.
Not even when I started coding, I wrote something so horrible.

Yo, it's a clusterfuck and I just wanna get drunk.

I think Clean Code: A Handbook of Agile Software Craftsmanship by Robert Martin should be a must to read.
In school no teacher puts emphasis on code quality.
They should learn how to name variables and functions the right way at an early stage in order to better perfect their craft :)

I'm task to amend the code smell in the project. I literally can cry a river.
I see such thing as i = i++; - It's flag out as a bug.

I have also seen check in classes. With un-used variables. I literally cried.

In the past, i ask why do i got to care about code quality. I actually start to get angry like the team leads in my project.

I dont see why recruiters find it relevant to ask how many lines of code a piece of software has. Like seriously why!?!?!?!

It by no means measures the quality of the code or the usability or complexity of the software.

Today I started work on a new project that contains a lot of legacy. I asked the developers about unit testing javascript and was told that not only is there none in place, but it's not worth adding any in.

At first, I grimaced and thought fair enough. This is their codebase, it's their choice. I've now been thinking about this for a few hours and have instead decided that screw those guys, I'm adding in a testing framework, a module pattern that's compatible with the existing code, and unit testing the crap out of it. If they don't want it they can refactoring it out, but I can't bring myself to intentionally deliver code I know is crap.

I WILL FORCE CODE QUALITY ON THEM.

Hired a designer below me.. guy never wrote a full back nor frontend... Used npm shit for all his solutions and worked his way above me just by kissing ass and polluting the codebase in such a way 70% would be open source shitty plugins for shit he could not do by himself code wise...

At some point he assigned some of his tasks to me and I couldn't work with his patchy framework that was non existent within the codebase I worked on ...

At some point between npm installed tantrums I got pulled up to HR because my code quality dropped... And it was this fucktart that accused me of this saying I could not do modern development...

In the end I either had to butkiss after his butts or just quit, so I did the latter... I told him and HR I owned alot more code quality than this asshat but just not his way of working and therefor it was more an issue of code equality I was never aware of ...

A month after that the company got overtaken by some silicon valley bullshit company buying up competition, and he is still working within that shithole dealing with 90's tech...

Was the best thing that happened to me, after that I grew alot in skillset and such by investments from other jobs and projects... If I would still work there today I would consider myself a caveman

Coding-related ads are always entertaining. They nearly always contain easily spotted nonsense and error-filled code. Not even sure where to start with this one...

IS IT REALLY SO FUCKING HARD TO CARE ABOUT CODE QUALITY AND READABILITY FFS

Code quality check punishes writing massive documentation strings due to "too many lines of code"

FML

Management: Create [totally idiotic and complicated feature, near to impossible to create]
Me: that's close to impossible and could probably destroy some other parts of the application.
Management: well, then your application is poorly programmed.

DAFUQ? HOW DARE TO JUDGE THE QUALITY OF MY CODE WITHOUT EVEN ABLE TO READ 2 LINES OF CSS? WHAT THE FUCKING FUCK IS THIS?

I'm really not easily offended but this sentence hit really hard.

So... Yeah... Code quality

All the noob jokes about "tee hee I write such bad code exdee" fucking drive me nuts.

There are absolutely such things as good codebases, in any language. By posting "tee hee funny relatable" "memes" about your shitass code you just make yourself look like a fucking idiot who excuses poor quality with "haha so relatable!" bullshit excuses.

Thank you for being the literal cancer of the industry, oversaturating the markets and making all of our managers think we're fucking idiot babies that have to be wrangled like cats in order to get a single feature out the door, devoid of rational thought or a modicum of expertise.

Fuck you. You're the problem. Be better or find another profession where slacking off is acceptable.

Gotta love moments when you find legacy code like this :)

P.S. Yeah, that was the whole script, written by just one guy.

The only valid measurement of code quality

The weekend is here!!!
Time to go out and have fun!!!

Nah just joking. Time to write some quality code after cleaning our company's backend (pun definitely intended) all week!

Our CTO doesn't believe that tests improve code quality. We have no tests on any level, no testers/QA, no code reviews. Nada. I wonder why production keeps breaking 🤔 Guess I'll start looking for another job 🤷‍♂️

2019 goals:

- finish my masters
- improve my code quality
- build at least 3 personal projects
- learn 2 new technologies
- find better clients or a good job

Found my old code.

You gotta admit, that's some clean code there, considering I learned C# only for a year at that time.

But those comments....
VeRy WeLl WrItTeN, vErY dEtAiLeD, vErY gOoD

Everyone is on their vacation and I am in good mood so time to refactor some 3 year old frontend, angular, javascript code. After 5 minutes of looking, some great quality of code snippet on the image below.

The feeling when random dudes downvote a question, because a guy who finally earned some points on SO dared to format the code with `<code>`<br> He pasted code, log, even explained a little bit and ~500 point guy even flags it like _unclear_ although there's clearly visible import error.

I mean... as an answerer or moderator, I'd be damn ashamed for such behavior! I have absolutely no problem kick a person with words + explanation in my answer or comment, so that (s)he remembers to ask better questions and feels bad about that, because nooby questions are already answered so many times there.

But to downvote because of formatting even if you have a permission to edit and a flag for low quality or because you can't read ~40 lines of log makes you just a retard and hurt the whole remaining community of guys like me who find time to sit there and answer questions to help another people.

"Potimized imports and remopved temp code"

Can't help but wonder what's the code quality like from an author of such a carefully written commit message 🤔

Staying up late night and sacrifice on sleep to complete the task at hand. A good night's sleep will result in good quality code.

let's try something...
Roast thread, please tag and insult your fellow devRanter in this comment section. Get creative in finding swearwords. Too many ++ bombs, poor code quality or you're just secretly in love with some other Ranter and hate it.

I carry the same mindset as an aspiring programmer as I did when I was a music major. There were times I practice for hours and got very little out of it in terms of quality (because I wasn't interested, focused or willing) and then there were times I practiced for 20 mins and really made progress on the piece. So I always keep that in mind to save me time and to produce better code overall.

Engineering managers will say things like -
- "I'll let the team decide what's best for them" & "code quality is our primary goal" -
but then they'll shoot down any & all requests to go back to some old piece of code and refactor/clean it, because of "deadlines".
Hypocrites, all of them.

You know you have a quality teacher for C code when you are writing a test and you have to write the code on a piece of paper

Fuckin accurate

Just like my client :/

These ambiguous frequent changes fuck my code quality :|

Code quality is not related to your self-worth.

Let's start by saying: God do I love programming and hate work!

My dream job would be a place where I get to write quality code for something that's actually useful and makes sense to people (or a group of people) without all the usual job bullshit; all the politics, fucking useless hours of meetings, the pretentious ass holes, and the useless mindless product owners with good pay to live comfortably and some organization (not being a complete disaster). It's only a dream though...

End user when criticizing a developer for 'taking long' to create something of value from scratch:
(4 hours later): "What's taking you so damn long? Are you retarded?"

Oh I don't know, maybe I have to make sure that tests in my code run well, maybe I have to evaluate everything to meet the custom satisfactions of the user for his ever-so-custom requirements and I also have to make sure I discard what they don't like? And maybe it takes time to deliver a quality product, and so on?
Or would you prefer I deliver an untested product that I didn't bother to think about and I haven't bothered to make sure it matches with their requirements?

What end users don't understand is the involvement in a quality product.

in Russian the word “шляпа” (fedora) means not only the specific hat but also something that makes no sense, something ridiculous or something of low quality.

So when someone sends you some spaghetti code on a review, you can just say “That’s fedora” and I love it. You can also WEAR a fedora and point to it as a response to someone saying something that makes no sense.

Why is source code so crappy? May career is not the longest, buy in my 8 years I talked to so many developers and every one told me how important quality, standards, tests and architecture are - but every codebase I've seen is lacking all of it. Everything is running on constant live support.

I don't get it. It is like I live in a world where everyone does know what has to be done, but no-one does it. I suspect it is because people are lazy, lying and won't say no but that's also not a world I want to live in.

When you're judged by the number of lines you wrote/commits you pushed/any other non relevant stat rather than your code quality

It's making me really anxious that I have to cut down on UI/UX as well as code quality just to meet my deadline.

I've taken a year's break from university to work on projects using various languages. For the first half, I've been trying to produce as much as possible. Now, I'm taking my time and producing less. I've gotta say, I'm enjoying it far more now. I feel like I'm learning more and producing better quality code.

Work of a my co-workers good work! It's called colspan you dumb fuck! Best part is that no way I'm changing this coz I work in place where they don't give a fuck about code quality! So fuck it!

Fuck unreasonable deadlines. Just do your stuff as if you have the time of the world. Stop compromising the quality of your work and things are going to be done when they're done. Good quality stuff that's worth the wait.

I started to tell this to myself this week. For months now I took the bait that everything is urgent. And whatever crap management want has to be done yesterday. But.... Well... They pushed it too effing far.

Redo this module that took the former team about six months to finish. You have 10 days.

Well... What? Everyone is saying yes?... Everyone going full code monkey making no progress?

This is the moment I stop compromising and stop listening to your suggestions. I am going to do what I know how to do, the way I know it works, and I will not cut one corner based off your suggestions. I'm sorry, I've been dealing with this shit for too long already, and I don't want to suffer the consequences of degrading the quality of what I write anymore.

Introducing the unified standard of quality measurement.

WTFs/Minute

is a new standard coming from code reviews, which also applies to movies, porn, women, ....

what's your opinion ?

One of my TL said to me during code review that place a break statement after return statement in switch case.

Being with a bar leader can certainly degrade your code quality.

When reading through someone else's code, what about it made you think "Damn this is well written" or similar?

Any language - I have a bias towards PHP, C++ and C though.

A friend of mine wrote a Rubik's cube timer in c# as suggested by me for him to practice. This was so terrible....There were lines like:

start.Stop();

I already had a previous succesful interview the day before and just went to my current employer out of decency.
The previous day gave me so much confidence, that I dominated the complete interview and asked them what they could offer me, that I would choose them.

On my way home they send me a text how much they were interested in me and that they will show me code as I demanded.

I took the job because the were as much interested in quality, as I am.

Found in adafruit dht library....
force is not used.

Code quality as measured in WTFs/minute.

Was helping my dad with his Arduino project when I realized something beautiful about being a programmer.

I have never worked with Arduinos and I'm clueless about hardware stuff but I was still able to debug, go through documentation, example code and fix the issues.

Programming is equally about the passion, dedication and ability + curiosity to solve a new problem as is writing some piece of quality code.

I might have taken a while to realize it but it sure is a wonderful feeling.

I am driven by my love for this industry and wanting to do everything to the best of my ability.

Being a strong advocate for quality i am always on the look put for new practices and finding new ways to improve my code.

If you consider a project 'done' then you gave up on it.

Coding faster is more important than code quality? GitHub shows a call to action: "Code 55% faster with GitHub Copilot". WTF?

I was mentoring a group of students and helping them with their graduation project. I taught them NodeJS, MongoDB & few other things.

One time, one of them came to show me her code, and it has the weirdest and most bizarre structure ever!

I asked her, “who told you to structure your code like that? This is wrong! I didn’t teach you this way!”.

She replies: “<<a local shitty tech startup name>>’s CTO”

When I searched about him, he’s a civil engineer who founded a startup and assigned himself as CTO with no technical background or knowledge whatsoever! FFS students believe that he’s a real CTO and started learning from him 😑 His code was so bad in every way that a fresh would write a better code!

You have angered code quality cthulhu!

Domain at it again. Left a foo bar guys. Quality development yet again

Code review?......... what's that?

Joke apart, We literally don't do that in my workplace, only few people care about code quality and what they are pushing to production

My senior and I started pair programming to improve my code quality. He likes it and I find it fun (and convenient that he helps me) but it feels like I'm making him do my work. I also fear that I am too horrible to be trusted with code alone but if that was the case they would kick me out right?

[Half question / half rant]

Would you rather work with a laid-back, humorous colleague who produces shit code and won’t understand advice for improvement?
Or would you rather work with someone who’s more serious, even slightly boring, but who takes quality seriously and is open to advice?

Yes I’ve worked with both types. Hands down I prefer working with the latter. With the first dude I’ll have good conversations and a good laugh at his puns and jokes. But at the end of the day I’m pulling my hair trying to make sense of his code and spending a shitload of time reviewing his PRs just to make sure he’s not fucking things up even more.

Me: makes the same mistake for the 1000th Git commit

My CI:

“We mob every thing so that means we don’t need pull requests, because by the time the code is committed it’s had plenty of pairs of eyes on it”

Well, I beg to differ.
Today I read through some of this spaghetti mobbed code to look into a performance issue. Wasn’t supposed to but bored stiff so I ‘went dark’ and did it without the mob.

After about an hour I figured out it runs a few lines of dubious code and if there’s an error it tries many times over with an exponential back off.
And each run of the methods will fail for sure because of how it’s written.
Someone must’ve seen this problem but instead of realising it can never work, they’ve wrapped it in retries and back offs.

So many back offs and retries that it just sits there doing this for 25 minutes.

But yeah. The mobbing works great guys, keep churning out this quality code. 😂😂😂
Can’t wait to see the back of this joke job.

I have a 4S I leave lying around and most apps are dogs on it or crash.

Not DevRant app, though. Pretty solid. Impressive job.

(I guess the Question category is the best for this)

Do you believe that someone can be a good dev even if they write shit code?

I personally do, if that person acknowledges the fact that their code is shit, wants to improve it, is humble, is always in the search for constructive, etc as in to make their code better and more readable, I'd think they are a pretty good dev.

I'm a junior dev, been on placement a year.

I get tasks done mostly on time, my pull requests are merged, yet I still feel like what I'm writing is seriously under quality.

What point will I stop writing code that isn't good enough to not be stressed about? 😷

So I got this new job as Java developer, the people are really great but is the kind of companies that only takes care for fast results and not for code quality.

Because this I have to deal with libraries updated 4 years ago, classes with 8000 lines, methods with 500 lines, a WHOLE lot of work arounds because there is no time to really fix the issue unless it affects directly the customer (something not working or being really slow) aaand we use fucking svn.

Some of this practice's they know and encourage it (+1000 lines classes for example) and every time I try to talk about good practices in the code everyone seems so interested but there is always no time.

Sooo I will stay here for at least two years, I hope I can make a change for good in their code smells.

Fuck my project manager. He wants to sacrifice code quality, test coverage and technical debt in favor of more features. In the future when everything takes longer or breaks guess who is responsible? Certainly not him.

For the first time apart from Data Structures and Algorithms, there was a Machine Coding round where they asked me to create a small app using any language without data persistence or GUI, to see my code designing ability, LLD, code quality, whether I can implement OOP and write modular code and to see how extensible my code will be.

I did well.

Took a chance at telling my bosses how burned out I am and had a really great discussion with them.

Turns out they want me to lead the front end team, because I'm good at it and can make them do higher quality work. Agreed with me that there's something wrong with the code if you have to use a different IDE lmao.

And I can use my 30+ days of sick leave (which I've never used because I don't get sick) to take time off when I need to. Burn out is a disease.

Not all bosses are shitty.

I coded part of feature 2 months ago.

Left it to help frontend guy a bit, deal with fire after release. ( we’re missing frontend integration tests and every release is pain in the ass ).

My backend code coverage is about 80% so not much can go wrong at this point.

So I added more code today and it looks like new feature is working but don’t know what the code I added 2 months ago exactly do.

The only thing I know is that it definitely needs refactoring ...

Being only backend dev / release manager / administrator/ dev ops in project is painful I need to deal with everything on my own 😔

At least client doesn’t care if it’s done in one week or in one month right now.

Working on codebase of a 20+ year old system that the company I work for bought five years ago and in that time there’s been no refactoring, no security updates, no attempt to create automated testing (there is none), new features have just been built on the codebase with no regard for quality and it’s just spun into the horror cesspool that it is today.

I joined one year ago and I’m slowly refactoring the codebase and updating it to get it to a more modern codebase, cleaner code, faster load times and creating a ton of dev documentation so the devs in India can start getting into best practices and start producing quality code.

Got a senior dev at work.

The guy is good at his job, no doubt, but his insecurity drives me up the wall.

- Constantly double checks work done by non-seniors.
- Setup a policy where only seniors can code review.
- Tells non-seniors not to give out advice as they don't know what they're talking about.
- Edits pull requests for you.
- Demands unobtainable quality for insignificant pieces of work.
- Patronising teams messages on the regular.

We're all just trying to get work done and he's always acting like we haven't got enough stripes on the badge.

Just going through some old code from git repo's and code examples and I have a message to every dev out there after seeing some of the code quality...

Never... ever... ever fucking give variables with names like vx, tr and sq.

Give your variables names that explain what they are, it is so fucking hard trying to follow code that has 2 letter variable names and there is a special place in hell for you :-)

A client asked for a tool for his website. So I built it for him and he was satisfied with the thing, cause it did what it should. Nevertheless I was not, because it kind of had a messy backend. I made it working and charged my time. Now I am wondering if I should rebuild the thing to satisfy my code quality for free, or just keep that thing as ugly as it is....

What your opinion on this?

Since graduation, I have worked in IT for 2 years, mostly in testing and implementation side. Finally I got a developer position in the field I wanted (Data Engineering). I had never thought that it would be such a soul crushing experience. My current company is very notorious for its bad management practices, but there is indeed a bigger picture to this. The IT industry in general has devolved into a gigantic ponzi scam built on exploitation and BS. Quality of solution and quality of work was replaced with a ‘Does it work now?’ approach with zero contingency. And the fact that geeks and nerds are naive only helps the white collar crooks to exploit them as code monkeys. Fuck all of this!

> do you feel sorry for freelancing contractors
> whose previous client abandoned them
> they ask you to help them fix some trivial bugs in the shitty code
> you believe you can change the world by going overboard by also improving the code quality, along with fixing the bugs
> initialize an empty file where you'll translate the shitty code into a more organized one
> start creating variables and generic functions which can be used in a modular and organized fashion
> meticulously document the first function you write
> realize this is not worth your time
> insert some glue code into the original code which fixes the trivial bugs
> glue code has hard coded values so it adds to the shittiness of the code
> submit the work
> get $$$

I hate those morons who do QA by simply clicking around. You are a disgrace to people like me who like to code and still enjoy doing testing.
Get a life you fuckers. You are the sole reason why many people in industry thinks that QA is something anybody can do.

Yes, I agree you can test the application, but in no way you could ensure the quality of the product.

Spent 2 days refactoring code written by our "offshore team". I've done refactoring on the same code in the past, probably upto about a week in total of refactoring now. The code looked like it was written by someone who had literally just finished their first "Hello World" app - loads of code blocks copied and pasted instead of declaring reusable functions.
The whole thing should have been done by us in the first place.
And yet our money-conscious company wants to employ more of these developers. Cheaper than us? Sure. Quantity over quality though, but I guess money is all that matters to the big cheese

It's nice reading other people's code. Make you realize that your not too shabby quality wise!

Recently, I failed a lot. Most of them were interviews. Some failed at code challenge. Some of them were leet code type challenge. Some failed at less quality vs other people. Used to be ashamed or angry. Now able to embrace it. Thanks to jack ma's documentary. Start to integrated his philosophy into life.

So just saw an email from our team's vice manager about need to improve code quality by using some new system.

Well that set me off on a huge rant about all the issues I see in my team and what exactly needs to change... (just some new sytem he's pushing isnt going to help)

wonder if i might get fired... even though i m right...

And so much for my plan to update docs... I've forgot what I wanted to do...

Worst experience?
Fourth semester. Programming project.
We were 4 persons, I did almost all the work (including fixing the stuff they broke) but that's not the point.

One of them somehow killed our git repo at least once per weak. It was really annoying, because I had to fix it.

Also he named *all* of his commits 'Pfuschpush' (Pfusch is German for botch). And the code had exactly this quality. I often had to rewrite everything he did (or simply revert the commit).

The industry is so incredibly demanding beyond measure.

Please be proficient in:
- Java, C#, Python, TypeScript, ReactJS, AI, UX, COBOL, AWS, DevOps, security, SecOps, Linux, Unix, System Administration, Database Administration,...

Yeah? Give me six years then before you try to overload me with stress in having to deliver top quality code using these.

I actively try to diminish stress in my life and the major cause of stress is my job.

My colleague told me today that companies with shit code quality, complete chaos, no tests of QA of any kind, and poor security practices still make loads of money and are extremely successful so it's all a waste of time.

I detest this idea and I refuse to work like that anymore. But I also think he's right :(

Code Quality

If you have no defined business processes whatsoever nor code quality practices, why bother putting on the job offer "software engineer" or "full stack web developer"?

WHAT YOU'RE LOOKING FOR IS A FUCKING PHP HACKER

One day a week should be for improving the quality of the code, not just bugfixing and rushed implementation of new features.

!rant
when you find 3 spelling errors in the same line of code and realize that these are legit 'cause the objects and methods are actually coded misspelled.

That's when no one dare doing code review but simply it builds and its fine.

Luckily #NotMyCode

Anybody can code, But not a quality code.

Commit functional changes separately to code quality changes

Otherwise I'll make you do it all over again 😤

How seriously do you take TDD, CI/CD, automated testing, clean commits, good architecture, Agile, low coupling/high cohesion, etc ... ?

How much time do you invest in those things if you have a deadline up ahead?

Have you seen these things being valued or disregarded at the previous companies you worked for?

Start the reading of "clean code".
First thing that i have learn "The only valid measurement of code quality: WTFs/minutes".
What do you think about it ? Agree or not ?

Fixed a high priority bug today just prior to release. There was 100% test coverage. The tests pass both before and after the change. The product behavior is correct now where it wasn't before. Just one more reminder that test coverage does not equate to either quality or correctness. Tests are alarms (at best), and quality of tests are no better an any chunk of code. All tests have costs, but not all have value. All reasons why I am skeptical of the value of code coverage, TDD, or anything that posits that "all tests are good".

Them: Maintaing code quality is a vital part of our team culture!
Me: Really, how important? Can a feature slip to facilitate necessary refactoring?
Them: Well no. We've made a commitment to the client.
Me: So, code quality is not very important then is it...

!rant

I've always been wondering why do tech companies need everyone to have a strong grasp of algos and data structures?

I've been coding most of my life but didn't get a CS degree so ended up in IT but I kind of want to get into a tech company as my thinking is the quality of code much higher (I spend a lot of time cleaning up other people's code and prod issues over the years...), I've been learning Algo/DS but when I see those technical questions on CareerCup, I go WTF.... it's this the kind of problems you guys do every day?

!rant

So this has probably been asked loads of times but I've never seen it. When working on solo projects for yourself do you still use source control like git or mercurial?

I usually don't because when I do personal projects its usually filthy and fast development to prototype quickly.

However, this current project I'm working on I am using git and I'm finding that slowing myself down just to follow good practice is actually improving my code quality and my understanding of my own project.

I need guidance about my current situation.
I am perfectionist believing in OOP, preventing memory leak in advance, following clean code, best practices, constantly learning about new libraries to reduce custom implementation & improve efficiency.
So even a single bad variable name can trigger my nerves.

I am currently working in a half billion $ IT service company on a maintenance project of 8 year old Android app of security domain product of 1 of the top enterprise company of the world, which sold it to the many leading companies in the world in Govt service, banking, insurance sectors.

It's code quality is such a bad that I get panic attacks & nightmares daily.

Issues are like
- No apk obfuscation, source's everything is openbook, anybody can just unzip apk & open it in Android Studio to see the source.
- logs everywhere about method name invoked,
- static IV & salt for encryption.
- thousands of line code in God classes.
- Irrelevant method names compared to it's functionality.
- Even single item having list takes 2-3 seconds to load
- Lag in navigation between different features' screens.
- For even single thing like different dimension values for different density whole 100+ lines separate layout files for 6 types of densities are written.
- No modularized packages, every class is in single package & there are around 100+ classes.

Owner of the code, my team lead, is too terrified to change even single thing as he don't have coding maturity & no understanding of memory leak, clean code, OOP, in short typical IT 'service' company mentality.

Client is ill-informed or cost-cutting centric so no code review done by them in 8 years.

Feeling much frustrated as I can see it's like a bomb is waiting to blast anytime when some blackhat cracker will take advantage of this.

Need suggestions about this to tackle the situation.

If the codebase quality drops below levels measurable by way of "WTFs per minute", determine further negative code quality by counting the amount of times per hour you wonder if you're in Hell and what exactly you did to deserve this torment

That feeling when the code in a massive PR is of very high quality... Only comment is about some class name...

The quality you perceive your code to be 6 months after writing it is inversely proportional to the quality you perceived it to be when you wrote it.

I used to love my job, the guy that looked forward to mondays, there was always something new to learn, I was passionate about clean code and learning new languages like Elixir. As a software engineer I thought my occupation had a special significance in this world, I saw possibility and potential of creating something so impactful on the world that it would become my legacy.

Now after 5 years I’m realising that none of this stuff really matters to the world, software engineers aren’t special and it’s evident from our salaries how valuable we are compared to other professions in sales, medicine or law. My friend who works as in customer success management makes more than me.

While some of us will be in the lucky few whose work will change the world, most of us will just be another cog in the wheel, all that matters is how many product/features you ship out, nobody gives a shit about code quality, concurrency and architecture design other than us

I read this rant on Quora. Is this true ?

“The IT industry has devolved into a gigantic ponzi scam built on exploitation and BS. Quality of solution and quality of work was replaced with a ‘Does it work now?’ approach with zero contingency.
And the fact that geeks and nerds are naive only helps the white collar crooks to exploit them as code monkeys.”

I felt so good after revisiting a project and everything runs ok
Code readable
Managed to pick off where I left off and fixed some existing bugs
Added new features and uploaded the update

Stakeholders must learn that code quality and a user-friendly frontend are not "nice to have". If they don't fix their priorities accordingly, someone will have to pay their technical debt and that's going to be expensive.

Wk33:

Best experience of 2016 is probably just realising I'm a pretty good programmer. I have a physics undergraduate degree and a 1 year masters in CS, I'm working on back end algorithm stuff so pretty mathsy at times, but I've found from working with others that I write good quality code. I've still got lots to learn but I've got a solid foundation, am reading, learning and coding outside of work.

Worst experience of 2016 is working with people for whom it's purely a day job, only about the money, get things done in whatever hacky way works.

Following my first rant, my boss had the brilliant idea of running the old and the new architecture in parallel. I had advised that it won’t be ideal since the same Scala code was ingesting into 2 different Kinesis streams and one was running an old KCL written in Java where as other was consumed by a Firehose delivery stream(eventually we will be ingesting it into Firehose directly). I had told few manual + automated tests on Code as well as from a functionality of the new architecture and a set of tests for checking the integration of the new Producer code with Consumer.

The statement I got from my boss was “This is the test, we test it on production in parallel”. My boss had a brilliant idea to fucking test the new code on the production directly but running them in parallel without accounting for undefined behaviour it might cause in the current production system. I mean my boss should get a Nobel peace prize for shattering our mental peace.

Anywho, we started the deployment today at 5AM in the morning. I had all the aws services deployed. Was just waiting to deploy the new Collector code which we did at 5AM. Immediately after 5 minutes the system went bonkers, there was fire, blood, demons and I was smoking a cigarette with the biggest “I told you so smile” on my face. I’ve just written an email to my boss and have told him calmly that “Listen motherfucker, 90 percent of the software companies aren’t idiots to focus on testing and quality. We need to start spending time on testing and quality else we’ll again be in the same soup after few weeks again”.waiting for his reply

So we have a confluence page all about best practices (there’s not even a lot in it) but when you check the repository, most rules are not followed 😭

dev: ugh we need to set and implement coding standards

same dev: no I don't need to follow what you just said, it's already clean and readable (it's not)

I have this impression that non-devs have this idea that you can ask for a developer to learn and implement a new technology with the same ease as ordering a Happy Meal.

Oh, you want me to learn a completely new technology, write very high quality, bug-minimal code, test it, document it, in a matter of hours?! Maybe senior devs can do this, but for me, it's like asking me to build software for NASA and guaranteeing it will work wonderfully without being given the time to thoroughly test it, design it or even think about it. Wooh, just code this as fast as possible and to industry standards quality!

Anyway... just another frustration.

Quality work, Fast work, Happy Engineers. . . Pick 2

We have all experienced inheriting a project and crying because of quality of coding. Somehow the project works but you can't explain how.

I guess I will not blame the previous developer. I guess in most cases it's the teacher who teaches that horrible method of coding.

I may be a self taught developer. But I can gladly say that I know how to code. However I can't say the same about my professor. Who makes you add percentage based margins and paddings (CSS) And make a fluid layout calling it responsive.

Fuck you Professor.

I've realized that what I once thought of as a glamorous job is really no different than any other. Speed and quantity is praised over quality and adoration is never received. Prestige is as much dependent on who you know than your code.

Maybe I'm just jaded.

"Whenever there is a decline in quality of code and rise of bugs and errors oh dear coder, I manifest to show the path of bug and error free coding" said code-god
- Chapter 1 Verse 1, Code Gita

So I was rejected by the management today for promotion to Senior 2 although I have done several major feature developments + infra design and basically end to end ownership.

Reason for no promotion? That's the best fucking part, according to the feedback, the work I performed on the service I created is well-designed,
and the code quality is commendable. However, they pointed out a notable difference in code quality between the micro-service
I built and the rest of the project developed by others. This, apparently, suggests that I lack a strong sense of ownership over the broader product.

First of all, we have super tight deadlines (almost 996), and I burned midnight oil to make sure the service I am in-charge of is designed really well.
Also, how in the flying fuck the other how the inability of others to maintain good code quality elsewhere in the product is being used as evidence against my sense of ownership
and initiative in ensuring high engineering quality for the repository I wasn't even working on

What a delusional management, the entire feedback feels like just an excuse to fuck off, we are not promoting you...
May be instead of doing actual engineering work, I should have just do minimal work and write more design docs / technical artifacts

It is very demoralizing after I worked hard for so many months, product went out really well.. yet when performance review comes, rejected with a petty reason

When coworker's code is like a burning bus

I love how our industry has invented such important sounding yet meaningless job titles...

Developer, software engineer, software architect, developer evangelist, dev ops engineer, systems analyst, quality assurance engineer, code monkey...

generally, the quality of code is inversely proportional to the number of public booleans

thing.IsThatTypeOfThing
thing.IsAVerySpecificTypeOfThatThing
thing.CanDoSomething
thing.EnableSomething

apparently that's where we're heading now :/

The cool feeling when you see your static analyzer that compare previous version and future release and code quality is improved.

At the same time the bad feeling because you was the same dev that made the previous version.

Quality != more work + less talk

Quality = more talk resulting in less work.

That makes no sense mathematically.

“Let’s talk more about shit before we create shit”.

That’s a little better.

“Let’s talk more so we don’t create shit”.

Getting closer.

“Let’s talk more about what is needed till we all know what is best before we program a damn machine?”

...This is going nowhere fast.

Okay fuck it. Let’s just code some stuff. It’s more enjoyable.

The code of conduct is a good thing. It doesn't persecute cis white men. All it does is tell you not to harass people on the basis of traits they cannot control. You say you only care about code quality and nothing else? There's a whole untapped market of talent from women and lgbtq+ people who stay the fuck away because of toxic communities. When you call people faggot it makes them not want to contribute to your codebase.
Linus stepped down of his own volition to try to become a more constructive voice. Heaven forbid the assholes have some introspection.

Hate it because it's vague. Hate it because it means anyone can be banned without evidence. Don't hate it because the assholes are finally being called on their bullshit.

So in our last retros some of my colleagues suggested to (forced) limit the number of lines per method in order to "maximize our code quality".

In the one hand I can see the benefits of this, such as easier testability when having more sperate testable blocks of logic.

But on the other side their code contains lots of such one or two lines private methods which get most of the cases not more than one time called. (And which I then can't even test separately)

I don't understand how this should help...
Is this really a thing? Am I just not "clean" enough?
(it's c# btw)

I just submitted my professional goals this year.

As I was writing them a lot of them actually sound like things my manager should be doing to increase code quality n agility n reduce the # bugs that end up in prod...

I am still confused why people treat testing as secondary position? Tester are paid less and they hire lower quality engineers. I think testing is as important as any other phase of development, like design or implementation. . . and yeah we do testing of our own code. The only thing I can do in my case is to see that people who change my code may not break basic functionalities. And again about edge cases, try to handle some other left to be seen in production( those which I could not think of due to lack of time) I take care not to leave edge case but sometime cannot do it. I just hope people realise the worth of testing.

I wanted to deploy the code of the project I'm working on on the test server to try something.

The code wasn't deployed because the automatic quality inspector detected some methods used are deprecated. So I check the documentation of the methods used. The method is a pass-by to avoid some errors launched by the automatic quality inspector.

So the quality inspector stopped my deployment because I used something that should stop the quality inspector provoking errors.

god dammit

When I have bad day and I doubt in quality of my code and my skills overall I open another project that is backbone of company business and I immediately feel much better after seeing what crap others produce.

Customer: The quality of the software you’re delivering is going down
Me: That’s because we’re developers, support, and spend all day on meetings without mentioning that deadlines are defined by you, not the technical team
Project Manager: I have added more members to the team so you can deliver faster
Me: That’s just slowing us down because this inherited code is shit, there’s no documentation and we’re always in a rush, without time for a proper ramp up
Customer: *throws money to our faces* I’ll remove two weeks to this delivery so we can test it better
Me: …

Teach students the importance of clean code/architecture and testing. Even if they dont yet understand the more complex topics such as architecture, they should understand why quality is important and that software is a craft more than a science. You cant just apply principle X and insert design pattern Y and profit++. You actually have to think and constantly improve. AND TEST.
Think I would probably also cover things like build automation and continuous delivery. These are now important things for junior devs to know about going into companies.

...is that someone who finds some, let's say, questionable quality code that I've written in previous roles, finds me again and calls me out on it...

Fixing out of scope/unrelated code quality issues when working on bugs/features.

Especially with older projects where pretty much the entire code base is a quality issue.

I want to code something today but don't want to get into it then have visitors show up.... Now I'm downloading Christmas music (FLAC in highest quality possible of course) and just browsing reddit.