8
Nexion
2y

I love when devs bitch about the size of PRs on a very standard sized one. They're all related changes that can't be broken up. Do you want the app to be broken between PRs? He spent more time bitching about the size of the diff and telling me how he does it better instead of just reviewing the code. A tip or an ask is one thing, this was a wall of text.

Oh and he still didn't approve the PR, which I know he looked at, and didn't leave any blocking comments.

Comments
  • 3
    This is compounded by the fact that reviews in this area of the code take centuries to complete. I'm lucky if I get one or two looks at my code a WEEK. Yes I have brought this up. No it hasn't gotten better.
  • 4
    I r commend using feature toggles so that you can break down work as small as possible whilst still delivering something working. Small PRS as a side benefit.
  • 1
    @Crost that‘s a great idea!
  • 0
    If my PR has a lot of changes sometimes I will add a comment to remind that reviewers can look at the changes per commit as well as the overall PR as a whole. I think this makes bigger PRs easier to review.
Add Comment