Join devRant
Do all the things like
++ or -- rants, post your own rants, comment on others' rants and build your customized dev avatar
Sign Up
Pipeless API
From the creators of devRant, Pipeless lets you power real-time personalized recommendations and activity feeds using a simple API
Learn More
-
@pmarius it wasn't hard to spot if you have deep knowledge of how instance variables are stored in memory and the way the system is set up (with multiple account based DBs)
We did have QA on the feature, but we didn't test for differences between accounts -
@mikk150 maybe I didn't explain myself correctly, let me elaborate:
Before refactor:
Perform 40K queries to DB - generate tree from results - show to user.
After refactor:
Perform 40K queries to DB - generate tree from results - save tree to DB - show to user.
So it's 1 query to DB after tree is generated unless an item has been modified, added, or destroyed. In that case we need to generate the tree from the 40K queries.
Recently made an account on Instagram.
Uploaded two pics
Deleted both of them
Now I've -2 posts
I had a ticket to enhance the loading of a page.
So instead of doing 40K requests to a MySQL DB in order to generate a tree and display it to to the user on each page visit, the initial query was optimized and moreover, the results are saved in a MongoDB which will then are served to the user on each page visit.
Long story short, after a code review the code got shipped to production and there was a bug which got fixed in a Hotfix shortly afterwards.
I got all the blame for the bug.
I don't deny I have a responsibility for the bug.
Do you guys think the code reviewer also has a shared responsibility for the bug?
undefined
bug
hotfix
code review
shared responsibility