14

Today I got my first PR approved and merged in 4 mins 🎉

Comments
  • 2
    @JustThat my daily routine XD
  • 4
    Lucky you, I created one PR for Rocketchat in October and it's still pending, pathetic.
  • 2
    My first PR was approved by @Kiki

    It was great learning for me, as a non dev, even when it was the easiest task.
  • 1
    me too. I added a documentation because I wasted a couple of hours trying to find the correct value.
  • 1
    I made a PR for React but the pipeline bugged out and got stuck on pending and I didn't have the energy to handle it ever since. It's a four line change with a far longer rationale and I don't think it'd get merged because the current behavior misses an important use case that my patch handles by introducing a minor footgun.
  • 1
    And I know the React guys prefer their library working in the most predictable way possible even if it means having to solve common problems with 3rd party tools.
Add Comment