Learn More
Resend Email
92
mzpro10
8y

I got hired to fix the script a developer before me wrote. That's just 1% of the shit!

undefined

fml
Favorite
Ranter
Comments
  • 10
    8y
    What's wrong with it? :D
  • 19
    8y
    @SirWindfield wrong logic?:p
  • 11
    8y
    @surgiie you got me, I wrote it :(
  • 4
    8y
    If its a free plan you thank the user for the purchase? Else ask if they upgrade? @SirWindfield
  • 9
    8y
    You must be new manteining legacy code OP, that code seems pretty decent, try to follow a bug on multi threads environments, all the business related stuff can't be explained in one pic...
  • 1
    8y
    @g-m-f hey I never understood, why would you add a space between the // and text?
  • 2
    8y
    @g-m-f o... thought it was some sort of style. Our code goes thru a style Checker that has this rule... I never understood why... Have to go back every time I commit and add spaces...
  • 9
    8y
    Add a ! in front of freePlan ?
  • 1
    8y
    @billgates What style checker do you use?
  • 0
    8y
    @pedro-abreu dunno jslint maybe... Is basically a commit hook
  • 4
    8y
    Whoever you are, if you don't curly brace those single lines I will find you and I will beat you!!

    Also consider a ternary statement...

    Review: Request Changes 😝
  • 0
    8y
    @r9software @pedro-abreu welcome to devRant!
  • 6
    8y
    The biggest problem I see : Doesn't have braces {} around if and else blocks.
  • 7
    8y
    I see a bunch of discussion about the style, what about the fact it's a photo of a screen?
  • 0
    8y
    @matsaki95 That argument only gets you a slap. I know you don't need them, but I insist you add them. And my style guide applies for reasons.
  • 4
    8y
    @matsaki95 Sorry - I was only messing with you. Appreciate your openness though - I like that.

    But, for me, in JavaScript particularly... it'd be:

    if (...) {
    ...
    } else {
    ...
    }
  • 0
    8y
    @matsaki95 Really? Really? Your rickroll is bad and you should feel bad. Tut tut...
  • 1
    8y
    @jAsE // ? I don't see a difference
  • 0
    8y
    He just forgot a ! Lol
Related Rants
devRant © 2021 Hexical Labs LLC
Privacy Policy  |  Terms of Service
Add Comment