Ranter
Join devRant
Do all the things like
++ or -- rants, post your own rants, comment on others' rants and build your customized dev avatar
Sign Up
Pipeless API

From the creators of devRant, Pipeless lets you power real-time personalized recommendations and activity feeds using a simple API
Learn More
Comments
-
TrayKnots586161dSometimes you do not have someone good to review. Still review.
As I told the juniors. Are you uncomfortable with telling a senior that he did something wrong, ask questions instead. "Why did you do this?", "Why is this static?", and so on.
That's what I did in reviews as a junior. Sometimes I just wrote: "What is this code doing, I don't understand it."
And basically, a programmer out of his field is just a junior programmer. So, ask question. If you have a point, the other side hopefully accepts it, otherwise, they will write a short explanation or come over and show you why. And everyone is happy. -
solex159161d@TrayKnots You nailed it!, that is the most diplomatic way to go about it but in this case the PR suggestions were bad and shows inexperience by the reviewer but when asked questions the answers recieved where simply saying do it like that and both are senior devs in their roles :😂 , i couldn't believe it untill i saw the slack conversation.
Can you imagine a backend focused engineer reviewing frontend PR because there is only one frontend engineer ? the frustrating aspect is the fact that the engineer gave baseless, false and crazy comments on things he has little idea on, i can't imagine having to school a backend engineer on a PR it soon start to look like war on the PR.
joke/meme