3
solex
161d

Can you imagine a backend focused engineer reviewing frontend PR because there is only one frontend engineer ? the frustrating aspect is the fact that the engineer gave baseless, false and crazy comments on things he has little idea on, i can't imagine having to school a backend engineer on a PR it soon start to look like war on the PR.

Comments
  • 2
    @retoor Yeah! really sucks and a complete waste of time, i had a call with my friend and he shared this and i was furious, he is trying to avoid conflict but he doesn't know how long both slack and PRs are on fire right now :😂
  • 2
    Sometimes you do not have someone good to review. Still review.

    As I told the juniors. Are you uncomfortable with telling a senior that he did something wrong, ask questions instead. "Why did you do this?", "Why is this static?", and so on.

    That's what I did in reviews as a junior. Sometimes I just wrote: "What is this code doing, I don't understand it."

    And basically, a programmer out of his field is just a junior programmer. So, ask question. If you have a point, the other side hopefully accepts it, otherwise, they will write a short explanation or come over and show you why. And everyone is happy.
  • 2
    @TrayKnots You nailed it!, that is the most diplomatic way to go about it but in this case the PR suggestions were bad and shows inexperience by the reviewer but when asked questions the answers recieved where simply saying do it like that and both are senior devs in their roles :😂 , i couldn't believe it untill i saw the slack conversation.
  • 1
    i can imagine
Add Comment