Learn More
Resend Email
31
Worst thing you've seen another dev do?
Week 99 Group Rant
BigAlan09
7y

I have previously seen this in a production code base. The same code base included nested if statements (20+ conditions)...

If (condition == false) {
return false;
} else if (condition == true) {
return true;
}

rant

wk99
Favorite
Ranter
Comments
  • 2
    7y
    Why not return condition? I am that lazy that I won't write that much useless code.
  • 7
    7y
    It's better than

    If (condition == false) {

    return true;

    } else if (condition == true) {

    return false;

    }
  • 0
    7y
    I don't understand why that's bad, was it in a function? If so, the return true/false might then be used later if you understand me right.
  • 1
    7y
    @pmso if that's in a function called returnTrueIfNotCondition and you call that condition, you want it to return true if false.
  • 1
    7y
    @RAZERZ return !condition;?
  • 0
    7y
    In untyped languages, it is possible to have none (python), undefined (JavaScript) or something entirely different(like a string)

    Although it depends on the situation and language.
  • 1
    7y
    @Noobish for example, if you want to check if user input contains a string and it does, you would want it to return true from the function, or?
  • 1
    7y
    @Noobish and then return true, right? But that doesn't look like it would work in a lot of languages
  • 1
    7y
    The condition was a simple boolean.
    The language C#.
    It was indeed in a function and I'm not sure why they couldn't simply write:

    Return condition:
  • 0
    7y
    @BigAlan09 no reason whatsoever.
    It may have happened over time though (multiple refactoring and people not quite checking the whole code)
  • 0
    7y
    Just use a simple switch statement...
Related Rants
devRant © 2021 Hexical Labs LLC
Privacy Policy  |  Terms of Service
Add Comment