The fucking cunts didn't approve my PR because "it wasn't necessary to do it like this". My PR would have fixed some technical debt, but yes, fuck you too if it doesn't fit your shitty narrative.

It's normally a decision upfront in dem team if refactorings should be done in a ticket. Some companies have "touch and refactor" policy and some "only what is required for ticket". I prefer without refactor too but wouldn't cancel ticket

What fuckers. I've only once had my PR declined and I went ballistic - fuck off and tell me what the problem. Speak to me first Jeuss

@retoor vaild point, but sadly our PM is a useless fuck and we have no tech lead for proper decisionmaking 😅

Leave code in better state then it was before you touched is ok with me, wouldn't reject PR for that.

Even if the 'just the tip' policy is in play.

Kinda been there, I once had this PR that fixed some silly configuration problem that had puzzled me and a couple other devs, making us waste time quite a few times, and would’ve puzzled new hires as well;

The ultra super senior tech lead guy kept a lengthy discussion on why it wasn’t necessary while me and others argued why it was

Only when the super senior tech lead left the company did we finally merge the PR, the problem was solved, and new devs hired afterwards were thankfully never aware that problem had existed in the first place

One project at my current company. They insisted on following OOP patterns in a TS rest api. Every attempt at simple solutions were rejected unless they followed OOP. It was a mess for data access. All of the developers left the company except for me. Since I’m the only one left… for the last 3 years I have been replacing entire chunks of OOP with simple to follow functional data access procedures. I remove about 300+ lines weekly in that repo to fix bug tickets.

All could have been avoided if they had listened to me in the first place.

@irene kudos for staying and fixing that mess!

@devJs believe me when I say I reconsider sticking around often. I also get annoyed when I see similar poor patterns from project inception and can’t change them. Compensation at the company is hard to beat.