Ranter
Join devRant
Do all the things like
++ or -- rants, post your own rants, comment on others' rants and build your customized dev avatar
Sign Up
Pipeless API
From the creators of devRant, Pipeless lets you power real-time personalized recommendations and activity feeds using a simple API
Learn More
Comments
-
@black-kite I'm literally the one in the post. And I definitely understand how you feel, but I've just dramatized the whole thing for memetic effect (the PR is big but I documented thoroughly the new things I've added and added docs for old parts of the code too,, and everything was coordinated with the rest of the team I'm not just shitting compiled binaries in prod)
-
Sounds far different than what’s going on in my team then 😉
The meme is good.
But i your case you at least worked in coordination with others and let them know what was coming -
Bruh!
I really tried to split my commit but it just was too massive and the changes too intertwined. So in the end there really wasn't anything i wanted to do about it.But i tested the stuff and it works.
So stop being a pussy and just wave it through. Trust me, bro. -
As long as I'm not being rushed by management to review it and it's been driven out with TDD and you paired / mobbed it
-
Gazotey541yIf someone does this, I will oblige for the first time and tell them to split next time. Thankfully, I have great colleagues, so this has never been a recurring issue.
If it would be though, there is the reject button. -
@Gazotey there was no way to split it, all the several tickets were tied to the same (flawed) logic.
> barges in
> slams massive unintelligible PR on the table
> fixes a bunch of tickets all at once
> won't explain how tf it works, it just does
> refuses to elaborate further
> leaves
rant
commit and push on friday
leeroy jenkins
goblin mode