Learn More
Resend Email
4
wojtek322
1d

if you make a PR, do you sometimes just fix the minor error yourself and push it and then approve it?

for example: like a typo in a variable or a wrong translation

rant

question
Favorite
Ranter
Comments
  • 3
    1d
    Yes
  • 2
    1d
    Don't quite follow but I can't approve my own prs
  • 3
    1d
    @ScriptCoded you can, if you change the policy :)
  • 2
    1d
    If I've triple checked that it really is a minor change and I haven't accidentally made it into a major change, and I have a reasonable amount of confidence in the test coverage, then yes.
  • 2
    1d
    @Lensflare Well, ain't no way anyone's changing the policy where I work 😅
  • 2
    1d
    Okay that's kind of a lie actually. I think I could have that changed pretty easily if the team was on board 😅
  • 2
    1d
    @ScriptCoded imo it‘s better to be able to have this permission to change it and just not to do it because of common sense than not having this permission and later being stuck when you are the single person working on that project.
  • 2
    15h
    Cosmetic bugs such as typos are not even worth making a PR about. I just fix them on the fly.
  • 1
    11h
    @TerriToniAX "OH MY GOD WHY DID YOU PUSH TO main/master" messages incoming
Related Rants
devRant © 2021 Hexical Labs LLC
Privacy Policy  |  Terms of Service
Add Comment