This is how one of our junior devs solved a merge conflict

Ok I think we can tell if this key is set already 😫

Why || many times on the same param?

And why not return isset...etc.?

Well we all started somewhere ...

/*slow clap*/

Probably would have worked just fine if *only* they checked to see if $query['pt'] was set another couple of times.

After 6 months he'll read that snippet and say "Oh my God, I can fix it!"

nChecksToBeReallySure = 1000
ret = False
for i in range(nChecksToBeReallySure)
ret = ret || bool(math.sin(isSet(...) * math.pi / 2))

if ret:
return True
else:
return not True

but why?

@SortaBubbly I don’t think any of us started here, lol.

Let’s not ignore the atrocious and misspelled function name.

good job for a junior dev

@SortaBubbly typically you start learning not to do this prior to employment

...

Well, he went full retard

Defensive programming

@pher DOP: Defensive oriented programing

Did I miss the stage where I was a Jr dev? cuz I've never written code like that...

@billgates even as a Jnr you should know that the first isset() is the only one ever to be evaluated if it returns true for this conditional.

So unless somehow you manage to have $query[‘pt’] be false, false, false, false,false, and then true without modifying it within the condition it’s useless and you really have done something beyond remarkable.

Oh how nice it is to be young and naive and young and naive and young and naive and young and naive.

Aaaah this reminds me of my first merge conflicts... good times

Is so cute XD

Ask your junior to explain what the code does line by line.. Slowly..