0

so what do you look when you do a "code review" anyway?

Comments
  • 5
    Say WTF a lot.
  • 1
  • 6
    Band-Aid fixes,
    Logic bombs,
    Nested loops,
    Database queries in loops,
    Things that make you go eeeewwwww

    In general, anything shocking that a junior would write, or will cause performance issues.
  • 3
    @Demolishun yup. WTF/min, the scale for code quality. Lower numbers means better quality. It’s practically impossible to achieve the value 0.
  • 0
    Btw, your question and your tags don’t fit together 😄
  • 2
    I am just junior so I mostly see spelling mistakes on variable
  • 0
    @miladiashe that’s important, too. I miss them too often.
  • 3
    'Rewrite' kek
  • 2
    @Lensflare is because I got that in an interview today I was unable to respond correctly
  • 2
    anything that might look hard to maintain, code performance, bad legibility
  • 1
    Wow what a great way to say you started code reviewing, lol
  • 3
    Does the changed part of the app even compile? (might be done by Ci)

    Does it pass every test (might be done by CI)?

    Dies it survive me, manually testing?

    Then Look at the Code.

    What has the linter to say?

    What did they do and does it makes sense?

    Did they handled error cases? Did they used appropriate return codes, exceptions, error prompts...

    Are all file, function an variable namens meaningful?

    Was it really neccessary to introduce this dependency? (defaults to no)

    Do the unit tests cover everything sich could potenrially happen? Why did they didn't write any?
  • 3
  • 2
    @horus _Dies it survive me_
    omg accidental or not, good pun
Add Comment