Join devRant
Do all the things like
++ or -- rants, post your own rants, comment on others' rants and build your customized dev avatar
Sign Up
Pipeless API
From the creators of devRant, Pipeless lets you power real-time personalized recommendations and activity feeds using a simple API
Learn More
Search - "codereviews"
-
I need to do codereviews at work...
Everytime i get c# code im just happy, it's beautiful to look at, easy to follow, new language features every couple of months or so...
And then I get Java/Android Code.... 😩☠🏃♂️🏃♂️🏃♂️🏃♂️🏃♂️.
(I mainly code in C++)3 -
This Pull Requests requires code reviews from four different teams, and most people in those teams are in timezones where they're already off work and I just started. 😩3
-
The project lead I have likes to go cowboy and run off and do a bunch of stuff on his own. He makes cards, assigns them to me, and then goes and does it himself negating my work.
He's engineering all our graphql queries to be totally different from literally everything else that exists in the codebase (every mutation is idempotent). The frontend guy brought it up and agreeded with me.
In our alignment meeting, the project lead tried to say these weren't bugs; that we can just handle the state on the frontend. I said they were definitely bugs that should be fixed on the backend.
Guy then says "You approved all my code reviews," implying I approved of the way we were doing things and they weren't bugs.
I told him, "I'm not trying to assign blame," and also, "Yes, I missed those bugs in code review."
I am fucking sick of this guy.1