Today we migrated from TFVC to Git.

Emotional times. This may become the reason for a future rant or it may be the best decision we've ever made (had made for us).

(first post/rant on here)
So I recently started at a new company. I was kinda aware that the project I'm working on would be rather old school (to put it in a nice way :-)).

Part of my job is to 'industrialize' and update/clean up the existing code so there is less time spent on fixing bugs due to bad design.

One of the first things I had to do was to write a new interface to integrate with external software.

I already noticed some rather nasty habits, like prefixing every variable with m (don't know why), private fields for every property (all simple properties) and a whole lot of other stuff that either is obsolete or just bad practice.

Started writing clean code (simple classes with properties only, no m prefixing, making sure everything is single responsibility, unit tests, ...).

So I check in the code, don't hear much from it again besides the original dev/architect that started the project using my code to further work on that integration.

Now recently I started converting everything from TFVC to Git (which is the company standard but wasn't used by our team yet). And I quickly skimmed through my code to check if everything was there before pushing it to the remote repo.

To my surprise, all the code I had written was replaced by m prefixed private variables used in simple properties. BL classes were thrown in together, creating giant monstrosities that did everything. And last but not least, all unit tests were commented out.

Not sure what I got myself into ... but the facepalming has commenced.

So been doing a TFVC -> Git conversion the last 3 weeks. I'm finally seeing an end to this mind numbing frustrating mess, so I was thinking 'this is a good time to write down my experience in a rant'.

So first of all, I'm working on a project that's about 10 years old, and didn't have a serious refactoring in that time (still runs on .net 4).

The project structure is f*cked up and seriously complicated the git conversion. For example forms only used in the winform application were in a solution for a web app, and file referenced in the windows application. But due to the fact that these forms also needed references to some business logic in the winform app, I had to constantly jump from one project to the other, fixing references to get this shit in NuGet. Sadly this wasn't the only case, and the other 40 project I had to convert from TFVC to Git had equally f*cked up stuff.

Only thing positive to come of this, pretty much decided to leave and start as a freelancer. At least I'll get payed better for doing shit like this, and I know it'll be a temporary thing and can move on after it's done.

My company will change the VCS to git. Now the though part is: GitHub or GitLab?