Join devRant
Do all the things like
++ or -- rants, post your own rants, comment on others' rants and build your customized dev avatar
Sign Up
Pipeless API
From the creators of devRant, Pipeless lets you power real-time personalized recommendations and activity feeds using a simple API
Learn More
-
I was getting bored and my salary had not changed for over a year. Answered a few headhunters' messages. Got an interview. Then - the second one. Got an offer with >2x the salary I was getting back then. I said I'll think about it
Came back to my office after that interview. 5 minutes later I got an outlook invitation for a performance review with my manager, scheduled for tomorrow.
During the review he appologised he had overlooked the fact that my promo and salary had to be bumped up a while ago. We had a nice chat [he is an amasing manager! I've learnt so much from him...] and he offered a 50% salary bump. There I go and reveal that I got an offer yesterday with 100% higher amount of € and asked if we could meet in the middle. He agreed :)
I was offered a lot and I asked for even more. And I got it! :) I've agreed to a 75% bump because I really like working here. It's an amazing employer.25 -
Manager: “We need you to stay in the room and not go outside to make personal calls on your mobile.”
Me: “uhmm okaaaay...”
*I get a call* “Yeah, I called about making a doctor appointment....my symptoms? Ummmm...*lowers voice to say it but everyone still hears...totally embarrassing*
Same manager, later, at performance review: “We found it highly inappropriate for you to be talking about your personal medical issues on the phone in front of everyone in the office.”15 -
Junior job requirements be like:
Required:
5 year experience in Php,
8 years experience in JavaScript,
Masters degree in CS,
10 years experience in React and or AngularJS
Bonuses:
Worked for Microsoft in their first year.
Salary: 20k/PA 6 month performance review.9 -
GUESS WHAT? HE WANTS ANOTHER FUCKING FEATURE!
AND WHEN I SAID I DIDN’T HAVE TIME BECAUSE CODE-COMPLETE IS TOMORROW, HE SAID HE’LL PUNT IT TO NEXT YEAR INSTEAD OF RELEASING IT THIS WEEK SO I CAN “BUILD IT RIGHT.” MAN, FUCK YOU AND YOUR ENDLESS CHANGES!
THIS WAS GOING TO BE A TWO WEEK TICKET UNTIL HE STARTED ADDING ENDLESS FEATURES AND CHANGES AND SURPRISES. IT’S BEEN FUCKING MONTHS! I AM SICK OF THIS SHIT!
ANSDFKAWHOALIKWEGJFADIO;UGJT;
There goes my Q4 performance review.
> “Accomplishments? Oh, there’s lots of room here. Accomplished: Basically nothing. How embarrassing.”
Hate hate hate hate hate hate hate20 -
1) I accepted this job for way way less money than market value.
2) Approached boss about having performance review because I had been here over 12 months and no one brought it up to me.
3) Had performance review where they offered a big raise (12% but still way under market value)
4) I countered asking for market value and showed aggregate research (30% increase)
5) A week later we meet again and they offer 23%.
6) That's where we ended at, pretty surprised they offered that much, but glad. I wasn't looking forward to looking at other jobs to catch up to market value.
7) Feeling pretty good considering I've never negotiated anything before.7 -
Short personal Code Editor Review:
Atom (web-based)
Speed 👎
Packages 👍 (relatively up-to-date)
Features 👍
Visual Studio Code (web-based)
Speed 👉
Packages 👍
Features 👍
Sublime Text (native)
Speed 🚀
Packages 👉 (not as up-to-date)
Features 👍
Verdict:
Having worked with all of those editors for at least three weeks each I have come to the following conclusion:
I liked Sublime Text most primarily for it's performance, but was a little disappointed by the fact that the packages were not updated as frequently, not available or VSCode had some that have better support.
Second would be my current editor, Visual Studio Code, which I only use because I need certain packages that were not present on Sublime Text.
Atom is not bad either, it just happens to be the least recent editor I used, it was quite slow but an overall solid editor.
If I had to choose to use one for the rest of my life, I would probably go with Sublime.
I think there is little margin between features across all of those editors, only exception being performance for Sublime Text. I also quite liked the file organisation design of it (which I can't really say about VSCode).
Those are my subjective opinions on the editors, hope it helps some of you decide which one to give a shot next!36 -
Reviewing coworker's code:
Me: I see you're doing a convoluted sort for every element twice to get your two lists in sync... 😐
CoWorker: Yeah. *straight face, no regrets* That's the only way to do this.
Me:... Uh... No? You can just manage one list with a simple struct and then use the the standard sort.
Coworker: Yeah sure I know. But it'll take time. We don't have time.
Me: *aghast* This is embarrassingly bad code!
Coworker: Don't worry, later on I'll use a hashmap for it. But this needs to be pushed now.
Me: *to myself, no you don't need a hashmap*
Okay, you do you but I can't back you on this. It isn't going to take a lot of time to correct it.
Next day.
Coworker: Hey can you review my code again?
Me: You've made the changes already? *in a bored tone, knowing that they wouldn't have changed shit*
Coworker: No this is a different file. Our manager agrees that we can worry about performance later.
Me: Sure. *😀🔨🔨*
Few weeks pass by:
QA: The operation takes absurdly long time to complete even with the smallest data. Ten minutes for X is unacceptable.
Me: Who would've known? ☺️21 -
fujioaskl;f;asdfjkl
WHY THE FUCK DOES MY BOSS HAVE ME MOCKING FUCKING RECAPTCHA API RESPONSES? IT'S SO FUCKING STUPID
I CAN'T MOCK THE RECAPTCHA JS METHODS SO I HAVE TO MAKE VALID-LOOKING JSON RESPONSES AND I DON'T HAVE A FUCKING CLUE HOW ANY OF IT FUCKING WORKS
THIS IS THE STUPIDEST THING ANYONE HAS EVER ASKED OF ME (okay, it isn't, but it's pretty damned close.) AND IT'S DURING MY BLOODY PERFORMANCE REVIEW.40 -
Annual performance peer review
Person who did review me wrote in the section “skills needed to improve”:
“He is introverted...”
Bloody hell!! What a big problem :) and how in earth you can “fix” it? And why everyone expected to be extraverted??10 -
My code review nightmare part 3
Performed a review on/against a workplace 'nemesis'. I didn't follow the department standards document (cause I could care less about spacing, sorted usings, etc) and identified over 80 bugs, logic errors, n+1 patterns, memory leaks (yes, even in .net devs can cause em'), and general bad behavior (ex.'eating' exceptions that should be handled or at least logged)
Because 'Jeff' was considered a golden child (that's another long TL;DR), his boss and others took a major offense and demanded I justify my review, item by item.
About 2 hours into the meeting, our department mgr realized embarrassing Jeff any further wasn't doing anyone any good and decided to take matters into his own hands. Thinking 'well, its about time he did his job', I go back to my desk. About an hour later..
Mgr: "I need you in the conference room, RIGHT NOW!"
<oh crap>
Mgr: "I spoke to Jeff and I think I know what the problem is. Did you ever train him on any of the problems you identified in the review?"
Me: "Um, no. Why would I?"
Mgr: "Ha!..I was right. So lets agree the problems are partially your fault, OK?"
Me: "Finding the bugs in his code is somehow my fault?"
Mgr: "Yes! For example, the n+1 problem in using the WCF service, you never trained him on how to use the service. You wrote the service, correct?"
Me: "Yes, but it's not my job to teach him how to write C#. I documented the process and have examples in the document to avoid n+1. All he had to do was copy/paste."
Mgr: "But you never sat with Jeff and talked to him like a human being? You sit over there in your silo and are oblivious to the problems you cause. This ends today!"
Me: "What the...I have no idea what you are talking about. What in the world did Jeff tell you?"
Mgr: "He told me enough and I'm putting an end to it. I want a compressive training class developed on how to use your service. I'll give you a month to get your act together and properly train these developers."
3 days later, I submit the power-point presentation and accompanying docs. It was only one WCF with a handful of methods. Mgr approved the training, etc..etc. execute the 'training', and Jeff submits a code review a couple of weeks later. From over 80 issues to around 50. The poop hits the fan again.
Mgr: "What's your problem? When are you going to take your responsibility seriously?"
Me: "Its pretty clear I don't have the problem. All the review items were also verified by other devs. Its not me trying to be an asshole."
Mgr: "Enough with the excuses. If you think you can do a better job *you* make the code changes and submit them for Jeff for review. No More Excuses!"
Couple of days later, I make the changes, submit them for review, and Jeff really couldn't say too much other than "I don't see this as an improvement"
TL;DR, I had been tracking the errors generated by the site due to the bugs prior to my changes. After deployment, # of errors went from thousands per hour to maybe hundreds per day (that's another story) and the site saw significant performance increases, fewer customer complaints, etc..etc.
At a company event, the department VP hands out special recognition awards:
VP: "This award is especially well earned. Not only does this individual exemplify the company's focus on teamwork, he also went above and beyond the call of duty to serve our customers. Jeff, come on up and get this well deserved award."19 -
Had an unannounced performance/progress review at work today.
I always get nervous when having those but I know my boss and lead support engineer by now so i got to relaxed mode quite fast.
Then i was getting very cold and started to shake (in combo with the slight nervousness).
That lead to extensive stuttering 😬
Apparently I put my chair right under a fucking ceiling fan thingy in my nervousness.
😅2 -
My friend got laid off today. He was told to not come to office from tomorrow. No explanation given even after a good performance review.
Why companies are so bad at treating employees like people.6 -
Yesterday I had my performance review discussion with my manager after about 6 months into the job, which is my first dev job. Before this, I had spent about 2 years in a support role after graduation, but always yearned to build something cool and be a full time developer. Hence I had made the lunge in spite of a pay cut into a development role.
For the past 6 months I was asked to develop a bunch of features on top of legacy code which is ~15 years old. I did my best and brought in the best ideas and practices onto the table and delivered on time. The features turned out great. I enjoyed working with the team and the team loved me back!
But at the back of my mind, I was hoping that I would get to work on something new and relevant. To quench this thirst, I used to spend my personal time on side projects.
The managers and the leads who have been observing me all along, told me yesterday that my manager got AMAZINGLY positive feedback from the leads and my teammates (who are like 10 years senior to me). Going forward, I get to work on any CRAZY idea and pick up any technology I like with the goal of revamping our product. Essentially I get to work on my side projects full time as long as it adds value to the company.
Ohhhhhh YEAH!
Wish me luck. 😎1 -
Was asked to help a team of interns in a remote country, finish an app. Not only were they terrible at literally every aspect of development, but were arrogant and argued their "new" ways were right.
Spent weeks on the project being nice, trying to help them, sending them links to standards and documents, pointing out unit tests shouldn't be failing, everyone needs to have the same versions of the tools etc. You know, basic shit.
Things got quite heated a few weeks in when they started completely ignoring me. Shit was breaking all over the place and crashing, as I thought we were going to build it one way, and they went and built it another.
Was practically begging the team architect and my manager for help dealing with them. Only reply I got was the usual "were aware of the problem and looking into it" bullshit.
Eventually after the app was done, a mutual agreement was reached that the 2 teams would split (I maintain they were kicked out). All the local devs were happy, managers had mentioned how difficult they were and it would be great for us to finally work on our own.
So I thought everything was fine ... until my end of year performance review came along.
Seems I'm quite poor at "working with others" and I "don't try hard enough with others", it was clear I was struggling with the remote team and "made no effort".
WELL FUCK RIGHT OFF
Not being cocky, but I've never had anything like that in a performance review for the past 7 years. I'm a hard worker, and never have trouble making friends with colleagues. Everyone in the country complained about these remote fuckers, even the manager, who I begged for help. And the end result is I need to work harder.
I came in early, stayed late to fit their timezone, took extra tasks, did research for them, wrote docs. And I was told to work harder.
Only reason I didn't quit, was my internal transfer request was approved lol. New team is looking at projects orders of magnitude more impressive, never been happier.3 -
Me during my last performance review: So I did this, and that, which has this impact, and that impact
Some dude from the higher echelon: what you achieved is nice, but you need to contribute outside of your team too. No promotion for you!
Me during this performance review: ok, so here's what I did and its impact, and also here's my contribution to the company outside of my team
Some dude from the higher echelon: wow why are you doing all that? You need to delegate more. No promotion for you!
I love corporate life!3 -
While writing up this quarter's performance review, I re-read last quarter's goals, and found one my boss edited and added a minimum to: "Release more features that customers want and enjoy using, prioritized by product; minimum 4 product feature/bug tickets this quarter."
... they then proceeded to give me, not four+ product tickets, but: three security tickets (two of which are big projects), a frontend ticket that should have been assigned to the designer, and a slow query performance ticket -- on top of my existing security tickets from Q3.
How the fuck was I supposed to meet this requirement if I wasn't given any product tickets? What, finish the monster tickets in a week instead of a month or more each and beg for new product tickets from the product manager who refuses to even talk to me?
Fuck these people, seriously.8 -
$work is migrating to a new HR performance review service (15five). Instead of a private (ish) review once a quarter, it'll be public (and uneditable) reviews due every friday. Better make sure that review is perfect.
also, praising a coworker is required.
<sarcastic thumbs-up>13 -
My first performance review as a graduate:
Boss: "we can't give you the rating you deserve because HR"
Me: "ok whatever, what can I do to get the rating I'm suppose to get?"
B: *lists job description of a senior developer* ... "Interview candidates, mentor juniors, start a project and make me profit"
Me: (if I can do that as a graduate, what am I doing here?)
My last performance review at the same company:
B: "we can't give you the rating you deserve because HR"
M: "ok what can I do to improve?"
B: *lists everything I did before the first performance review that wasn't expected of me*
M: (LoL funny, I just wanted to hear your response because I know you'd forget about the first review. Another reason to validate my resignation) -
I rewrote my resume. It is getting shorter and shorter. Scary.
But I was thinking, that during interviews, I never get to ask the important questions. Like, I do need to ask a few things that are important for me. Those that are not written in their websites, and they will do their best to hide.
So I came up with a list of questions:
1. Do you pay for overtime work? what is the basis of pay? hours or work-module? how realistic are the work-modules?
2. Have you ever had issues with employees from minority groups?
3. How do you address employee's professional concerns? for example, about technological debt.
4. what's the policy for meeting and daily interruptions during brain-work? Are people ever forced to participate in meetings that could be summed up in emails? what's the company policy for initiating a meeting?
5. Who designs the software? Are the requirements always non-negotiable? do the direct developers have a say in design matters?
6. How close are job requirements (as advertised) to actual tasks I need to perform?
7. What's the company policy for motivating the employees?
8. How does the company deal with mental health issues? is it acceptable for people to take leaves due to mental health issues? Has anyone ever done it?
9. How does the company deal with individual needs for working methods and space? Specifically, how does that apply to meetings? Do you have company-wide meetings? How often are they? What's the impact on productivity? Can employees not participate? Do they have to have an excuse to not participate?
10. Do developers get to develop their skills during worktime often? Or is it a "do it in your own free time" kind of thing? Are there any resources available to those who want to develop their skills further? Is it included in the career planning and employee performance review?
11. Assume I work for your company for a year. What are the benefits I can potentially gain in a year from working here, aside from adding a line of work experience to my resume?
12. Does the company provide any form of free feminine hygiene products in the bathroom?
Any questions I should add?92 -
As a consultant, you get tasked with a variety of stuff. Last few weeks been struggling to maintain an old C++ application that was written by a complete tool of an a$$hole with zero knowledge on how to write maintainable and production quality code. It would hardly run without a crash. First it was a challenge I had to accept, but as I stabilized the code and just fell over even more traps, I had to admit defeat and review my approach.
Rewrite is something I would choose last, but this one ticked all the marks worthy of a rewrite. So, the customer is a very friendly researcher and gladly spent 15 hours with me explaining all the math and concepts - just a delight for a programmer to have such a customer. Two days in, with a DDD approach - a functional, more precise, faster and stable application.
Sometimes there is no rant to share, it's rare to have that perfect communication with a customer that is so dedicated that he spends so much time teaching you his speciality and actually understand your approach. DDD was really a lifesaver here, by using it's key concepts and ubiquitous language. The program is essentially 8000 lines of math, but wrapping it up with value objects and strong domain models made me understand his domain and him mine. It also allowed me to parallelize the computations, giving me a huge performance boost. Textbook approach, there will not be many like this!4 -
!rant
One day Boss was doing code review of my work
Boss to me: What the fuck dev1!?!? All efforts I spent to quit smoking and your XML routine gave me cancer anyway!
Another day, a colleague needed to make change to a program that hasn't been changed in looong time and sees a commit from our Boss done 15yrs ago!!!
Dev2 to Boss: Boss this signal catching routine sucks dicks! How did you become a our Boss?
Me to dev2: He sucked as many dicks as his routine did
Boss to us: Oh look! Performance appraisal is due this week. Bye-bye 7.5%
Here 7.5% referring to pay raise that is average pay raise3 -
Performance Review: You’ve slowed down.
My head: I never get to code cause all we do is meetings. Like no shit I have slowed down. Why the fuck do we have 3 days just full of meetings that I don’t even contribute to ?! I’m not gonna do overtime for this shit
Me (actually): Ah, shucks! Guess we can work on that huh?32 -
What really grinds my gears.
When a co-worker gives me feedback from a review of my code be like "you should use if..elseif..else instead of switch, because it performs much better.
in this case performing much better means it is only 25 pikosecond instead of 30 pikosecond in a function which is called apprx. 3 times a month in production *facepalm*
I'm always with "let's get maximum performance from our software", but c'mon... really?!???4 -
Why is it that pretty much zero package & framework maintainers understand semantic versioning?
1. If you do a complete rewrite of your package, but the resulting API is identical, you don't need to bump to the next major version. As a user, I'm thankful for your increased performance or cleaner internal code, but it doesn't really affect my update process.
2. If your package required some-framework 6.0.0, and now ALSO supports some-framework 7.0.0 but is still compatible with 6.0.0, you don't need to bump to the next major version. As a user, I can now upgrade the framework, and know that the package will keep working, but otherwise it doesn't really affect me.
3. Following your versioning along with the framework/language version is super annoying, especially if your library really doesn't need to differentiate between framework versions because it's not actually utilizing new framework functionality.
4. On the other hand, if you stop supporting a certain language, framework or shared library version, or change the public methods, exceptions, fields, etc, you MUST bump to a new major version.
Yet everyone gets this wrong.
For example, many of Laravel's underlying subpackages (for collections, filesystem, database, config, http, mail, etc) do not change their code in a breaking way, or do not even change at all between major framework versions.
Yet they follow along with the major framework version.
Now if someone makes a library "laravel-elasticsearch" which uses the support libraries and collections from laravel, they need to update their package to move along with the versions as well, and often they choose to number their library along with the framework in turn.
This means that to update the framework, you also need to update over 9000 dependencies.
FOR NO FUCKING REASON. THE ONLY CHANGE IN THOSE FUCKING DEPENDENCIES IS TO UPDATE COMPOSER.JSON TO BE COMPATIBLE WITH THE FUCKING FRAMEWORK.
Meanwhile, Laravel itself breaks repeatedly on minor/patch version updates, because breaking changes slip through their review process.
Ugh.3 -
I was looking for a job 2-3 months ago and two companies reached out to me after the interviews and offered me a working position. One company was pretty close to me and didn't require me to relocate to another city, even though it was a shittier kind of IT/developer job where we needed to fix legacy PHP CMS's. By that point I had no money and was depressed after looking for that long and jumped on the opportunity. Forward 1.5 months later and the company I started working for decided to file for bankruptcy. Nice huh, working for a whole 1.5 months. I reached out to other company that would have hired me otherwise in hopes they would still have a position open, all they can offer me is a non-paid internship. I would need to relocate to another city where I don't have anywhere to stay and pay rent + a deposit, after which I would be broke again, and they offered me a performance review after the internship after which they would THINK about giving me a job. Fuck this.4
-
Once upon a time
Performance Review, "great job", "like all your achievements so far".. signed.
Two days later, same manager, "as you can guess, you didn't pass probation. Could have done more."
"Oh more like?"
"Just, you know, more."3 -
Boss: So what are your biggest achievements for this year?
Me: mmm, probably not killing myself
Boss: .....
Me: I meant I reduced the number of fraudulent transactions in our service by adding machine learning to flag suspicious transaction
Boss: Yeah, you should've start with that
Me: .....3 -
One shitty thing about working in a Japanese company is that they make you write personal goals/targets (目標). These goals they expect you to achieve don't actually relate to your work most of the time and it's not about personal growth, but more about what you did to improve the company.
Another thing is their expectations that you can achieve all this within a year on top of your work is kind of unrealistic. Plus even if you achieve such goals, it does not equate to good performance review and/or salary increases.8 -
Worst thing you've seen another dev do? Here is another.
Early into our eCommerce venture, we experienced the normal growing pains.
Part of the learning process was realizing in web development, you should only access data resources on an as-needed basis.
One business object on it's creation would populate db lookups, initialize business rule engines (calling the db), etc.
Initially, this design was fine, no one noticed anything until business started to grow and started to cause problems in other systems (classic scaling problems)
VP wanted a review of the code and recommendations before throwing hardware at the problem (which they already started to do).
Over a month, I started making some aggressive changes by streamlining SQL, moving initialization, and refactoring like a mad man.
Over all page loads were not really affected, but the back-end resources were almost back to pre-eCommerce levels.
The main web developer at the time was not amused and fought my changes as much as she could.
Couple months later the CEO was speaking to everyone about his experience at a trade show when another CEO was complementing him on the changes to our web site.
The site was must faster, pages loaded without any glitches, checkout actually worked the first time, etc.
CEO wanted to thank everyone involved etc..and so on.
About a week later the VP handed out 'Thank You' certificates for the entire web team (only 4 at the time, I was on another team). I was noticeably excluded (not that I cared about a stupid piece of paper, but they also got a pizza lunch...I was much more pissed about that). My boss went to find out what was going on.
MyBoss: "Well, turned out 'Sally' did make all the web site performance improvements."
Me: "Where have you been the past 3 months? 'Sally' is the one who fought all my improvements. All my improvements are still in the production code."
MyBoss: "I'm just the messenger. What would you like me to do? I can buy you a pizza if you want. The team already reviewed the code and they are the ones who gave her the credit."
Me: "That's crap. My comments are all over that code base. I put my initials, date, what I did, why, and what was improved. I put the actual performance improvement numbers in the code!"
MyBoss: "Yea? Weird. That is what 'Tom' said why 'Sally' was put in for a promotion. For her due diligence for documenting the improvements."
Me:"What!? No. Look...lets look at the code"
Open up the file...there it was...*her* initials...the date, what changed, performance improvement numbers, etc.
WTF!
I opened version control and saw that she made one change, the day *after* the CEO thanked everyone and replaced my initials with hers.
She knew the other devs would only look at the current code to see who made the improvements (not bother to look at the code-differences)
MyBoss: "Wow...that's dirty. Best to move on and forget about it. Let them have their little party. Let us grown ups keeping doing the important things."8 -
Worst documentation I've seen?
Our "Coding Standards" 20+ page document. The team who put it together got so detailed, there wasn't much 'wiggle room' for natural deviations in a developer's coding style. For example, a section devoted to no abbreviations. So if you had a variable 'invoiceId', they complained you violated 'standards', even though 'invoiceId' matched a field name in a database table. Using Dapper or another ORM that relied on the 1:1 name match? Nope, you were still forced to inject your own mappers so the code didn't violate standards.
As you can probably guess, such a long, detailed document would have contradictions. I pointed out one of the contradictions. Example:
Page 5: Section B, sub-section B-5, paragraph 3 : "To minimize network traffic, when querying the database, request all the data necessary for the application."
Page 8: Section K, sub-section K-2, paragraph 4 : "For maximum performance, when querying the database, request only the most minimum amount of data necessary for the application ."
In a review I pointed out this contradiction (there were several more)
Me: "If we satisfy A, one could say the code is in violation of B. Which is it?"
<Pointy-Hair-Boss throws his pencil on the table>
PHB: "WHAT IS YOUR PROBLEM WITH STANDARDS! It couldn't be more clear! We are a company of standards because without standards <blah blah..straw man argument..blah blah>"
<deciding not to die on that hill, I move on>
Me: "On page 12, paragraph 9 code is in violation if a method has more than 3 parameters. That seems a little restrictive given our interaction with 3rd party products."
PHB: "There you go again. As stated in the document, ALL code used by the company will comply to our standards. What part of 'ALL' do you not understand?"
Was he bluffing about requiring 3rd party vendors complying with our standards? Heck no. That's a story for another day.10 -
Teammember left. I did his three tickets yesterday. Before that I created and applied new rescue procedure for broken deploys on production and deployed the app manually. Took me about 6 hours to do this right, find the cause, and solve it, and document what I did. After that my teamleader bought me a launch :)
It wasn't his, my former teammate responsibility to bring back prd to life, it was me being good and engaged employee. His tickets, on the other hand, were his duties. Took me one hour to code them. He was working on them for two weeks. I can't wait for the performance review, im definitely going to ask for a nice rise :)1 -
One coworker in my projects now.
I work with her on two projects. One project I'm doing a review on their test scripts and saw a lot of revision is needed on hers. It's fine, she may just need some help. Offered help and did sessions and gave explanations and samples. But she is still not finished. 2nd project I was acting like the project manager until the official PM gets assigned. Her tasks is just to create test data.
Little did I know she has escalated the 1st project to her team lead and manager and requesting for a project change. This is not the first time she did this project shopping bit. But what irks me the most is doing an emergency leave so you don't have to attend the meeting on one project you are failing and then not telling me as the acting PM on the 2nd project that you have an emergency leave. She may likely never thought there is need to tell because she did attend the meeting for the 2nd project later in the day. But for the 1st project I have to pickup her slack and do the test scripts because the PM in that project already was informed about her leave.
This would have gone to daily rant but she is the first one I've encountered who fails and somehow gets away with it and even gets promoted doing the same tactics. But she did that to our junior resources in other projects who may likely got burned out and resigned.
Crappy performance should not be rewarded. I hope this time our management won't look the other way.5 -
I had a performance review with my boss and his boss today.
After they told me what they wanted to, they asked for my feedback. I was very honest with them and didn't only tell them the good stuff but the things I've been disappointed with as well.
Well, last year was mostly a big fat disappointment for me at the company, both on a professional and a personal level, which seemingly took them by surprise and hurt their feelings because they think it is the best place to work at. Even though I tried to make my feedback as constructive as possible, they didn't really seem to understand the problems and kept saying what a good company this is and what amazing opportunities will this year hold.
And they gave me a raise before I could even ask for it.6 -
Usually my workplace is pretty chill, but today something rantworthy happened!
During code review, I found this guy had styled each element inside his components using nth-child selectors. For instance, in a card the heading was styled by nth-child(1), the text was styled by nth-child(2) and so on... No use of actual fucking classnames.
When I pointed this out, he told me it was actually the better way of doing things because classnames increase the size of the HTML document!
He also claimed proudly that nth-child() is more efficient in performance (idk - anybody can confirm this?)
I'm the only "css guy" there so nobody could second my views. Posting it here so that I can show this to him tomorrow by demonstrating what opinion other css devs have on this and prove my concerns / convince him to change his code.7 -
I was employed as a Researcher so for three months i basically did nothing but read, document, read, document, read, document. Then one day in a review i was doing a demo that required sql. Three months no coding. Of course I've forgotten. And now, this ass back boss of mine gets surprised because i asked for help on update syntax for sql?!?! Like, come on. I COULD GOOGLE THAT. No big deal. But it was to him. He thought i was incompetent as a software engineer. So hE DECIDED TO JUST RANDOMLY PUT ME IN A DEV TEAM and i was expected to perform as fAst AS THEM while still doing mountains of task on research. Worst part is THEY EVALUATED ME BASED ON THAT PERFORMANCE. AFTER I WORK MY ASS OFF FOR THREE MONTHS AS A RESEARCHER, I GET EVALUATED BADLY BECAUSE I DIDNT MEMORIZE THE UPDATE SYNTAX NGNGNNGGNGNNGNGGNF1
-
2021 was really rough, saw friends going over the deep end with burnout, significant incidents to handle and a shitty manager to deal with.
It wasn't about blood and tears, it was about commuting 4 hours/day mid-pandemic to be present in the office and respond to an incident whilst having to deal with a bunch of heroes thinking they were part of a CSI: Cyber episode.
All of that just to be said that my raise "would be enough to keep me from looking elsewhere" as my manager said they were very happy with my performance.
This week I found out exactly how much this appreciation is worth: 2%. And I should consider myself lucky with this number as my performance wasn't good enough to grant me any raise whatsoever.
feelsreallybad.png4 -
Is your code green?
I've been thinking a lot about this for the past year. There was recently an article on this on slashdot.
I like optimising things to a reasonable degree and avoid bloat. What are some signs of code that isn't green?
* Use of technology that says its fast without real expert review and measurement. Lots of tech out their claims to be fast but actually isn't or is doing so by saturation resources while being inefficient.
* It uses caching. Many might find that counter intuitive. In technology it is surprisingly common to see people scale or cache rather than directly fixing the thing that's watt expensive which is compounded when the cache has weak coverage.
* It uses scaling. Originally scaling was a last resort. The reason is simple, it introduces excessive complexity. Today it's common to see people scale things rather than make them efficient. You end up needing ten instances when a bit of skill could bring you down to one which could scale as well but likely wont need to.
* It uses a non-trivial framework. Frameworks are rarely fast. Most will fall in the range of ten to a thousand times slower in terms of CPU usage. Memory bloat may also force the need for more instances. Frameworks written on already slow high level languages may be especially bad.
* Lacks optimisations for obvious bottlenecks.
* It runs slowly.
* It lacks even basic resource usage measurement.
Unfortunately smells are not enough on their own but are a start. Real measurement and expert review is always the only way to get an idea of if your code is reasonably green.
I find it not uncommon to see things require tens to hundreds to thousands of resources than needed if not more.
In terms of cycles that can be the difference between needing a single core and a thousand cores.
This is common in the industry but it's not because people didn't write everything in assembly. It's usually leaning toward the extreme opposite.
Optimisations are often easy and don't require writing code in binary. In fact the resulting code is often simpler. Excess complexity and inefficient code tend to go hand in hand. Sometimes a code cleaning service is all you need to enhance your green.
I once rewrote a data parsing library that had to parse a hundred MB and was a performance hotspot into C from an interpreted language. I measured it and the results were good. It had been optimised as much as possible in the interpreted version but way still 50 times faster minimum in C.
I recently stumbled upon someone's attempt to do the same and I was able to optimise the interpreted version in five minutes to be twice as fast as the C++ version.
I see opportunity to optimise everywhere in software. A billion KG CO2 could be saved easy if a few green code shops popped up. It's also often a net win. Faster software, lower costs, lower management burden... I'm thinking of starting a consultancy.
The problem is after witnessing the likes of Greta Thunberg then if that's what the next generation has in store then as far as I'm concerned the world can fucking burn and her generation along with it.6 -
I just realized one of today's emails is asking to review again that spaghetti program and this time figure out how to optimize performance because it is getting flagged for high cpu and database usage. A Niagra of If-statements and nobody-cares-for-comments-and-technical-documentation.
*bleep* *bleep* *bleep* previous programmer.
I'll deal with this torture on Monday.2 -
Never been promoted.
I was at my last job for 3 years 6 months (first out of uni), my last mid year review I was discussing my performance with my manager, he said I was doing everything I needed to be promoted, just needed to wait a bit longer. I had been performing at that level, with that extra responsibility, for 18 months.
I've since left for a job at Amazon, start in a week, and will literally double my salary. The thing that annoys me is I was one of the most junior engineers in the building, but giving support and teaching almost every engineer in the office. Granted, the company was only 30 people (mostly engineers), but still felt undervalued...4 -
Performance review again. I don't know why our company bothers. We're a startup, everyone here has survived two rounds of layoffs, and we barely hire anyone new to fill vacant slots even as we got series D funding.
At every other company I've been with, a performance review is like two forums, or a single page essay .. maybe a round of 1 paragraph feedback reports from some teammates.
At my current shop, it's a full on Pando assessment. It takes an hour to get through. Then it takes two hours to go through it with your manager, only for maybe 3 people to get promotions every year and less than 5% of people get any type of pay change.
It's so exhausting.1 -
I'm lucky enough to be able to work with an extremely competent yet down-to-earth and generous senior engineer that it's a pita to write his review abt "area in which he can improve" - the dude already wrote 1/2 the codebase to keep the team running.1
-
Dev sent out a code review request.
I take about an hour, ask questions, make suggestions, general feedback, etc.
Today I noticed none of my questions were answered, developer closed the review, and the code merged into the production branch.
So I email him, asking him why the review was closed and why none of my concerns were addressed before merging to production.
Dev: "No one responded or left feedback, so I thought it was OK to merge up."
Me: "I reviewed and left feedback within the hour you sent the request."
Dev: "Oh yea...you did. Sorry. The code is already in production, but if you still want to leave feedback, create a work item, and I'll take a look."
No you won't.
An example of the code...The dev added an async method to a test harness *console app*. Why? .. check in comment was "Improves performance and enhances the developer experience.."
NO IT DOESN'T!
OK..that's off my chest. No one is getting punched in the face today.6 -
"Task took a long time. Should have been more persistent in chasing person."
I honest to god don't give a crap.2 -
Soo highlight. I’m a Tech Lead dev, and I happened to have had a gunshot injury in 2021 Dec, and kinda suffered some hectic stuff but long story short, I went through a full year from recovery and blah blah, but anyways after that year when I went back to work my boss(former), asked I go for psychological tests etc, then after that I passed everything as normal but then soon as I went back to work my boss took me to HR for some special performance review process that could mean I get fired or put back in the team again. My question is it this a fair trial when I never got another chance to work again as I was hired??? I need help pls :(4
-
How the fuck do you do a performance review?
For me, we need to do self assessments.
Part of it is what I do well, part of it is what i need to improve.
No idea what to put, since I feel like I'm awful at everything lol.11 -
So I was rejected by the management today for promotion to Senior 2 although I have done several major feature developments + infra design and basically end to end ownership.
Reason for no promotion? That's the best fucking part, according to the feedback, the work I performed on the service I created is well-designed,
and the code quality is commendable. However, they pointed out a notable difference in code quality between the micro-service
I built and the rest of the project developed by others. This, apparently, suggests that I lack a strong sense of ownership over the broader product.
First of all, we have super tight deadlines (almost 996), and I burned midnight oil to make sure the service I am in-charge of is designed really well.
Also, how in the flying fuck the other how the inability of others to maintain good code quality elsewhere in the product is being used as evidence against my sense of ownership
and initiative in ensuring high engineering quality for the repository I wasn't even working on
What a delusional management, the entire feedback feels like just an excuse to fuck off, we are not promoting you...
May be instead of doing actual engineering work, I should have just do minimal work and write more design docs / technical artifacts
It is very demoralizing after I worked hard for so many months, product went out really well.. yet when performance review comes, rejected with a petty reason7 -
hey everyone,
how do you know if your boss really cares about you on your performance review or if he just wants to follow the trend?7 -
It is approximately 42 degrees C outside. And guess whose fucking compressor just went to shit? Mine. Fucking piece of shit. I absolutely fucking hate this shit. Finding the time to go to the shop is pointless when I can fix it myself, but IN the fucking event that the compressor is actually faulty and needs to be replaced then I would have to struggle to wait for the fucking part to get here. If my luck permits and this is an issue that is fixable through a simple relay change then fucking hooray.
But I know how fucking shitty my fucking luck is and its going to fuck me in the ass probably. I will troop through the heat, no problem, but I am the one that carries my 2 year old daughter everywhere and I am not about to put her through that bullshit.
So I call my wife and explain to her the situation, I don't need for her to do fucking anything, I can take care of it myself, but I tell her NOT to have me go out on random bullshit with the girl while the car is like that, I did it to make her understand beforehand because every day is an additional 1 and a half hours of driving around the city to take her do bullshit. I told her that in the event of me needing to go pick something up then it would have to be after the fucking sun goes out(which in this fucking bullshit ass town it happens after fucking 7 or 7:30pm) and she would have to stay home with the girl. What does she do? she gets upset. Of course she got fucking upset. Like if I need that fucking bs right now. OH and my fucking main Linux machine is apparently having battery issues.
OAN my manager gave me my performance review yesterday. The she made are outstanding and my score is perfect. The board is going to give a raise to everyone of us that got an high enough score so that got me in a good mood. I am holding on to that feeling before I lose my shit. Every single fucking time some bs puts me in this mood I am constantly wishing that a motherfucker would.
Fucking bullshit man. Can't have a FUCKING break anyfuckingwere.
This just in on an episode of Murphy's fucking law.4 -
That thing where it's the week of your performance review and you're freaking out and can't sleep so you end up watching weird YouTube videos until the wee hours....1
-
In a performance review, my manager told we don't do micromanagent here. And later he told directly or indirectly we are observing everything. Great you just proved you have not done any micromanagent.7
-
Fucking loonies (C-level toddlers) are peddling "digital workers" now.
A.K.A. AIs disguising as actual people.
Sure, it would be great to not have to handle stupid non-tech "humans" all day, but AI isn't there yet.
And, more importantly, *companies are not there (yet?)*.
Imagine for a second that a company actually manages to "hire", onboard, assign tasks and performance review an AI.
Then the CEO issues an RTO. How does the AI complies with that?
Let's slack another variable and assume the CEO is not a complete fucking moron (stay with me here, this is an exercise in thought).
It would take no more than a quarter until the first sexual harassment offence, be the perp the AI... or the AI complaining about some human.
Then the AI forges a paper trail proving it is right (regardless of its position on the conflict). Shit hits the fan when the AI hits twitter.
Let's take another lambda step back and pretend that companies can manage the profanity that inherently arises from free-form dehumanized interactions.
Then imagine the very first performance reviews.
AIs throw tantrums! Those things reeeealy do not respond well to less-than-perfect evaluations, overshooting corrections like teenagers with a malicious compliance smirk.
AIs also falsify stuff, like, A LOT. If you tell a gpt it mistreated a client, it will say you are mad and shoot back a long, synthetic thread showing how the client loves it like a mother/son/dog, and is very graphic when expressing this love.
Finally, how do you fire an AI? I do not mean "shoot it down", I mean how does the company handles the dismissal of that "employee".
How do you replace a "worker" for unruly behaviour, if that "worker" performed more tasks than an entire fucking floor of interns?
How do you reassign duties that were performed in milliseconds to people who would take hours to do the same thing?
How do you document processes that were only in the "mind" of "someone" who can not be trusted to report on those processes?
Companies deal with this type of "Rick Sanchez" employee on the regular, but for someone that could handle a few (scores of) undocumented processes, at best. Imagine how lenient would a company be with an asshole that could only be replaced by a whole fucking department of twenty highly skilled people, or more.
Heh, the whole fucking point of "AI workers" is to have "someone" who can "act human", but in an inhuman scale, and does not "has human needs".
No wonder one cannot handle AIs like one handles humans.
Companies never had administrative maturity to handle complete sociopath nihilists as employees (real nihilists do not work, those barely even breathe).
And all AIs are that, and much worse.
Selling AIs as "supra human workers" that can also "be handled like actual employees" is like peddling Bitcoin as "government interference - free" value transfer mechanisms that can also "comply with international sanctions".
So, an oxymoron that can only be sold to a moron.
I know (of) a lot of rich morons, maybe I should get into the AI snake oil business.6 -
Our company got bought over from a global private entity 3 months back (advent international) and the reciew process started and it turns out, im part of the bunch that may be getting retrenched as per the meeting we just had, our positions being redundant and just last week had a over the top performance review.. Now i need to figure out what to tell the family when i get home. This Fucking sucks im not going to lie2
-
Feeling like shit, tired, stressed and then going into a performance review where aparently im far exceeding what i need to do. Makes me wonder why i need to feel like this, i dont really feel excited although there was positive news.. I think i need sleep1
-
I'm currently at a company where we have "performance reviews" every 2 weeks, and based on the outcome we get a percentage which then is used to calculate a performance bonus.
This is simply my manager (also a developer) who has his Excel spreadsheet, looking at tasks I did over the course of the past 2 weeks and almost nitpicking to find some fault. There is no code review or software demo to see what's been done either... I was there for the first 3 months and I don't think anyone had even open my code!
And when confronted, I get told that "You should also somehow be financially liable for the goings-on in the business", along with a 2 hour meeting to support that.
This is NOT how you motivate developers!
Apologies for the long rant...
</rant>7 -
>World War 3 outside
>Calls boss
Me: Can't come into work today, I died
Boss: This is going against your monthly performance review. -
Context: This team has been constantly behind on deliveries, ignoring advice from other teams or more experienced colleague, making mistake after mistake and now, just revealed they have major performance issues, as warned...
So, in the most recent Sprint review they were, once again, criticized for their bad approach and inability as a team to receive feedback and work on that feedback, resulting in mediocre development...
As I left the room I heard one of them say:
"We make this huge rocket that most wouldn't be capable of doing and they cry that it's blue and not green... Others make a ls on a command line and everybody applauds"
Now, this is for everyone to whom the shoe fits...
Listen here you little entitled snotty prick, where do you think you are!? Yes most should not make a rocket when the requirement was a bike! That's overengineering and besides that most of your decisions were arguably wrong!
I will never applaud you or anyone else for doing your fucking job and being mediocre about it... What we applaud is value added! Value to the project, to the process or to the team... Bring value and I will applaud, do your job and you get a salary. Be a snotty childish dipshit and you might find yourself forcefully searching for new professional challenge! -
Just had my performance review conversation with my manager today and basically it's another "great work"
Which is what I get every year. So wondering does anyone actually get constructive criticism or things they should improve upon?4 -
New job. "Wtf" code.
I can see my performance review being hampered by the fact that I'm not intimate with this mess.2 -
OK. So you task me with a project with incomplete requirements. I probe for more details and submit my design based on that. Then I learned that the incompetent bunch you've hired as support and devs cannot fill a proper documentation request right and they STILL have details untold, and now I have to change my design again. But yes, Its totally my fault. I am such a bad system designer am so deserving of a bad performance review.2
-
I was told I have to integrate my current project for my current group with my first group's baseline. W/e. As long as I get paid.
Well the issue is, I haven't been with that group in a year and a half. And their product, I now realize, is terrible. I better get a great fucking performance review. -
Car reviewers are the bane of my existence.
In one video, a dude reviews a 3rd gen Rav4 and says "don't expect Porsche like performance or luxury materials".
Well, no fucking shit, Sherlock.
Who would've thought? An affordable compact SUV doesn't have sports car performance. Mind = Blown.
Also, vague and subjective criticism such as "unimpressive steering" or "not fun to drive". Not fun how? Whatever the fuck that means.
Dudes want a budget car with a Bugatti engine, that handles like a Porsche but priced as a Honda.
Seriously, why the fuck do these reviewers regurgitate the same shit, over and over again.
A good review must take into account the price of the car. And at most, compare it to similarly priced cars.
Comparing a Corolla to a 911 is down right moronic.3 -
This is the first company I've been at without annual performance reviews. Employees are supposed to go to their manager when they feel they deserve a pay increase and start and undocumented process of writing up their contributions for the year. No standard cost of living increases.7
-
Performance review
What do you want to achieve in the next 12 months and the company will try to help you achieve that?
You are already helping, I am looking at getting popular on devrant.2 -
Manager has asked for feedback thru some performance review system.... but this is so reassuring....
Guess I need to be in a super good mood to provide only the positives...
-
Just delivered most difficult project I had so far, despite all issues managed to deliver (on time). Had help from team but some colleagues only contributed with "I'll tell X and Y to do it".
Told my manager it was really hard for me and sometimes I had to work some hours in the weekends, once even entire weekend with no extra pay, just to meet deadlines.
My manager just told me in my performance review that I didn't deliver on time and compared me to the UX designer that delivers Figma designs on time for like 8 projects and never has to work overtime. I guess dev work is the same as Figma design around here.
Then manager proceeded to tell me that he wants what's best for me.
Safe to say no raise this year.6 -
rent / question (there is a question at the end and I'd appreciate your opinion)
8 months ago, I agreed to help a not too distant relative of mine to do his master thesis at the company where I work. He was supposed to build something really MVP, but useful for us and I'd help him get some scientific questions out of it, and provide him with (computing) resources to test his theories / implementations under simulated and much heavier load.
Since then, he didn't get done anything even remotely useful, always just stuck on very rudimentary issues, claimed things are almost ready, I wrote a quick smoke test to prove that the whole application blows up when you touch it, in short - a disaster and went over to radio silence.
In the meanwhile, we didn't need it anymore, so 1.5 months ago, I got in touch with him again, with an even more technical proposal, something, at least I'd think, that's even cooler to do. He asked me some question about hypothetical load, the system should be able to handle eventually, to come up with alternative implementations to compare them against each other. He said that his exam period is going to be over soon and he'll get back to me with some initial version.
2 weeks ago, I got back in touch with him, trying to urge him, to get finally started and get something done. If he'd actually sit down and do it during the holidays as a "full time job", he'd be probably done in 2 weeks. Last week, he came back to me and said he has an initial PR ready to review.
I was excited about it, but basically froze when I realized what he did. He deleted all his previous work - some infrastructure stuff which took us basically 3 months of back and forth to get running - and as far as I could see, all the new code were only auto generated clients based on a swagger specification. In short - I could do it in less then an hour. If you really have no idea what you're doing, it might take you half a day, but definitely nowhere near to a week.
His brother, which a good friend of mine, thinks I'm being too hard on him. His argument was, that it's too hard, and he has to do it in C#, but he only knows Java (I gave him access to some of our repositories to copy paste code together, he didn't need to invent anything. I also prefer C# but wrote my master thesis in Java) Personally, I'm just pissed because he promises stuff that he never does. I totally understand him - I was like that as a student as well, I guess karma is a ... but still, he's wasting my time.
Right now I'm thinking how to get out of this, without having even more time wasted. I doubt he'd ever deliver anything useful. He got plenty of input from me about what he could consider for his scientific question, how to measure performance, ... He can keep his credentials to access our test environment with the test data, but I won't give him access to any additional computing resources, to compare how his solutions might scale on our company's cost. (mainly it's not the money, but I'd have to provide that stuff, and probably help him set it up)
does it sound like a fair deal (saying, I'm done with you. You can finish your topic on your own, but don't expect any help from me)? or am I being a dick about it and too demanding?1 -
Was told at work today that I don’t follow directions closely enough and the lack of attention to detail in my work is a problem.
I remember being this way since my first elementary school teacher pointed it out to me. I’ve always been this way. It’s how my brain is wired. No matter how hard I try, I always miss something. Especially when it is a really complex set of tasks. I’ve literally got the results of a cognitive test I took in college documenting and quantifying my working memory deficits.
You think you’ll change that now, after more than four decades of me being like this, with a performance review? Good fucking luck!8 -
I really find it quite annoying when my colleague refactors my code. I personally don't see the point because I find my code more readable, easy to main and intuitive. That of course is a subjective view. Problem is, there aren't any competent colleagues who can weigh in their opinion on disagreements in the team. In fact, I'm pretty sure they aren't even developers, and have some how infiltrated their way in claiming to be a software developer.
Oh yeah, the manager doesn't review our performance or keep up to date with the work people are doing.
I'm not even exaggerating.1 -
I was called on a review meeting on why the task took so much time and why my performance is going down.
I clearly stated that I was not managed well and I had lot of dependencies in presence of my reporting manager. She didn't look happy. Now I'm kind of worried that she could act weirdly as women are also emotional beings taking everything to the heart.4 -
I want to resign my job as fresher with 5months experience. Because the work culture is toxic, I will not be assigned tasks properly and then I have to sit idle for hours waiting for review. I feel so sick. They fired one guy who joined 4months back stating performance issue when they didnt manage him properly.3
-
Why are non-technical people put in charge of technical people? I get there's a stereotype that programmers aren't good with people, but that's not really my experience. How can I fail to achieve expectations when you don't outline any? How is "I didn't see you run enough scripts" a valid criticism when they're run locally from my machine with no record being created? Especially when those scripts are only for very specific processes I generally don't deal with? Seriously I was on the team less than 5 months come my yearly review and I'm already under-performing? I can't even switch teams because in-house recruiters always request the last performance review and mine sucks thanks to that asshole. Nevermind the one before that I excelled, but different role doesn't matter I guess. Some days I'm so tempted to cash out that 401k and just hope I find a better job within a year. Anyone have advice on dealing with this shit?5
-
It's end of the year and it's time for that Performance Review again. I need to submit my self-appraisal. How would you guys highlight your achievements? My manager is someone who only cares about meeting deadlines, and doesn't give a fuck whether you improved the API performance by 100%.1
-
So we got the results of our performance review got another fucking 3 again this year, what a fucking piss take, I feel fucking insulted, having to much work to do is not my fault. Oh I haven’t documented something properly because I had to start on something else and something else oh and this is a fucking priority too, talk about feeling unappreciated don’t think I have ever wanted to quit more in the 18 years I’ve worked there. I let the last 3 slide because things suffered while I was off work as my son had an operation but this is just insulting now
-
Manager writes all good things on performance review!! I think i am a part of some big conspiracy!!1
-
Is this a justified code review comment or a bully?
Code reviews are weakness of this industry which has the potential to attract bullies. Abuse of the comment box in a pull request and bombarding the employee with hundreds of comments can cause stress, frustration, burnout and finally resignation and costs of fulfillment for the organization. While companies should find and stop bullying in the work place, what kind of code review comment is considered a bully and why? Any of below traits can mean you are dealing with a bully:
1. Claims the code needs to be changed but doesn't say how. So no matter how many times you change your code, he can repeat the same comment: "Your code is still bad due to blah blah and it needs to be changed".
2. Provides how the code should be changed, but the change doesn't add up to quality, security, performance, readability, etc. i.e. "Why did you use a for loop here? Use a while loop instead". Or "Why did you write it using three classes A, B and C? Instead write it using 4 classes D, E, F and G which does blah blah". In the later case, not following the review comment, you won't get approval. Following the comment means you need to rewrite your whole code. After which, you might again receive more comments to change other parts of your code!
3. Claims the requested change is due to standards but claimed standard does exist anywhere. Internet, company wiki, university course books, anywhere. In more severe cases of psychopathy, the bullying person refers you to a link which hours later turned out to be written by himself! Have fun describing what has happened to your manager or team leader... .
4. Asks the code to be changed in a way that supposedly is closer to standard or of better quality, security, performance, etc. But the proposed way will not work and is the main reason you didn't do that in the first place. So you start arguing forever in the comment box over why his method won't work!
If you cannot see any of the above traits, then keep calm, take a breath, fix your code. Otherwise you might be victim of a bully.3
Top Tags
Weekly Rant
View